Regression : Ripple color of checkbox turns very dark after press & hold action is performed via 'Spacebar' key.
Reported by
avsha...@etouch.net,
May 8 2018
|
|||||
Issue descriptionChrome Version : 68.0.3424.0 (Official Build) 7b31b2ed3f03336596e6193a8e93fd961bd06c03-refs/branch-heads/3424@{#1} 32/64-bit OS : Windows(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.5), Linux(14.04 LTS) What steps will reproduce the problem? 1. Launch chrome and navigate to any web-page to generate some history records. 2. Navigate to chrome://history page and tick the first entry in the record list. 3. Now press and hold 'Space-bar' from keyboard and observe the ripple on checkbox. Actual Result : Checkbox doesn't appears properly (i.e ripple color turns very dark) after press & hold action is performed via 'Spacebar' key. Expected Result : Ripple color of checkbox should not turn dark after performing press & hold action via 'Spacebar' key. This is a regression issue, broken in M-68 and providing the bisect using per-revision script: Good Build : 68.0.3423.0 (Revision : 556365) Bad Build : 68.0.3424.0 (Revision : 556637) You are probably looking for a change made after 556617 (known good), but no later than 556618 (first known bad). Change Log URL : https://chromium.googlesource.com/chromium/src/+log/7cfcd1107398f8d4d5a54fd7c7e55725731cd79a..c66ff270ccd4f9da64df108f8d1be21c7291d229 Suspect : https://chromium.googlesource.com/chromium/src/+/c66ff270ccd4f9da64df108f8d1be21c7291d229 @Scott : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.
,
May 8 2018
I see the reverse - I see on Canary the "expected" video behavior, and on stable I see the "actual" video. This means the issue existed all along but now we fixed it, I think? Please try again on Canary and let me know if the ripple-stacking can be reproduced for you
,
May 9 2018
Update: With respect to comment#2 Issue is still reproducible i.e.. Ripple color of checkbox is still turning dark after performing press & hold action via 'Spacebar' key. Kindly refer the attached video of latest canary #68.0.3425.0.
,
May 10 2018
Hi @Scott Issue is still reproducible on latest Canary build #68.0.3426.0. The checkbox turns completely dark on holding Spacebar key for few seconds. However i can not reproduce this issue on today's Stable #66.0.3359.170 build. Kindly note that, frequency of occurrence of this issue is 4/5 Thank you..
,
May 14 2018
dpapad@'s looking into another bug that might have the same cause.
,
May 14 2018
FYI the fix for issue 841693 seems to also be fixing the issue reported here.
,
May 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4dd6975d66203e2e566d1fe2a4113a519153996f commit 4dd6975d66203e2e566d1fe2a4113a519153996f Author: dpapad <dpapad@chromium.org> Date: Tue May 15 19:49:07 2018 WebUI cr-toggle/cr-checkbox: Fix case where space toggles twice. It was possible for the user to focus the inner <button> element via click (otherwise button has tabindex -1). After that, pressing 'Space' once would trigger both 'click' and 'keypress' toggling the state twice. Bug: 841693 , 840723 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If1200b6d39ac3eb4d6dc44e5622b75ed7f8beab8 Reviewed-on: https://chromium-review.googlesource.com/1058249 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#558811} [modify] https://crrev.com/4dd6975d66203e2e566d1fe2a4113a519153996f/chrome/test/data/webui/cr_elements/cr_checkbox_test.js [modify] https://crrev.com/4dd6975d66203e2e566d1fe2a4113a519153996f/chrome/test/data/webui/cr_elements/cr_elements_browsertest.js [modify] https://crrev.com/4dd6975d66203e2e566d1fe2a4113a519153996f/chrome/test/data/webui/cr_elements/cr_elements_focus_test.js [modify] https://crrev.com/4dd6975d66203e2e566d1fe2a4113a519153996f/chrome/test/data/webui/cr_elements/cr_toggle_test.js [modify] https://crrev.com/4dd6975d66203e2e566d1fe2a4113a519153996f/ui/webui/resources/cr_elements/cr_checkbox/cr_checkbox.html [modify] https://crrev.com/4dd6975d66203e2e566d1fe2a4113a519153996f/ui/webui/resources/cr_elements/cr_checkbox/cr_checkbox.js [modify] https://crrev.com/4dd6975d66203e2e566d1fe2a4113a519153996f/ui/webui/resources/cr_elements/cr_toggle/cr_toggle.html [modify] https://crrev.com/4dd6975d66203e2e566d1fe2a4113a519153996f/ui/webui/resources/cr_elements/cr_toggle/cr_toggle.js
,
May 15 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by scottchen@chromium.org
, May 8 2018