New issue
Advanced search Search tips

Issue 840715 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: ----



Sign in to add a comment

WebRTC roll breaks ios-device-xcode-clang build

Project Member Reported by ksakamoto@chromium.org, May 8 2018

Issue description

https://ci.chromium.org/buildbot/chromium.mac/ios-device-xcode-clang/59679

../../third_party/webrtc/modules/audio_processing/agc2/biquad_filter_unittest.cc:31:7: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces]
    {{-87.166290f, -8.029022f, 101.619583f, -0.294296f, -5.825764f, -8.890625f,
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../third_party/webrtc/modules/audio_processing/agc2/biquad_filter_unittest.cc:33:7: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces]
     {-64.647644f, -6.883945f, 11.059189f, -95.242538f, -108.870834f,
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../third_party/webrtc/modules/audio_processing/agc2/biquad_filter_unittest.cc:35:7: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces]
     {-32.350529f, -18.108028f, -74.022339f, -8.986874f, -1.525581f,
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../third_party/webrtc/modules/audio_processing/agc2/biquad_filter_unittest.cc:37:7: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces]
     {22.645832f, -64.597153f, 55.462521f, -109.393188f, 10.117825f,
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../third_party/webrtc/modules/audio_processing/agc2/biquad_filter_unittest.cc:51:7: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces]
    {{-86.68354497f, -7.02175351f, 102.10290352f, -0.37487333f, -5.87205847f,
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../third_party/webrtc/modules/audio_processing/agc2/biquad_filter_unittest.cc:53:7: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces]
     {-64.92531604f, -6.76395978f, 11.15534507f, -94.68073341f, -107.18177856f,
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../third_party/webrtc/modules/audio_processing/agc2/biquad_filter_unittest.cc:55:7: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces]
     {-30.1579652f, -15.64850899f, -71.06662821f, -5.5883229f, 1.91175353f,
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../third_party/webrtc/modules/audio_processing/agc2/biquad_filter_unittest.cc:57:7: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces]
     {24.84286614f, -62.18094158f, 57.91488056f, -106.65685933f, 13.38760103f,
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
8 errors generated.

I've stopped webtrc roll at https://webrtc-chromium-roll.skia.org/ .

 
Thanks, a fix is on the way, and I'll make sure the new roll passes the ios-device-xcode-clang build.
Labels: -Sheriff-Chromium
Owner: maxmorin@chromium.org
Status: Assigned (was: Available)
Removing from Sheriff queue and leaving to WebRTC-in-Chrome sheriff.
Status: Fixed (was: Assigned)
Rolled cleanly now.
[bulk-edit: disregard if N/A] Can the owner please set milestone to this bug if applicable?

Sign in to add a comment