Searching for terminal only works if you type 'terminal' |
||||||
Issue descriptionChrome version: (copy from chrome://version) OS: Chrome Repro steps: 1. Get a Pixelbook that hasn't had Crostini set up 2. Go to the launcher and type 'term' in the search box Expected: Terminal is a search result Actual: Terminal isn't shown until you type out all of terminal. I think this is a bug but maybe it is desired behaviour - Tom, can you clarify please?
,
May 9 2018
We don't want this to over-trigger for non-crostini users. It's arbitrary, but let's require at least "ter".
,
May 10 2018
not going to localize the name ? :)
,
May 10 2018
Ah ... good point :) We could handle this by matching the first three (or more) characters of whatever the terminal is called.
,
May 10 2018
,
May 23 2018
,
Nov 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/45d0ecd879d723c372675470d03aac771118ac2b commit 45d0ecd879d723c372675470d03aac771118ac2b Author: Timothy Loh <timloh@chromium.org> Date: Tue Nov 06 03:52:59 2018 Improve searching for the Crostini Terminal This CL makes a few improvements in searching for the Crostini Terminal: - Allow partial matches ( bug 840699 ). Instead of requiring the entire word 'terminal', allowa match from just 'ter' (but still require a few characters to avoid over-triggering). - Add additional keywords 'linux', 'crostini' ( bug 858822 ). - Add unlocalized (English) keywords. Users may still search for these as localizations of Linux/Crostini tend to be tranliterations. Bug: 840699 , 858822 Change-Id: Iabff74d9d8a61c2c2abcc50f9683b381c5dce126 Reviewed-on: https://chromium-review.googlesource.com/c/1280092 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#605589} [modify] https://crrev.com/45d0ecd879d723c372675470d03aac771118ac2b/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/45d0ecd879d723c372675470d03aac771118ac2b/chrome/browser/ui/app_list/search/app_search_provider.cc [modify] https://crrev.com/45d0ecd879d723c372675470d03aac771118ac2b/chrome/browser/ui/app_list/search/tests/app_search_provider_unittest.cc
,
Dec 13
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by vapier@chromium.org
, May 9 2018