New issue
Advanced search Search tips

Issue 840695 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Security



Sign in to add a comment

Heap-use-after-free in CJBig2_Image::~CJBig2_Image

Project Member Reported by ClusterFuzz, May 8 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5201753398837248

Fuzzer: ifratric_pdf_generic
Job Type: windows_asan_chrome_no_sandbox
Platform Id: windows

Crash Type: Heap-use-after-free READ 1
Crash Address: 0x123967171800
Crash State:
  CJBig2_Image::~CJBig2_Image
  CJBig2_Context::~CJBig2_Context
  CCodec_Jbig2Context::~CCodec_Jbig2Context
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome_no_sandbox&range=533127:533139

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5201753398837248

Additional requirements: Requires Gestures

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, May 8 2018

Labels: Test-Predator-Auto-Owner
Owner: tsepez@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://pdfium.googlesource.com/pdfium/+/bb1ee53577418429d2e30180bd941f16eea8b340 (Revert "Revert "Use UnownedPtr instead of T* in MaybeOwned."").

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 2 by ClusterFuzz, May 8 2018

Components: Internals>Plugins>PDF
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 3 by sheriffbot@chromium.org, May 8 2018

Labels: M-67
Project Member

Comment 4 by sheriffbot@chromium.org, May 8 2018

Labels: Pri-1
Labels: -Security_Severity-Medium Security_Severity-Low
Another stale pointer warning, not a blocker.
Project Member

Comment 7 by sheriffbot@chromium.org, May 10 2018

Labels: -Pri-1 Pri-2
Project Member

Comment 8 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/511f71f2d113829989df1949d1a9343f1d0019f8

commit 511f71f2d113829989df1949d1a9343f1d0019f8
Author: pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu May 10 20:13:17 2018

Roll src/third_party/pdfium/ 95061379c..80302c77a (5 commits)

https://pdfium.googlesource.com/pdfium.git/+log/95061379c945..80302c77a854

$ git log 95061379c..80302c77a --date=short --no-merges --format='%ad %ae %s'
2018-05-10 rharrison Use test_dir instead of 'pdfium' for source type
2018-05-10 thestig Add CPDF_Transparency.
2018-05-10 thestig Make GetTestDataDir() work in a non-standalone checkout.
2018-05-10 tsepez Fix destruction order in CPDF_Dibsource.
2018-05-10 npm Remove a completeness check from CJBig2_GRRDProc::DecodeTemplate0Opt

Created with:
  roll-dep src/third_party/pdfium
BUG= chromium:841513 , chromium:840695 , chromium:841200 


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I579c4a7663af521bb842f5e0f309f2bcd71732f3
Reviewed-on: https://chromium-review.googlesource.com/1054263
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#557647}
[modify] https://crrev.com/511f71f2d113829989df1949d1a9343f1d0019f8/DEPS

Project Member

Comment 9 by ClusterFuzz, May 15 2018

ClusterFuzz has detected this issue as fixed in range 557631:558316.

Detailed report: https://clusterfuzz.com/testcase?key=5201753398837248

Fuzzer: ifratric_pdf_generic
Job Type: windows_asan_chrome_no_sandbox
Platform Id: windows

Crash Type: Heap-use-after-free READ 1
Crash Address: 0x123967171800
Crash State:
  CJBig2_Image::~CJBig2_Image
  CJBig2_Context::~CJBig2_Context
  CCodec_Jbig2Context::~CCodec_Jbig2Context
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome_no_sandbox&range=533127:533139
Fixed: https://clusterfuzz.com/revisions?job=windows_asan_chrome_no_sandbox&range=557631:558316

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5201753398837248

Additional requirements: Requires Gestures

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by ClusterFuzz, May 15 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5201753398837248 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 11 by sheriffbot@chromium.org, May 15 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -M-67 M-68
Labels: Release-0-M68
Project Member

Comment 14 by sheriffbot@chromium.org, Aug 21

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment