Fuchsia death-test support breaks V8 deps roller |
|||||
Issue descriptionSee: https://chromium-review.googlesource.com/c/v8/v8/+/1049305 Fails on: https://ci.chromium.org/p/v8/builds/b8947129942725971472 /b/swarming/w/ir/cache/goma_client/gomacc ... -o obj/third_party/googletest/gtest/gtest-death-test.o ../../third_party/googletest/src/googletest/src/gtest-death-test.cc:67:12: fatal error: 'launchpad/launchpad.h' file not found # include <launchpad/launchpad.h> Maybe from https://chromium.googlesource.com/external/github.com/google/googletest/+/045e7f9ee4f969ac1a3fe428f79c4b880f0aff43 ? There's also a fuchsia sdk update in src/build.
,
May 8 2018
IC, lemme try a fix.
,
May 8 2018
Piggybacked it on the roll CL: https://chromium-review.googlesource.com/c/v8/v8/+/1049305
,
May 8 2018
,
May 8 2018
fdegans, sergeyu, jamesr: We're going to have this issue in DEPS repos which want to build for Fuchsia, in general, where they need the same basic GN rules as Chromium to present the SDK packages as GN targets with headers, etc. We should discuss whether the SDK itself can include the rules, so that all projects using it (e.g. Chromium, V8) can rely on them.
,
May 8 2018
machenbach: I'm thinking about reverting the gtest roll in chromium. Would that help you?
,
May 8 2018
it's fine if the deps roller is broken for 2-3 days. usually it doesn't take long for git admins to create a subtreed
,
May 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/1b0641577b32a7498f88f8ccf466bc2632d4fe98 commit 1b0641577b32a7498f88f8ccf466bc2632d4fe98 Author: Michael Achenbach <machenbach@chromium.org> Date: Tue May 15 08:40:54 2018 Update V8 DEPS. Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/1fd2d08..b61b6b6 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/3059fd7..e853531 Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/a6f06bf..045e7f9 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/de94aab..51de78a Also added fixes for fuchsia-sdk and additional DEPS entry. TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Bug: chromium:840669 Change-Id: Ic0370c56e98118780f02758e5ea057bb9026bacd Reviewed-on: https://chromium-review.googlesource.com/1049305 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#53176} [modify] https://crrev.com/1b0641577b32a7498f88f8ccf466bc2632d4fe98/BUILD.gn [modify] https://crrev.com/1b0641577b32a7498f88f8ccf466bc2632d4fe98/DEPS [modify] https://crrev.com/1b0641577b32a7498f88f8ccf466bc2632d4fe98/third_party/googletest/BUILD.gn
,
May 15 2018
Looks like it worked now.
,
May 23 2018
@wez: The rules in https://chromium.googlesource.com/chromium/src/+/master/third_party/fuchsia-sdk/fidl_library.gni have knowledge of chromium-specific things (like the location of the SDK in //third_party/fuchsia-sdk, existence of //build/gn_run_binary.py, toolchain setup). I don't think those will apply to all GN consumers, although perhaps a version of them parameterized with default_args could be more generically useful.
,
May 23 2018
Re #10: We have a load of DEPS pulled-in to Chromium that have their own GN rules that work stand-alone, but which have a |build_with_chromium| parameter to gate config defaults suitably for Chromium, which is what I had in mind. If we could do that without the Chromium-specific aspect then even better. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by w...@chromium.org
, May 8 2018