New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 840669 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 1
Type: Bug

Blocked on:
issue 840712



Sign in to add a comment

Fuchsia death-test support breaks V8 deps roller

Project Member Reported by machenb...@chromium.org, May 8 2018

Issue description

See:
https://chromium-review.googlesource.com/c/v8/v8/+/1049305

Fails on:
https://ci.chromium.org/p/v8/builds/b8947129942725971472

/b/swarming/w/ir/cache/goma_client/gomacc ... -o obj/third_party/googletest/gtest/gtest-death-test.o
../../third_party/googletest/src/googletest/src/gtest-death-test.cc:67:12: fatal error: 'launchpad/launchpad.h' file not found
#  include <launchpad/launchpad.h>

Maybe from https://chromium.googlesource.com/external/github.com/google/googletest/+/045e7f9ee4f969ac1a3fe428f79c4b880f0aff43 ? There's also a fuchsia sdk update in src/build.
 

Comment 1 by w...@chromium.org, May 8 2018

There is a new required dependency on the Fuchsia "launchpad" package,
which sets the include path correctly. We have that in Chromium at
//third_party/fuchsia-sdk:launchpad.
IC, lemme try a fix.
Owner: machenb...@chromium.org
Status: Started (was: Untriaged)
Piggybacked it on the roll CL:
https://chromium-review.googlesource.com/c/v8/v8/+/1049305
Blockedon: 840712

Comment 5 by w...@chromium.org, May 8 2018

Cc: sergeyu@chromium.org jam...@chromium.org
Components: Internals>PlatformIntegration
Labels: M-68 OS-Fuchsia
fdegans, sergeyu, jamesr: We're going to have this issue in DEPS repos which want to build for Fuchsia, in general, where they need the same basic GN rules as Chromium to present the SDK packages as GN targets with headers, etc.

We should discuss whether the SDK itself can include the rules, so that all projects using it (e.g. Chromium, V8) can rely on them.
machenbach: I'm thinking about reverting the gtest roll in chromium. Would that help you?
it's fine if the deps roller is broken for 2-3 days.
usually it doesn't take long for git admins to create a subtreed

Project Member

Comment 8 by bugdroid1@chromium.org, May 15 2018

Status: Verified (was: Started)
Looks like it worked now.

Comment 10 by jamesr@google.com, May 23 2018

@wez: The rules in https://chromium.googlesource.com/chromium/src/+/master/third_party/fuchsia-sdk/fidl_library.gni have knowledge of chromium-specific things (like the location of the SDK in //third_party/fuchsia-sdk, existence of //build/gn_run_binary.py, toolchain setup).  I don't think those will apply to all GN consumers, although perhaps a version of them parameterized with default_args could be more generically useful.

Comment 11 by w...@chromium.org, May 23 2018

Re #10: We have a load of DEPS pulled-in to Chromium that have their own GN rules that work stand-alone, but which have a |build_with_chromium| parameter to gate config defaults suitably for Chromium, which is what I had in mind. If we could do that without the Chromium-specific aspect then even better.

Sign in to add a comment