New issue
Advanced search Search tips

Issue 840668 link

Starred by 1 user
Status: Fixed
Owner:
bashi@chromium.org
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

S13nSW: external/wpt/service-workers/service-worker/clients-get-client-types.https.html is failing

Project Member Reported by bashi@chromium.org, May 8 2018 
The reason of the failure is that FetchEvent#clientId is an empty string when fetch() is called from shared workers.

Looks like we should supply clientId to ControllerServiceWorkerConnector in WorkerFetchContextImpl::ResetServiceWorkerURLLoaderFactory().

https://cs.chromium.org/chromium/src/content/renderer/service_worker/worker_fetch_context_impl.cc?l=348&rcl=38ffe94eb5ee5b175c9d579e1457ba9fc46b4728
Project Member

Comment 1 by bugdroid1@chromium.org, May 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c1ce9e5c598b40eb456693eefc74432e5ace5b8

commit 4c1ce9e5c598b40eb456693eefc74432e5ace5b8
Author: Kenichi Ishibashi <bashi@chromium.org>
Date: Fri May 11 05:53:02 2018

S13nSW: Set client id for shared workers

Store client_id supplied via ServiceWorkerContainer::SetController()
in ServiceWorkerProviderContext::ProviderStateForClient so that
we can pass the client_id to WorkerFetchContextImpl. This enables
us to set FetchEvent#clientId accordingly in shared workers.

Bug:  840668 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ie03290b9d70c3fd0d2a74e83d7881057ec3e1b51
Reviewed-on: https://chromium-review.googlesource.com/1049210
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557802}
[modify] https://crrev.com/4c1ce9e5c598b40eb456693eefc74432e5ace5b8/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/4c1ce9e5c598b40eb456693eefc74432e5ace5b8/content/renderer/service_worker/controller_service_worker_connector.cc
[modify] https://crrev.com/4c1ce9e5c598b40eb456693eefc74432e5ace5b8/content/renderer/service_worker/controller_service_worker_connector.h
[modify] https://crrev.com/4c1ce9e5c598b40eb456693eefc74432e5ace5b8/content/renderer/service_worker/service_worker_provider_context.cc
[modify] https://crrev.com/4c1ce9e5c598b40eb456693eefc74432e5ace5b8/content/renderer/service_worker/service_worker_provider_context.h
[modify] https://crrev.com/4c1ce9e5c598b40eb456693eefc74432e5ace5b8/content/renderer/service_worker/service_worker_subresource_loader_unittest.cc
[modify] https://crrev.com/4c1ce9e5c598b40eb456693eefc74432e5ace5b8/content/renderer/service_worker/worker_fetch_context_impl.cc
[modify] https://crrev.com/4c1ce9e5c598b40eb456693eefc74432e5ace5b8/content/renderer/service_worker/worker_fetch_context_impl.h
[modify] https://crrev.com/4c1ce9e5c598b40eb456693eefc74432e5ace5b8/content/renderer/shared_worker/embedded_shared_worker_stub.cc
[modify] https://crrev.com/4c1ce9e5c598b40eb456693eefc74432e5ace5b8/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Comment 2 by bashi@chromium.org, May 14 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment