Issue metadata
Sign in to add a comment
|
Regression:Extension is not visible in chrome wrench menu after clicking on 'Hide in chrome menu' option
Reported by
vineetha...@etouch.net,
May 8 2018
|
||||||||||||||||||||||
Issue descriptionChrome Version: 68.0.3423.0 (Official Build) 027d74876b8ce24839788395c78dce28b3750d2a-refs/branch-heads/3423@{#1}(64 bit) OS: Mac(10.12.6,10.13.1), 10.13.5(Macbook Pro Touchbar) URL: https://chrome.google.com/webstore/detail/grammarly-for-chrome/kbfnbcaeplbcioakkpcpgfkobkghlhen?hl=en-GB What steps will reproduce the problem? (1) Launch Chrome, add any extension to chrome(for eg: grammarly extension, use above URL) (2) Now right click on the extension icon seen on the RHS of the omnibox and choose the 'Hide in chrome menu' option. (3) Now click on wrench menu and observe. Actual Result: Extension is not visible in chrome wrench menu after clicking on 'Hide in chrome menu' option. Expected Result: On hiding extension from toolbar it should be visible in the chrome wrench menu. This is regression issue broken in ‘M-68’ and providing the bisect using per-revision bisect, Good build: 68.0.3418.0(Revision: 555652) Bad build: 68.0.3419.0(Revision: 555962) You are probably looking for a change made after 555739 (known good), but no later than 555740 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/f84f1651cc79986e851bebcbb5c3e9bc124ab63e..e132a7eb3c39e5839444aff108d783c2a68b92c2 Suspect: https://chromium.googlesource.com/chromium/src/+/e132a7eb3c39e5839444aff108d783c2a68b92c2 @spqchan: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: The issue is not seen Windows(7,8,8.1,10) and Linux(14.04) OS. Thank You!
,
May 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c6d105674d79b345f23686eed134a6e744eb9d3 commit 1c6d105674d79b345f23686eed134a6e744eb9d3 Author: spqchan <spqchan@chromium.org> Date: Tue May 08 16:13:57 2018 [Mac] Fix extension overflow menu The extension icons don't show up properly in the wrench menu. This CL fixes the issue by removing incorrect size calculations Bug: 825378 , 840658 Change-Id: I79de5e0b8bf0de4bc681418d6d7698b7b81e4164 Reviewed-on: https://chromium-review.googlesource.com/1048047 Commit-Queue: Sarah Chan <spqchan@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#556817} [modify] https://crrev.com/1c6d105674d79b345f23686eed134a6e744eb9d3/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm
,
May 9 2018
Update : Rechecked the above issue on Mac(10.12.6, 10.13.1, 10.13.5) OS with latest Canary Chrome version #68.0.3425.0 and the issue is fixed. Kindly refer the attached screen cast.
,
May 9 2018
Thanks! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by nyerramilli@chromium.org
, May 8 2018Labels: ReleaseBlock-Beta