New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 840646 link

Starred by 1 user
Status: Fixed
Owner:
█ blakeo@chromium.org
Last visit > 30 days ago
Closed: May 2018
Cc:
omrilio@chromium.org
█ blakeo@chromium.org
yhanada@chromium.org
pcovell@chromium.org
█ dvallet@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Dragging position seems not to be saved.

Project Member Reported by yhanada@chromium.org, May 8 2018 
A call of SavePosition in HandlePoinsterEvent will be removed in https://chromium-review.googlesource.com/c/chromium/src/+/1047448

I guess, this should be saved before return. Blake, can you take a look?
Project Member

Comment 1 by bugdroid1@chromium.org, May 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/384fc1a7def0d081588aee84a859920d6413798e

commit 384fc1a7def0d081588aee84a859920d6413798e
Author: Blake O'Hare <blakeo@chromium.org>
Date: Tue May 08 08:21:05 2018

Floating Keyboard container behavior had unreachable code

Re-arrange the return statement to fix this.

Bug:  840646 
Change-Id: I1c550de4433f59a70ab04b430d3d2c95e87e5d7c
Reviewed-on: https://chromium-review.googlesource.com/1049411
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Blake O'Hare <blakeo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556725}
[modify] https://crrev.com/384fc1a7def0d081588aee84a859920d6413798e/ui/keyboard/container_floating_behavior.cc

Comment 2 by blakeo@chromium.org, May 9 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment