New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 840641 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

touchable app context menu icon is not sharp on HiDPI screen

Project Member Reported by warx@chromium.org, May 8 2018

Issue description

Repro on emulator:
enable by --enable-touchable-app-context-menus
set --ash-host-window-bounds=1536x1152*2

Is this a known issue?

 
pixelbook.png
5.6 MB View Download
emulator.png
335 KB View Download
It might because the icon ImageSkia travels through mojo before it has 2x reps.

Can you try adding a item->image.EnsureRepsForSupportedScales() to [1] to see if that helps? 


[1] https://cs.chromium.org/chromium/src/ash/public/cpp/menu_utils.cc?rcl=1612a8168941ac7089a2d53ac7943a1aa8c7cf19&l=33
Owner: newcomer@chromium.org
Sure.
Labels: M-69
Owner: warx@chromium.org
Status: Started (was: Untriaged)
warx@, I can't repro this locally on yesterdays ToT using the settings that you specified.

Is there something else different about your setup?
Screenshot for posterity.
Screenshot from 2018-05-08 08-43-43.png
115 KB View Download

Comment 6 by warx@chromium.org, May 8 2018

You might need to change display scale by ctrl shift +/-.

Tried on #1 suggestion, issue still exists..

Comment 7 by warx@chromium.org, May 8 2018

There was a similar issue in the past: https://bugs.chromium.org/p/chromium/issues/detail?id=771311, will take a look at that CL.
Labels: -M-69 M-68
The feature is to be released in M-68, so changing the milestone.
Labels: -M-68 M-69
Sorry, please ignore my comment above!

Comment 11 by wutao@chromium.org, May 30 2018

Cc: wutao@chromium.org

Comment 12 by warx@chromium.org, May 31 2018

thanks Tao, fixed by suggestion
Project Member

Comment 13 by bugdroid1@chromium.org, Jun 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb3f6d7e7aba14101aa175de2974c5b4f4601707

commit fb3f6d7e7aba14101aa175de2974c5b4f4601707
Author: Qiang Xu <warx@google.com>
Date: Mon Jun 18 22:12:07 2018

cros: manual scale of ImageSkia for different representations

This CL supports manually scale of ImageSkia for different
representations, which could deliver good visual effect for reps other
than 1x and 2x.

Bug:  840641 
Test: manual
Change-Id: I7c131a76297dd565065ff67213b90349ff00206d
Reviewed-on: https://chromium-review.googlesource.com/1081408
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Qiang Xu <warx@google.com>
Cr-Commit-Position: refs/heads/master@{#568192}
[modify] https://crrev.com/fb3f6d7e7aba14101aa175de2974c5b4f4601707/ash/app_list/views/search_result_view.cc
[modify] https://crrev.com/fb3f6d7e7aba14101aa175de2974c5b4f4601707/ui/views/controls/image_view.cc
[modify] https://crrev.com/fb3f6d7e7aba14101aa175de2974c5b4f4601707/ui/views/controls/image_view.h

Comment 14 by warx@chromium.org, Jun 18 2018

Status: Fixed (was: Started)

Sign in to add a comment