Issue 840639  has been merged into this issue.

 Issue 840643  has been merged into this issue.

disabling in https://chromium-review.googlesource.com/c/chromium/src/+/1049274

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88aa3d56786649c28477827a002497b695438302

commit 88aa3d56786649c28477827a002497b695438302
Author: John Budorick <jbudorick@chromium.org>
Date: Tue May 08 04:21:36 2018

Disable several flaky WebVrTransitionTests.

TBR=bsheedy@chromium.org

Bug:  840638 
Change-Id: I3acc6d00d75f6c6dce370961d7459dc3a50faef4
Reviewed-on: https://chromium-review.googlesource.com/1049274
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556686}
[modify] https://crrev.com/88aa3d56786649c28477827a002497b695438302/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTransitionTest.java

Removing the sheriff label as the test is disabled.

Looks like the main error is: Abort message: '[FATAL:gl_surface_presentation_helper.cc(179)] Check failed: !frame.timer.

I doubt any changes the VR team made caused these issues, but it's possible.

 Issue 840920  has been merged into this issue.

Despite comment 4 this is still crashing on trybots (see duplicate bug)

Disabling is unfortunate, it feels like we'll have to disable every single VR test because we use gl surfaces and apparently they're crashing.

Has anybody attempted to figure out where the flakes originated?

+ bshe@, since bsheedy is OOO.

I also disable testControlsVisibleAfterExitingVr_WebXr in  issue 841103 .

 Issue 841103  has been merged into this issue.

 Issue 840725  has been merged into this issue.

kbr, as an owner for gl_surface_presentation_helper.cc, could you please help triage this?

I'm not the right owner for WebVR related bugs. Reassigning to klausw@.

penghuang@, it looks like you added the DCHECK hitting in #9 (https://chromium.googlesource.com/chromium/src/+/7d0895866e899b2ac365ab06d89cb2df991891e2).

Can you take a look at this - many VR tests have been disabled after this change.

I'm not sure at this point whether the DCHECK is correct, and VR has a bug, or whether the DCHECK is incorrect.  Please advise whether we should revert your change and reenable the tests, or whether something is wrong with VR.

Subsequent changes depend on the change in question, and we'll hit new issues if we revert. We should just remove the DCHECK - it was from an earlier version of the CL and doesn't apply to the version submitted.

I can send a CL now.

In flight: https://chromium-review.googlesource.com/c/chromium/src/+/1053092

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/044cca4ad8bc7a80c6edbd4e8dd4d078fd5f7659

commit 044cca4ad8bc7a80c6edbd4e8dd4d078fd5f7659
Author: Eric Karl <ericrk@chromium.org>
Date: Thu May 10 02:07:02 2018

Remove incorrect DCHECK

The DCHECK here was from an earlier version of the CL and doesn't apply
to the final logic. Note that |frame_presentation_callback|, called
right after the DCHECK, assumes that frame.timer exists.

TBR=penghuang@chromium.org,piman@chromium.org

Bug:  840638 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ib8403cb69b2c23dbd851f58c7b207e269dd5b7fe
Reviewed-on: https://chromium-review.googlesource.com/1053092
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557426}
[modify] https://crrev.com/044cca4ad8bc7a80c6edbd4e8dd4d078fd5f7659/ui/gl/gl_surface_presentation_helper.cc

 Issue 840883  has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04b8b7b7fa06afe0bee9dcca77c69368d305db47

commit 04b8b7b7fa06afe0bee9dcca77c69368d305db47
Author: Eric Karl <ericrk@chromium.org>
Date: Thu May 10 22:39:29 2018

Revert "Disable several flaky WebVrTransitionTests."

This reverts commit 88aa3d56786649c28477827a002497b695438302.

Reason for revert: These flakes are addressed with  https://chromium.googlesource.com/chromium/src.git/+/044cca4ad8bc7a80c6edbd4e8dd4d078fd5f7659

Original change's description:
> Disable several flaky WebVrTransitionTests.
> 
> TBR=bsheedy@chromium.org
> 
> Bug:  840638 
> Change-Id: I3acc6d00d75f6c6dce370961d7459dc3a50faef4
> Reviewed-on: https://chromium-review.googlesource.com/1049274
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Commit-Queue: John Budorick <jbudorick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#556686}

TBR=bsheedy@chromium.org,jbudorick@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  840638 
Change-Id: I46f8ffa148d1944ff4f05241fd93e2220fbd93ae
Reviewed-on: https://chromium-review.googlesource.com/1054119
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557705}
[modify] https://crrev.com/04b8b7b7fa06afe0bee9dcca77c69368d305db47/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTransitionTest.java