Focus not set when loading errors in extensions in dev mode on chrome://extensions |
|||
Issue descriptionGoogle Chrome 68.0.3410.2 (Official Build) canary (64-bit) (cohort: Clang-64) Steps to repro: # Go to chrome://extensions # Enable Developer Mode # Load any extension with an error (see bug 814117 for examples) # Invoke the "Error" button to load the error page Expected: focus lands somewhere on the page Actual: focus lands on the entire page/outside of the page I confirmed that this happens with all of the screen readers below as well as using keyboard only. Windows 10 Enterprise Version 1607 Large Monitor set in Windows Display Scaling settings to be 200% magnified JAWS 2018.1804.26 64-bit English NVDA 2018.1.1 ___ Google Chrome OS 68.0.3400.0 (Official Build) canary (64-bit) Firmware Version Google_Lulu.6301.136.57 ___ macOS High Sierra version 10.13.4 with VoiceOver 8 (562.18.4) Google Chrome 68.0.3403.0 (Official Build) canary (64-bit)
,
May 22 2018
,
May 22 2018
,
May 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8fd1d095826d4a4e021879166bea4149b11561d2 commit 8fd1d095826d4a4e021879166bea4149b11561d2 Author: Hector Carmona <hcarmona@chromium.org> Date: Thu May 24 23:35:15 2018 WebUI: Improve A11y by autofocusing the back button. This affects both chrome://settings and chrome://extensions. Bug: 840633 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5e69e542a9c08fd35c2f6b02a8277d7ee87998fe Reviewed-on: https://chromium-review.googlesource.com/1068114 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#561691} [modify] https://crrev.com/8fd1d095826d4a4e021879166bea4149b11561d2/chrome/browser/resources/md_extensions/BUILD.gn [modify] https://crrev.com/8fd1d095826d4a4e021879166bea4149b11561d2/chrome/browser/resources/md_extensions/detail_view.html [modify] https://crrev.com/8fd1d095826d4a4e021879166bea4149b11561d2/chrome/browser/resources/md_extensions/detail_view.js [modify] https://crrev.com/8fd1d095826d4a4e021879166bea4149b11561d2/chrome/browser/resources/md_extensions/error_page.html [modify] https://crrev.com/8fd1d095826d4a4e021879166bea4149b11561d2/chrome/browser/resources/md_extensions/error_page.js [modify] https://crrev.com/8fd1d095826d4a4e021879166bea4149b11561d2/chrome/browser/resources/settings/settings_page/BUILD.gn [modify] https://crrev.com/8fd1d095826d4a4e021879166bea4149b11561d2/chrome/browser/resources/settings/settings_page/settings_animated_pages.js [modify] https://crrev.com/8fd1d095826d4a4e021879166bea4149b11561d2/chrome/browser/resources/settings/settings_page/settings_subpage.html [modify] https://crrev.com/8fd1d095826d4a4e021879166bea4149b11561d2/chrome/browser/resources/settings/settings_page/settings_subpage.js [modify] https://crrev.com/8fd1d095826d4a4e021879166bea4149b11561d2/chrome/test/data/webui/extensions/extension_detail_view_test.js [modify] https://crrev.com/8fd1d095826d4a4e021879166bea4149b11561d2/chrome/test/data/webui/extensions/extension_error_page_test.js [modify] https://crrev.com/8fd1d095826d4a4e021879166bea4149b11561d2/ui/webui/resources/js/cr/ui/focus_without_ink.js
,
May 25 2018
FYI the CL above seems to have caused issue 846596 . We need to determine if this commit made it to the M68 branch and fix accordincly.
,
May 25 2018
Branch was at 561733 CL landed at 561691 CL is in branch, so closing this issue and will address regression separately. |
|||
►
Sign in to add a comment |
|||
Comment 1 by karandeepb@chromium.org
, May 11 2018