New issue
Advanced search Search tips

Issue 840609 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

In TalkBack, the Accesibility focus is displayed at a position different from the tapped position.

Reported by m.ueno.0...@gmail.com, May 8 2018

Issue description

Example URL:
http://kakaku.com

Steps to reproduce the problem:
1.Enable TalkBack.
  (Settings->Accessibility->TalkBack)
2.Visit kakaku.com with Chrome browser.
  (http://kakaku.com)
  *This site is for PC layout, because i use Nexus9.
   If using Chrome browser on smartphone, please check submenu->"Desctop site".
3.Tap any link.

What is the expected behavior?
The Accessibility focus is displayed on the tapped link

What went wrong?
The Accesibility focus is displayed at a position different from the tapped position.
In attached file(screencap1.png), "tap location" is tapped link.
(Enable "Pointer location" and "Show taps" using Developer options.)

Does it occur on multiple sites: Yes

Is it a problem with a plugin? No 

Did this work before? Yes Chrome 53.0.2785.135

Does this work in other browsers? No
 Lightning Web Browser

Chrome version: 65.0.3325.109  Channel: stable
OS Version: 7.1.1
Flash Version: 

1.screencap2.png shows same problem, after pinch-out.
2.Same problem occurred following other sites, https://www.yahoo.co.jp , https://mainichi.jp , http://www.sankei.com , https://www.nikkei.com .
3.This problem not occurred using Chrome 53.0.2785.135.
 
screencap2.png
774 KB View Download
screencap1.png
1.3 MB View Download
Labels: Needs-triage-Mobile

Comment 3 by junov@chromium.org, May 8 2018

Components: -Blink Blink>Accessibility
Cc: pnangunoori@chromium.org
Labels: hasbisect-per-revision FoundIn-66 Target-67 M-68 Triaged-Mobile M-66 M-67 FoundIn-67 Target-66 FoundIn-68 Target-68
Owner: jinsuk...@chromium.org
Status: Assigned (was: Unconfirmed)
Tested the issue in Android and able to reproduce the issue. 

Prerequisite - Enable TalkBack from device settings.

Steps Followed:
1. Launch Chrome.
2. Navigate to any URL - kakaku.com
3. Switch to desktop site.
4. Tap on any of the link.
5. Observed that selection/focus is made at the different part of the page rather than the tapped location.

Chrome versions tested:
66.0.3359.126(Stable), 68.0.3420.1(Canary)

OS:
Android 8.1.0

Android Devices:
Pixel 2

Using the per-revision bisect providing the bisect results,
Good Build - 61.0.3132.0 (479900)
Bad Build - 61.0.3133.0 (480259) 

You are looking for a change made after 479965(GOOD), but before 479966(BAD).

CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+/37ae4cefaf29db963187790e199ddd7b663f0001

@jinsukkim:  Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to owner concerned.

Please navigate to below link for log's and video--
go/chrome-androidlogs/840609


Thanks!
Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, May 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83d6178753e0804b93619fa68202f6d963a552b2

commit 83d6178753e0804b93619fa68202f6d963a552b2
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Sun May 13 23:22:46 2018

Android: Fix wrong tap postion in a11y mode

https://crrev.com/c/517683 introduced a bug in accessibility mode
when page scale factor is not 1. Before the patch, the hover event
coordinate is converted to CSS (https://goo.gl/ER8wu5) but after
the patch the unit was DIP by mistake. (https://goo.gl/ER8wu5).
This CL fixes it by applying the page scale factor to set the unit
right to CSS.

Bug:  840609 
Change-Id: Iaa17882e2ffb2d5637e59df1ebe7cf677f4a76a3
Reviewed-on: https://chromium-review.googlesource.com/1055067
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558165}
[modify] https://crrev.com/83d6178753e0804b93619fa68202f6d963a552b2/content/browser/accessibility/web_contents_accessibility_android.cc
[modify] https://crrev.com/83d6178753e0804b93619fa68202f6d963a552b2/content/browser/accessibility/web_contents_accessibility_android.h
[modify] https://crrev.com/83d6178753e0804b93619fa68202f6d963a552b2/content/browser/renderer_host/render_widget_host_view_android.cc

Above patch landed in 68.0.3430.0. Praphulla, please verify. 
Also are we planning for any merges here for M67?
Tested on Chrome Canary #68.0.3430.2 using Pixel Android 8.1.0 Build/OPM1.171019.028 and was not able to reproduce the issue.

Attached the screen cast for reference.

Thanks!
840609.mp4
3.8 MB View Download

Comment 9 by ram...@chromium.org, May 15 2018

Also verified on HTC Desire 626S w/Chrome Dev 68.0.3430.2
Labels: Merge-Request-67
Status: Fixed (was: Started)
I'm afraid it is a bit too late for getting this change in M67 but let me try.
Project Member

Comment 11 by sheriffbot@chromium.org, May 15 2018

Labels: -Merge-Request-67 Merge-Review-67 Hotlist-Merge-Review
This bug requires manual review: We are only 13 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 12 by cmasso@google.com, May 16 2018

If this issue is not new in M67, then let's not take the risk to merge the fix this late in the cycle.
Please can you confirm here that this issue is not new in M67
Device: Pixel 2
Android version:8.1.0
Chrome version: 67.0.3396.57
pre-Condition: Talkback is active.

1. start Chrome and visit 'kakaku.com.
2. selected Desktop site on
2. Tap on different links with Japanese translation.

Results: Depending on the link being tapped, some selections/focus will properly utter, but some will speak the link selection above it.
Bug is also repro on 66.0.3359.158

Comment 16 by cmasso@google.com, May 25 2018

Labels: -Hotlist-Merge-Review -Merge-Review-67 Merge-Rejected-67
Maybe not worth merging it into M67 this late in the cycle. The fix will go out with M68 But let me know if you feel strongly about merging this into M67.

Sign in to add a comment