New issue
Advanced search Search tips

Issue 840591 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 832173



Sign in to add a comment

CrOS Network Settings: Several unstyled buttons exist.

Project Member Reported by dpa...@chromium.org, May 7 2018

Issue description


See attachments:
  - unstyled_dialog.png: See "Change" button.
  - unstyled_buttons.png: See "Change pin", "Scan" and "Save" buttons.
 
unstyled_dialog.png
10.2 KB View Download
unstyled_buttons.png
33.4 KB View Download
Blocking: 832173
Status: Started (was: Assigned)
Candidate fix at https://chromium-review.googlesource.com/c/chromium/src/+/1048884.
Components: UI>Settings
Labels: -OS-Linux -OS-Windows -OS-Mac
Project Member

Comment 4 by bugdroid1@chromium.org, May 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66278e5e8819aa7d4c0e69138010cfd0e63fbb93

commit 66278e5e8819aa7d4c0e69138010cfd0e63fbb93
Author: dpapad <dpapad@chromium.org>
Date: Wed May 09 01:43:56 2018

CrOS Network Settings: Apply shared styling to a few unstyled buttons.

Bug:  840591 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6fdde8fc17af9592cb2bb6d52a6ef476c50309ab
Reviewed-on: https://chromium-review.googlesource.com/1048884
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557055}
[modify] https://crrev.com/66278e5e8819aa7d4c0e69138010cfd0e63fbb93/ui/webui/resources/cr_components/chromeos/network/network_apnlist.html
[modify] https://crrev.com/66278e5e8819aa7d4c0e69138010cfd0e63fbb93/ui/webui/resources/cr_components/chromeos/network/network_choose_mobile.html
[modify] https://crrev.com/66278e5e8819aa7d4c0e69138010cfd0e63fbb93/ui/webui/resources/cr_components/chromeos/network/network_siminfo.html

Comment 5 by dpa...@chromium.org, May 11 2018

Status: Fixed (was: Started)

Comment 6 by dpa...@chromium.org, May 22 2018

Labels: Proj-MaterialDesign-Refresh-WebUI

Sign in to add a comment