New issue
Advanced search Search tips

Issue 840559 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jul 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task

Blocking:
issue 757605



Sign in to add a comment

Shader disk caching for OOP-R

Project Member Reported by khushals...@chromium.org, May 7 2018

Issue description

The Command buffer has a shader disk cache which won't be used by skia during OOP-R. This needs to be hooked up for OOP-R too.
 

Comment 1 by enne@chromium.org, May 8 2018

Blocking: 757605
Cc: rjkroege@chromium.org
Spoke to ericrk@ again about this today. On Android we currently don't do any caching of shaders on disk at all. This is due to numerous reasons, one being that the framework already has a disk cache, but at least we don't need to block enabling oop-r on Android on this.

Another thing that we do need to look at for Android also is shader translation via ANGLE which is used on Android too.

Comment 4 by enne@chromium.org, May 21 2018

Shader translation is handled via  issue 829614 .  Other than workarounds, the shader translation doesn't add anything extra.
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49b85d7453d643d2d9f7dd127d72c3bdd88ca9c7

commit 49b85d7453d643d2d9f7dd127d72c3bdd88ca9c7
Author: Khushal <khushalsagar@chromium.org>
Date: Wed Jul 18 09:28:00 2018

gpu: Add disk caching for skia generated shaders in OOP-R.

Use the GrContextOptions::PersistentCache API provided by skia to
persist shaders generated internally by skia for OOP raster to disk.
This requires using a special client id to namespace these shaders,
similar to the one used by the InProcessCommandBuffer for viz.

While the shaders for different sources are stored seperately on disk,
they are finally merged into a single memory cache in the GPU process. In
order to maintain a seperate cache for skia generated shaders, this also
plumbs the client id for a loaded shader to the GPU process.

R=piman@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I91fd89ed2c3d2a0bcbcb9b1fdc4ddfbc5b8de147
Bug:  854416 , 840559 
Reviewed-on: https://chromium-review.googlesource.com/1116197
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575987}
[modify] https://crrev.com/49b85d7453d643d2d9f7dd127d72c3bdd88ca9c7/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/49b85d7453d643d2d9f7dd127d72c3bdd88ca9c7/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/49b85d7453d643d2d9f7dd127d72c3bdd88ca9c7/components/viz/host/server_gpu_memory_buffer_manager_unittest.cc
[modify] https://crrev.com/49b85d7453d643d2d9f7dd127d72c3bdd88ca9c7/components/viz/service/display_embedder/in_process_gpu_memory_buffer_manager.cc
[modify] https://crrev.com/49b85d7453d643d2d9f7dd127d72c3bdd88ca9c7/components/viz/service/gl/gpu_service_impl.cc
[modify] https://crrev.com/49b85d7453d643d2d9f7dd127d72c3bdd88ca9c7/components/viz/service/gl/gpu_service_impl.h
[modify] https://crrev.com/49b85d7453d643d2d9f7dd127d72c3bdd88ca9c7/content/browser/gpu/browser_gpu_channel_host_factory.cc
[modify] https://crrev.com/49b85d7453d643d2d9f7dd127d72c3bdd88ca9c7/content/browser/gpu/browser_gpu_channel_host_factory.h
[modify] https://crrev.com/49b85d7453d643d2d9f7dd127d72c3bdd88ca9c7/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/49b85d7453d643d2d9f7dd127d72c3bdd88ca9c7/content/browser/gpu/gpu_process_host.h
[modify] https://crrev.com/49b85d7453d643d2d9f7dd127d72c3bdd88ca9c7/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/49b85d7453d643d2d9f7dd127d72c3bdd88ca9c7/content/public/browser/content_browser_client.h
[modify] https://crrev.com/49b85d7453d643d2d9f7dd127d72c3bdd88ca9c7/gpu/BUILD.gn
[modify] https://crrev.com/49b85d7453d643d2d9f7dd127d72c3bdd88ca9c7/gpu/command_buffer/service/BUILD.gn
[modify] https://crrev.com/49b85d7453d643d2d9f7dd127d72c3bdd88ca9c7/gpu/command_buffer/service/gr_cache_controller_unittest.cc
[add] https://crrev.com/49b85d7453d643d2d9f7dd127d72c3bdd88ca9c7/gpu/command_buffer/service/gr_shader_cache.cc
[add] https://crrev.com/49b85d7453d643d2d9f7dd127d72c3bdd88ca9c7/gpu/command_buffer/service/gr_shader_cache.h
[add] https://crrev.com/49b85d7453d643d2d9f7dd127d72c3bdd88ca9c7/gpu/command_buffer/service/gr_shader_cache_unittest.cc
[modify] https://crrev.com/49b85d7453d643d2d9f7dd127d72c3bdd88ca9c7/gpu/command_buffer/service/raster_decoder_context_state.cc
[modify] https://crrev.com/49b85d7453d643d2d9f7dd127d72c3bdd88ca9c7/gpu/command_buffer/service/raster_decoder_context_state.h
[modify] https://crrev.com/49b85d7453d643d2d9f7dd127d72c3bdd88ca9c7/gpu/command_buffer/service/raster_decoder_unittest.cc
[modify] https://crrev.com/49b85d7453d643d2d9f7dd127d72c3bdd88ca9c7/gpu/command_buffer/tests/fuzzer_main.cc
[modify] https://crrev.com/49b85d7453d643d2d9f7dd127d72c3bdd88ca9c7/gpu/command_buffer/tests/gl_manager.cc
[modify] https://crrev.com/49b85d7453d643d2d9f7dd127d72c3bdd88ca9c7/gpu/ipc/BUILD.gn
[modify] https://crrev.com/49b85d7453d643d2d9f7dd127d72c3bdd88ca9c7/gpu/ipc/common/BUILD.gn
[add] https://crrev.com/49b85d7453d643d2d9f7dd127d72c3bdd88ca9c7/gpu/ipc/common/gpu_client_ids.h
[modify] https://crrev.com/49b85d7453d643d2d9f7dd127d72c3bdd88ca9c7/gpu/ipc/in_process_command_buffer.cc
[modify] https://crrev.com/49b85d7453d643d2d9f7dd127d72c3bdd88ca9c7/gpu/ipc/in_process_command_buffer.h
[modify] https://crrev.com/49b85d7453d643d2d9f7dd127d72c3bdd88ca9c7/gpu/ipc/service/command_buffer_stub.cc
[modify] https://crrev.com/49b85d7453d643d2d9f7dd127d72c3bdd88ca9c7/gpu/ipc/service/gpu_channel_manager.cc
[modify] https://crrev.com/49b85d7453d643d2d9f7dd127d72c3bdd88ca9c7/gpu/ipc/service/gpu_channel_manager.h
[modify] https://crrev.com/49b85d7453d643d2d9f7dd127d72c3bdd88ca9c7/gpu/ipc/service/gpu_channel_manager_unittest.cc
[modify] https://crrev.com/49b85d7453d643d2d9f7dd127d72c3bdd88ca9c7/gpu/ipc/service/gpu_channel_test_common.cc
[modify] https://crrev.com/49b85d7453d643d2d9f7dd127d72c3bdd88ca9c7/services/ui/gpu_host/gpu_client.cc
[modify] https://crrev.com/49b85d7453d643d2d9f7dd127d72c3bdd88ca9c7/services/viz/privileged/interfaces/gl/gpu_service.mojom

Status: Fixed (was: Available)
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9395d77ab8feb15a222dc8e2b3608ac6db22302

commit f9395d77ab8feb15a222dc8e2b3608ac6db22302
Author: Khushal <khushalsagar@chromium.org>
Date: Wed Jul 18 21:56:35 2018

Revert "gpu: Add disk caching for skia generated shaders in OOP-R."

This reverts commit 49b85d7453d643d2d9f7dd127d72c3bdd88ca9c7.

Reason for revert: Speculative revert for failures in crbug.com/865138

Original change's description:
> gpu: Add disk caching for skia generated shaders in OOP-R.
> 
> Use the GrContextOptions::PersistentCache API provided by skia to
> persist shaders generated internally by skia for OOP raster to disk.
> This requires using a special client id to namespace these shaders,
> similar to the one used by the InProcessCommandBuffer for viz.
> 
> While the shaders for different sources are stored seperately on disk,
> they are finally merged into a single memory cache in the GPU process. In
> order to maintain a seperate cache for skia generated shaders, this also
> plumbs the client id for a loaded shader to the GPU process.
> 
> R=​piman@chromium.org
> 
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: I91fd89ed2c3d2a0bcbcb9b1fdc4ddfbc5b8de147
> Bug:  854416 , 840559 
> Reviewed-on: https://chromium-review.googlesource.com/1116197
> Commit-Queue: Khushal <khushalsagar@chromium.org>
> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#575987}

TBR=sadrul@chromium.org,tsepez@chromium.org,khushalsagar@chromium.org,piman@chromium.org,ericrk@chromium.org

Change-Id: I0cde27e30d1ab0c8803539148efc42a24a3e2230
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  854416 ,  840559 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1142306
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576228}
[modify] https://crrev.com/f9395d77ab8feb15a222dc8e2b3608ac6db22302/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/f9395d77ab8feb15a222dc8e2b3608ac6db22302/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/f9395d77ab8feb15a222dc8e2b3608ac6db22302/components/viz/host/host_gpu_memory_buffer_manager_unittest.cc
[modify] https://crrev.com/f9395d77ab8feb15a222dc8e2b3608ac6db22302/components/viz/service/display_embedder/in_process_gpu_memory_buffer_manager.cc
[modify] https://crrev.com/f9395d77ab8feb15a222dc8e2b3608ac6db22302/components/viz/service/gl/gpu_service_impl.cc
[modify] https://crrev.com/f9395d77ab8feb15a222dc8e2b3608ac6db22302/components/viz/service/gl/gpu_service_impl.h
[modify] https://crrev.com/f9395d77ab8feb15a222dc8e2b3608ac6db22302/content/browser/gpu/browser_gpu_channel_host_factory.cc
[modify] https://crrev.com/f9395d77ab8feb15a222dc8e2b3608ac6db22302/content/browser/gpu/browser_gpu_channel_host_factory.h
[modify] https://crrev.com/f9395d77ab8feb15a222dc8e2b3608ac6db22302/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/f9395d77ab8feb15a222dc8e2b3608ac6db22302/content/browser/gpu/gpu_process_host.h
[modify] https://crrev.com/f9395d77ab8feb15a222dc8e2b3608ac6db22302/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/f9395d77ab8feb15a222dc8e2b3608ac6db22302/content/public/browser/content_browser_client.h
[modify] https://crrev.com/f9395d77ab8feb15a222dc8e2b3608ac6db22302/gpu/BUILD.gn
[modify] https://crrev.com/f9395d77ab8feb15a222dc8e2b3608ac6db22302/gpu/command_buffer/service/BUILD.gn
[modify] https://crrev.com/f9395d77ab8feb15a222dc8e2b3608ac6db22302/gpu/command_buffer/service/gr_cache_controller_unittest.cc
[delete] https://crrev.com/1ca17c55c4e23840893be64e18b80518ea26da85/gpu/command_buffer/service/gr_shader_cache.cc
[delete] https://crrev.com/1ca17c55c4e23840893be64e18b80518ea26da85/gpu/command_buffer/service/gr_shader_cache.h
[delete] https://crrev.com/1ca17c55c4e23840893be64e18b80518ea26da85/gpu/command_buffer/service/gr_shader_cache_unittest.cc
[modify] https://crrev.com/f9395d77ab8feb15a222dc8e2b3608ac6db22302/gpu/command_buffer/service/raster_decoder_context_state.cc
[modify] https://crrev.com/f9395d77ab8feb15a222dc8e2b3608ac6db22302/gpu/command_buffer/service/raster_decoder_context_state.h
[modify] https://crrev.com/f9395d77ab8feb15a222dc8e2b3608ac6db22302/gpu/command_buffer/service/raster_decoder_unittest.cc
[modify] https://crrev.com/f9395d77ab8feb15a222dc8e2b3608ac6db22302/gpu/command_buffer/tests/fuzzer_main.cc
[modify] https://crrev.com/f9395d77ab8feb15a222dc8e2b3608ac6db22302/gpu/command_buffer/tests/gl_manager.cc
[modify] https://crrev.com/f9395d77ab8feb15a222dc8e2b3608ac6db22302/gpu/ipc/BUILD.gn
[modify] https://crrev.com/f9395d77ab8feb15a222dc8e2b3608ac6db22302/gpu/ipc/common/BUILD.gn
[delete] https://crrev.com/1ca17c55c4e23840893be64e18b80518ea26da85/gpu/ipc/common/gpu_client_ids.h
[modify] https://crrev.com/f9395d77ab8feb15a222dc8e2b3608ac6db22302/gpu/ipc/in_process_command_buffer.cc
[modify] https://crrev.com/f9395d77ab8feb15a222dc8e2b3608ac6db22302/gpu/ipc/in_process_command_buffer.h
[modify] https://crrev.com/f9395d77ab8feb15a222dc8e2b3608ac6db22302/gpu/ipc/service/command_buffer_stub.cc
[modify] https://crrev.com/f9395d77ab8feb15a222dc8e2b3608ac6db22302/gpu/ipc/service/gpu_channel_manager.cc
[modify] https://crrev.com/f9395d77ab8feb15a222dc8e2b3608ac6db22302/gpu/ipc/service/gpu_channel_manager.h
[modify] https://crrev.com/f9395d77ab8feb15a222dc8e2b3608ac6db22302/gpu/ipc/service/gpu_channel_manager_unittest.cc
[modify] https://crrev.com/f9395d77ab8feb15a222dc8e2b3608ac6db22302/gpu/ipc/service/gpu_channel_test_common.cc
[modify] https://crrev.com/f9395d77ab8feb15a222dc8e2b3608ac6db22302/services/ui/gpu_host/gpu_client.cc
[modify] https://crrev.com/f9395d77ab8feb15a222dc8e2b3608ac6db22302/services/viz/privileged/interfaces/gl/gpu_service.mojom

Project Member

Comment 8 by bugdroid1@chromium.org, Jul 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2667e316f9bec1194d8d468862e772add87aeaa

commit c2667e316f9bec1194d8d468862e772add87aeaa
Author: Khushal <khushalsagar@chromium.org>
Date: Fri Jul 20 01:07:18 2018

Reland gpu: Add disk caching for skia generated shaders in OOP-R.

This reverts commit f9395d77ab8feb15a222dc8e2b3608ac6db22302.

Use the GrContextOptions::PersistentCache API provided by skia to
persist shaders generated internally by skia for OOP raster to disk.
This requires using a special client id to namespace these shaders,
similar to the one used by the InProcessCommandBuffer for viz.

While the shaders for different sources are stored seperately on disk,
they are finally merged into a single memory cache in the GPU process. In
order to maintain a seperate cache for skia generated shaders, this also
plumbs the client id for a loaded shader to the GPU process.

TBR=tsepez@chromium.org

Bug:  854416 , 840559 , 865138
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I65544ccaff96c3154a822dbc2500468fbcac8a0b
Reviewed-on: https://chromium-review.googlesource.com/1142829
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576742}
[modify] https://crrev.com/c2667e316f9bec1194d8d468862e772add87aeaa/components/viz/host/host_gpu_memory_buffer_manager_unittest.cc
[modify] https://crrev.com/c2667e316f9bec1194d8d468862e772add87aeaa/components/viz/service/display_embedder/in_process_gpu_memory_buffer_manager.cc
[modify] https://crrev.com/c2667e316f9bec1194d8d468862e772add87aeaa/components/viz/service/gl/gpu_service_impl.cc
[modify] https://crrev.com/c2667e316f9bec1194d8d468862e772add87aeaa/components/viz/service/gl/gpu_service_impl.h
[modify] https://crrev.com/c2667e316f9bec1194d8d468862e772add87aeaa/content/browser/gpu/browser_gpu_channel_host_factory.cc
[modify] https://crrev.com/c2667e316f9bec1194d8d468862e772add87aeaa/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/c2667e316f9bec1194d8d468862e772add87aeaa/content/browser/gpu/gpu_process_host.h
[modify] https://crrev.com/c2667e316f9bec1194d8d468862e772add87aeaa/gpu/BUILD.gn
[modify] https://crrev.com/c2667e316f9bec1194d8d468862e772add87aeaa/gpu/command_buffer/service/BUILD.gn
[modify] https://crrev.com/c2667e316f9bec1194d8d468862e772add87aeaa/gpu/command_buffer/service/gr_cache_controller_unittest.cc
[add] https://crrev.com/c2667e316f9bec1194d8d468862e772add87aeaa/gpu/command_buffer/service/gr_shader_cache.cc
[add] https://crrev.com/c2667e316f9bec1194d8d468862e772add87aeaa/gpu/command_buffer/service/gr_shader_cache.h
[add] https://crrev.com/c2667e316f9bec1194d8d468862e772add87aeaa/gpu/command_buffer/service/gr_shader_cache_unittest.cc
[modify] https://crrev.com/c2667e316f9bec1194d8d468862e772add87aeaa/gpu/command_buffer/service/raster_decoder_context_state.cc
[modify] https://crrev.com/c2667e316f9bec1194d8d468862e772add87aeaa/gpu/command_buffer/service/raster_decoder_context_state.h
[modify] https://crrev.com/c2667e316f9bec1194d8d468862e772add87aeaa/gpu/command_buffer/service/raster_decoder_unittest.cc
[modify] https://crrev.com/c2667e316f9bec1194d8d468862e772add87aeaa/gpu/command_buffer/tests/fuzzer_main.cc
[modify] https://crrev.com/c2667e316f9bec1194d8d468862e772add87aeaa/gpu/command_buffer/tests/gl_manager.cc
[modify] https://crrev.com/c2667e316f9bec1194d8d468862e772add87aeaa/gpu/ipc/BUILD.gn
[modify] https://crrev.com/c2667e316f9bec1194d8d468862e772add87aeaa/gpu/ipc/common/BUILD.gn
[add] https://crrev.com/c2667e316f9bec1194d8d468862e772add87aeaa/gpu/ipc/common/gpu_client_ids.h
[modify] https://crrev.com/c2667e316f9bec1194d8d468862e772add87aeaa/gpu/ipc/in_process_command_buffer.cc
[modify] https://crrev.com/c2667e316f9bec1194d8d468862e772add87aeaa/gpu/ipc/in_process_command_buffer.h
[modify] https://crrev.com/c2667e316f9bec1194d8d468862e772add87aeaa/gpu/ipc/service/command_buffer_stub.cc
[modify] https://crrev.com/c2667e316f9bec1194d8d468862e772add87aeaa/gpu/ipc/service/gpu_channel_manager.cc
[modify] https://crrev.com/c2667e316f9bec1194d8d468862e772add87aeaa/gpu/ipc/service/gpu_channel_manager.h
[modify] https://crrev.com/c2667e316f9bec1194d8d468862e772add87aeaa/gpu/ipc/service/gpu_channel_manager_unittest.cc
[modify] https://crrev.com/c2667e316f9bec1194d8d468862e772add87aeaa/gpu/ipc/service/gpu_channel_test_common.cc
[modify] https://crrev.com/c2667e316f9bec1194d8d468862e772add87aeaa/services/ui/gpu_host/gpu_client.cc
[modify] https://crrev.com/c2667e316f9bec1194d8d468862e772add87aeaa/services/viz/privileged/interfaces/gl/gpu_service.mojom

Project Member

Comment 9 by bugdroid1@chromium.org, Jul 25

Labels: merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/971df0f22220cfa2bf0d3e3ad0a70417f85e1cc3

commit 971df0f22220cfa2bf0d3e3ad0a70417f85e1cc3
Author: Khushal <khushalsagar@chromium.org>
Date: Wed Jul 25 01:42:04 2018

Revert "Reland gpu: Add disk caching for skia generated shaders in OOP-R."

This reverts commit c2667e316f9bec1194d8d468862e772add87aeaa.

Reason for revert: Only the first part made it to M69, without the subsequent patches this is just unnecessary overhead.

Original change's description:
> Reland gpu: Add disk caching for skia generated shaders in OOP-R.
>
> This reverts commit f9395d77ab8feb15a222dc8e2b3608ac6db22302.
>
> Use the GrContextOptions::PersistentCache API provided by skia to
> persist shaders generated internally by skia for OOP raster to disk.
> This requires using a special client id to namespace these shaders,
> similar to the one used by the InProcessCommandBuffer for viz.
>
> While the shaders for different sources are stored seperately on disk,
> they are finally merged into a single memory cache in the GPU process. In
> order to maintain a seperate cache for skia generated shaders, this also
> plumbs the client id for a loaded shader to the GPU process.
>
> TBR=tsepez@chromium.org
>
> Bug:  854416 , 840559 , 865138
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: I65544ccaff96c3154a822dbc2500468fbcac8a0b
> Reviewed-on: https://chromium-review.googlesource.com/1142829
> Commit-Queue: Khushal <khushalsagar@chromium.org>
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#576742}

TBR=tsepez@chromium.org,khushalsagar@chromium.org,piman@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 865138
Change-Id: Ia38b186475f802efb81d0764bf0a24350103f868
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1147041
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#61}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/971df0f22220cfa2bf0d3e3ad0a70417f85e1cc3/components/viz/host/host_gpu_memory_buffer_manager_unittest.cc
[modify] https://crrev.com/971df0f22220cfa2bf0d3e3ad0a70417f85e1cc3/components/viz/service/display_embedder/in_process_gpu_memory_buffer_manager.cc
[modify] https://crrev.com/971df0f22220cfa2bf0d3e3ad0a70417f85e1cc3/components/viz/service/gl/gpu_service_impl.cc
[modify] https://crrev.com/971df0f22220cfa2bf0d3e3ad0a70417f85e1cc3/components/viz/service/gl/gpu_service_impl.h
[modify] https://crrev.com/971df0f22220cfa2bf0d3e3ad0a70417f85e1cc3/content/browser/gpu/browser_gpu_channel_host_factory.cc
[modify] https://crrev.com/971df0f22220cfa2bf0d3e3ad0a70417f85e1cc3/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/971df0f22220cfa2bf0d3e3ad0a70417f85e1cc3/content/browser/gpu/gpu_process_host.h
[modify] https://crrev.com/971df0f22220cfa2bf0d3e3ad0a70417f85e1cc3/gpu/BUILD.gn
[modify] https://crrev.com/971df0f22220cfa2bf0d3e3ad0a70417f85e1cc3/gpu/command_buffer/service/BUILD.gn
[modify] https://crrev.com/971df0f22220cfa2bf0d3e3ad0a70417f85e1cc3/gpu/command_buffer/service/gr_cache_controller_unittest.cc
[delete] https://crrev.com/dba741d1e5f814e8cf0571b0a75826dc220a7b41/gpu/command_buffer/service/gr_shader_cache.cc
[delete] https://crrev.com/dba741d1e5f814e8cf0571b0a75826dc220a7b41/gpu/command_buffer/service/gr_shader_cache.h
[delete] https://crrev.com/dba741d1e5f814e8cf0571b0a75826dc220a7b41/gpu/command_buffer/service/gr_shader_cache_unittest.cc
[modify] https://crrev.com/971df0f22220cfa2bf0d3e3ad0a70417f85e1cc3/gpu/command_buffer/service/raster_decoder_context_state.cc
[modify] https://crrev.com/971df0f22220cfa2bf0d3e3ad0a70417f85e1cc3/gpu/command_buffer/service/raster_decoder_context_state.h
[modify] https://crrev.com/971df0f22220cfa2bf0d3e3ad0a70417f85e1cc3/gpu/command_buffer/service/raster_decoder_unittest.cc
[modify] https://crrev.com/971df0f22220cfa2bf0d3e3ad0a70417f85e1cc3/gpu/command_buffer/tests/fuzzer_main.cc
[modify] https://crrev.com/971df0f22220cfa2bf0d3e3ad0a70417f85e1cc3/gpu/command_buffer/tests/gl_manager.cc
[modify] https://crrev.com/971df0f22220cfa2bf0d3e3ad0a70417f85e1cc3/gpu/ipc/BUILD.gn
[modify] https://crrev.com/971df0f22220cfa2bf0d3e3ad0a70417f85e1cc3/gpu/ipc/common/BUILD.gn
[delete] https://crrev.com/dba741d1e5f814e8cf0571b0a75826dc220a7b41/gpu/ipc/common/gpu_client_ids.h
[modify] https://crrev.com/971df0f22220cfa2bf0d3e3ad0a70417f85e1cc3/gpu/ipc/in_process_command_buffer.cc
[modify] https://crrev.com/971df0f22220cfa2bf0d3e3ad0a70417f85e1cc3/gpu/ipc/in_process_command_buffer.h
[modify] https://crrev.com/971df0f22220cfa2bf0d3e3ad0a70417f85e1cc3/gpu/ipc/service/command_buffer_stub.cc
[modify] https://crrev.com/971df0f22220cfa2bf0d3e3ad0a70417f85e1cc3/gpu/ipc/service/gpu_channel_manager.cc
[modify] https://crrev.com/971df0f22220cfa2bf0d3e3ad0a70417f85e1cc3/gpu/ipc/service/gpu_channel_manager.h
[modify] https://crrev.com/971df0f22220cfa2bf0d3e3ad0a70417f85e1cc3/gpu/ipc/service/gpu_channel_manager_unittest.cc
[modify] https://crrev.com/971df0f22220cfa2bf0d3e3ad0a70417f85e1cc3/gpu/ipc/service/gpu_channel_test_common.cc
[modify] https://crrev.com/971df0f22220cfa2bf0d3e3ad0a70417f85e1cc3/services/ui/gpu_host/gpu_client.cc
[modify] https://crrev.com/971df0f22220cfa2bf0d3e3ad0a70417f85e1cc3/services/viz/privileged/interfaces/gl/gpu_service.mojom

Sign in to add a comment