ManifestManager runs on all Frames accidentally? |
||
Issue descriptionReading through RenderFrameImpl's initialization, I noticed this code: https://chromium-review.googlesource.com/c/chromium/src/+/774040/6/content/renderer/render_frame_impl.cc#1360 which looks like it always executes even child frames. The reason is IsMainFrame() doesn't return a value signal until it is set in RenderFrameImpl::Initialize(). Thus the conditional in the constructor always returns true. What is ManifestManager and would it be bad to just move it into the ::Initialize() method?
,
May 21 2018
,
May 22 2018
This is the implementation of the web app manifest (https://www.w3.org/TR/appmanifest/) in Chrome. The ManifestChangeNotifier will run a callback if the site changes its <link rel="manifest"> tag to point to a new file. It's probably fine to move the construction of the ManifestChangeNotifier from the RenderFrameImpl constructor to Initialize(). |
||
►
Sign in to add a comment |
||
Comment 1 by ajwong@chromium.org
, May 7 2018