New issue
Advanced search Search tips

Issue 840511 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task
Proj-XR
Proj-XR-VR

Blocking:
issue 838936



Sign in to add a comment

Tabs: Add ability to switch tabs

Project Member Reported by tiborg@chromium.org, May 7 2018

Issue description

Make tab UI clickable and switch to tab if clicked on.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e90eb5ab5b5e3d0c9fc9ab2f653b6045751b8374

commit e90eb5ab5b5e3d0c9fc9ab2f653b6045751b8374
Author: Tibor Goldschwendt <tiborg@chromium.org>
Date: Wed May 09 01:08:45 2018

[vr] Make tabs overview in VR interactive

When clicking on a tab in the VR tabs overview (tabs switcher) select that tab
and go to the main browser environment after the tab has been selected.

Bug:  840511 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: If373166215b2a1dae10bd714dec084fc90087e9d
Reviewed-on: https://chromium-review.googlesource.com/1048269
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557042}
[modify] https://crrev.com/e90eb5ab5b5e3d0c9fc9ab2f653b6045751b8374/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
[modify] https://crrev.com/e90eb5ab5b5e3d0c9fc9ab2f653b6045751b8374/chrome/browser/android/vr/vr_gl_thread.cc
[modify] https://crrev.com/e90eb5ab5b5e3d0c9fc9ab2f653b6045751b8374/chrome/browser/android/vr/vr_gl_thread.h
[modify] https://crrev.com/e90eb5ab5b5e3d0c9fc9ab2f653b6045751b8374/chrome/browser/android/vr/vr_shell.cc
[modify] https://crrev.com/e90eb5ab5b5e3d0c9fc9ab2f653b6045751b8374/chrome/browser/android/vr/vr_shell.h
[modify] https://crrev.com/e90eb5ab5b5e3d0c9fc9ab2f653b6045751b8374/chrome/browser/vr/browser_ui_interface.h
[modify] https://crrev.com/e90eb5ab5b5e3d0c9fc9ab2f653b6045751b8374/chrome/browser/vr/test/mock_browser_ui_interface.h
[modify] https://crrev.com/e90eb5ab5b5e3d0c9fc9ab2f653b6045751b8374/chrome/browser/vr/test/mock_ui_browser_interface.h
[modify] https://crrev.com/e90eb5ab5b5e3d0c9fc9ab2f653b6045751b8374/chrome/browser/vr/testapp/vr_test_context.cc
[modify] https://crrev.com/e90eb5ab5b5e3d0c9fc9ab2f653b6045751b8374/chrome/browser/vr/testapp/vr_test_context.h
[modify] https://crrev.com/e90eb5ab5b5e3d0c9fc9ab2f653b6045751b8374/chrome/browser/vr/ui.cc
[modify] https://crrev.com/e90eb5ab5b5e3d0c9fc9ab2f653b6045751b8374/chrome/browser/vr/ui.h
[modify] https://crrev.com/e90eb5ab5b5e3d0c9fc9ab2f653b6045751b8374/chrome/browser/vr/ui_browser_interface.h
[modify] https://crrev.com/e90eb5ab5b5e3d0c9fc9ab2f653b6045751b8374/chrome/browser/vr/ui_scene_creator.cc

Project Member

Comment 2 by bugdroid1@chromium.org, May 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db04546618220592d6759dd17aaa06688987547c

commit db04546618220592d6759dd17aaa06688987547c
Author: Tibor Goldschwendt <tiborg@chromium.org>
Date: Fri May 11 14:46:34 2018

[vr] Add UI to switch between regular and incognito in tabs view

Bug:  840511 ,  838937 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: I4b688d12e0f08ce265c5796df2d96d473b4591c8
Reviewed-on: https://chromium-review.googlesource.com/1048831
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557879}
[modify] https://crrev.com/db04546618220592d6759dd17aaa06688987547c/chrome/app/generated_resources.grd
[modify] https://crrev.com/db04546618220592d6759dd17aaa06688987547c/chrome/browser/vr/model/color_scheme.cc
[modify] https://crrev.com/db04546618220592d6759dd17aaa06688987547c/chrome/browser/vr/model/color_scheme.h
[modify] https://crrev.com/db04546618220592d6759dd17aaa06688987547c/chrome/browser/vr/model/model.h
[modify] https://crrev.com/db04546618220592d6759dd17aaa06688987547c/chrome/browser/vr/ui.cc
[modify] https://crrev.com/db04546618220592d6759dd17aaa06688987547c/chrome/browser/vr/ui_scene_constants.h
[modify] https://crrev.com/db04546618220592d6759dd17aaa06688987547c/chrome/browser/vr/ui_scene_creator.cc

Comment 3 by tiborg@chromium.org, May 11 2018

Status: Fixed (was: Started)

Sign in to add a comment