New issue
Advanced search Search tips

Issue 840499 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Mac
Pri: 2
Type: Feature



Sign in to add a comment

Perfetto: Add tracing metadata events

Project Member Reported by oysteine@chromium.org, May 7 2018

Issue description

Right now only "normal" events are added.
 
Summary: Perfetto: Add tracing metadata events (was: Perfetto: Add traceing metadata events)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e82d10e0d449b3bf131f00d6a6f997296c2b0bca

commit e82d10e0d449b3bf131f00d6a6f997296c2b0bca
Author: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed Jul 18 22:38:34 2018

Roll src/third_party/perfetto 9ee65033ce97..1b013420703b (2 commits)

https://android.googlesource.com/platform/external/perfetto.git/+log/9ee65033ce97..1b013420703b


git log 9ee65033ce97..1b013420703b --date=short --no-merges --format='%ad %ae %s'
2018-07-18 oysteine@google.com Merge "Chrome: Add message for trace metadata"
2018-07-17 oysteine@google.com Chrome: Add message for trace metadata


Created with:
  gclient setdep -r src/third_party/perfetto@1b013420703b

The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:78791178, chromium:840499 
TBR=perfetto-bugs@google.com

Change-Id: I3c30a560be5cbb34f82107f798888a421f4bad7c
Reviewed-on: https://chromium-review.googlesource.com/1142015
Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#576236}
[modify] https://crrev.com/e82d10e0d449b3bf131f00d6a6f997296c2b0bca/DEPS

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a599ae24e48389eb8c717a0086b7ae0180d2d7a

commit 5a599ae24e48389eb8c717a0086b7ae0180d2d7a
Author: Oystein Eftevaag <oysteine@chromium.org>
Date: Fri Aug 03 04:45:32 2018

Perfetto: Add Chrome tracing metadata

This adds support for both global metadata, and metadata events.

As part of this, the Perfetto support expands in a couple of ways:
* Implement Flush(), so a Consumer can make sure the metadata events
  are written once, before tracing shuts down.
* Support multiple data sources; global metadata is a separate
  data source as it's not actually tied to tracing.

Bug:  840499 
Change-Id: Ib4a76f692f333ffea89f7cf8200d0da3eeefaa23
Reviewed-on: https://chromium-review.googlesource.com/1129959
Commit-Queue: oysteine <oysteine@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580454}
[modify] https://crrev.com/5a599ae24e48389eb8c717a0086b7ae0180d2d7a/base/trace_event/trace_log.cc
[modify] https://crrev.com/5a599ae24e48389eb8c717a0086b7ae0180d2d7a/base/trace_event/trace_log.h
[modify] https://crrev.com/5a599ae24e48389eb8c717a0086b7ae0180d2d7a/content/browser/tracing/background_tracing_manager_impl.cc
[modify] https://crrev.com/5a599ae24e48389eb8c717a0086b7ae0180d2d7a/content/browser/tracing/tracing_controller_impl.cc
[modify] https://crrev.com/5a599ae24e48389eb8c717a0086b7ae0180d2d7a/services/tracing/perfetto/json_trace_exporter.cc
[modify] https://crrev.com/5a599ae24e48389eb8c717a0086b7ae0180d2d7a/services/tracing/perfetto/json_trace_exporter.h
[modify] https://crrev.com/5a599ae24e48389eb8c717a0086b7ae0180d2d7a/services/tracing/perfetto/json_trace_exporter_unittest.cc
[modify] https://crrev.com/5a599ae24e48389eb8c717a0086b7ae0180d2d7a/services/tracing/perfetto/perfetto_integration_unittest.cc
[modify] https://crrev.com/5a599ae24e48389eb8c717a0086b7ae0180d2d7a/services/tracing/perfetto/perfetto_tracing_coordinator.cc
[modify] https://crrev.com/5a599ae24e48389eb8c717a0086b7ae0180d2d7a/services/tracing/perfetto/producer_host.cc
[modify] https://crrev.com/5a599ae24e48389eb8c717a0086b7ae0180d2d7a/services/tracing/perfetto/producer_host.h
[modify] https://crrev.com/5a599ae24e48389eb8c717a0086b7ae0180d2d7a/services/tracing/public/cpp/perfetto/producer_client.cc
[modify] https://crrev.com/5a599ae24e48389eb8c717a0086b7ae0180d2d7a/services/tracing/public/cpp/perfetto/producer_client.h
[modify] https://crrev.com/5a599ae24e48389eb8c717a0086b7ae0180d2d7a/services/tracing/public/cpp/perfetto/trace_event_data_source.cc
[modify] https://crrev.com/5a599ae24e48389eb8c717a0086b7ae0180d2d7a/services/tracing/public/cpp/perfetto/trace_event_data_source.h
[modify] https://crrev.com/5a599ae24e48389eb8c717a0086b7ae0180d2d7a/services/tracing/public/cpp/perfetto/trace_event_data_source_unittest.cc
[modify] https://crrev.com/5a599ae24e48389eb8c717a0086b7ae0180d2d7a/services/tracing/public/cpp/trace_event_agent.cc
[modify] https://crrev.com/5a599ae24e48389eb8c717a0086b7ae0180d2d7a/services/tracing/public/cpp/trace_event_agent.h
[modify] https://crrev.com/5a599ae24e48389eb8c717a0086b7ae0180d2d7a/services/tracing/public/mojom/perfetto_service.mojom

Status: Fixed (was: Untriaged)

Sign in to add a comment