New issue
Advanced search Search tips

Issue 840493 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

Integration tests for cancelling speech in Select-to-Speak

Project Member Reported by katie@chromium.org, May 7 2018

Issue description

These are hard:

The mock speech class doesn't have any duration for which it is "speaking", so STS doesn't enter the "speaking" state for long enough to initiate a "cancel".

I'm also not sure the mock speech class sends the correct callbacks to the Select-to-Speak extension.

Some possible fixes:
Split the tests into two pieces, one test that verifies that clicking the tray button turns the feature on/off, and a separate test (or existing test) that verifies the feature speaks properly when internally turned on/off.
More .extjs tests
Investigate callbacks and timing of mock speech class. Can we get a callback on speech "start" and force it to wait to "continue"?
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fcc242582725ec49fed096fc3d4d794ac455d76e

commit fcc242582725ec49fed096fc3d4d794ac455d76e
Author: Katie D <katie@chromium.org>
Date: Thu May 10 18:20:04 2018

Select-to-Speak integration tests can tap the ash STS button in the tray.

This allows for more full integration tests from the new button through
to the extension, in addition to the select_to_speak_browsertest.cc tests.

Bug: 753018, 840493
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib60ea7c5beea59b092fe1bb4d2ce68e27c9c347f
Reviewed-on: https://chromium-review.googlesource.com/1047947
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557590}
[modify] https://crrev.com/fcc242582725ec49fed096fc3d4d794ac455d76e/chrome/browser/resources/chromeos/select_to_speak/select_to_speak.js
[modify] https://crrev.com/fcc242582725ec49fed096fc3d4d794ac455d76e/chrome/browser/resources/chromeos/select_to_speak/select_to_speak_e2e_test_base.js
[modify] https://crrev.com/fcc242582725ec49fed096fc3d4d794ac455d76e/chrome/browser/resources/chromeos/select_to_speak/select_to_speak_mouse_selection_test.extjs

Sign in to add a comment