Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 84047 User experience metrics show DHCP WPAD feature on Windows could be improved
Starred by 3 users Project Member Reported by joi@chromium.org, May 26 2011 Back to list
Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 18575



Sign in to add a comment
Around 10% of users seem to be timing out during DHCP look-up after about 1800 ms. This indicates a need for what we had thought about, doing DHCP and DNS auto-detect in parallel.

The wait timeout may need to be tuned.

The DhcpRequestParams API seems to be often returning errors we do not specifically handle. This would be good to track down.

GetAdaptersAddresses can rarely take a very long time, it needs to be called asynchronously.
 
Comment 1 by joi@chromium.org, May 27 2011
Blocking: 18575
Project Member Comment 2 by bugdroid1@chromium.org, May 27 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=87047

------------------------------------------------------------------------
r87047 | joi@chromium.org | Fri May 27 11:14:00 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/connection_tester.cc?r1=87047&r2=87046&pathrev=87047
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/proxy_service_factory.cc?r1=87047&r2=87046&pathrev=87047
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/dhcp_proxy_script_fetcher_factory.cc?r1=87047&r2=87046&pathrev=87047
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.cc?r1=87047&r2=87046&pathrev=87047
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.h?r1=87047&r2=87046&pathrev=87047
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/dhcp_proxy_script_fetcher_factory_unittest.cc?r1=87047&r2=87046&pathrev=87047
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/dhcp_proxy_script_fetcher_factory.h?r1=87047&r2=87046&pathrev=87047

Revert 86422 - Make DHCP WPAD on by default.

Reason: Turning off for M13 branch based on some concerns from user experience metrics. Will re-enable after M13 branch point.

BUG= 18575 ,84047
TEST=Run Chrome on Windows without any flags. Enable auto-detect in proxy configuration. Net log should show attempts to auto-detect via DHCP.

Review URL: http://codereview.chromium.org/7082004
------------------------------------------------------------------------
Project Member Comment 3 by bugdroid1@chromium.org, Jun 17 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=89486

------------------------------------------------------------------------
r89486 | joi@chromium.org | Fri Jun 17 08:30:58 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/connection_tester.cc?r1=89486&r2=89485&pathrev=89486
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/proxy_service_factory.cc?r1=89486&r2=89485&pathrev=89486
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/dhcp_proxy_script_fetcher_factory.cc?r1=89486&r2=89485&pathrev=89486
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.cc?r1=89486&r2=89485&pathrev=89486
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.h?r1=89486&r2=89485&pathrev=89486
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/dhcp_proxy_script_fetcher_factory_unittest.cc?r1=89486&r2=89485&pathrev=89486
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/dhcp_proxy_script_fetcher_factory.h?r1=89486&r2=89485&pathrev=89486

Revert 87047 - Revert 86422 - Make DHCP WPAD on by default.

Reason: Turning back on for trunk to collect data as performance worries are addressed.

BUG= 18575 ,84047
TEST=Run Chrome on Windows without any flags. Enable auto-detect in proxy configuration. Net log should show attempts to auto-detect via DHCP.

Review URL: http://codereview.chromium.org/7167016
------------------------------------------------------------------------
Project Member Comment 4 by bugdroid1@chromium.org, Jun 19 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=89629

------------------------------------------------------------------------
r89629 | cevans@chromium.org | Sun Jun 19 15:37:01 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/connection_tester.cc?r1=89629&r2=89628&pathrev=89629
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/proxy_service_factory.cc?r1=89629&r2=89628&pathrev=89629
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/dhcp_proxy_script_fetcher_factory.cc?r1=89629&r2=89628&pathrev=89629
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.cc?r1=89629&r2=89628&pathrev=89629
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.h?r1=89629&r2=89628&pathrev=89629
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/dhcp_proxy_script_fetcher_factory_unittest.cc?r1=89629&r2=89628&pathrev=89629
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/dhcp_proxy_script_fetcher_factory.h?r1=89629&r2=89628&pathrev=89629

Revert 89486 - Revert 87047 - Revert 86422 - Make DHCP WPAD on by default.

Reason: Turning back on for trunk to collect data as performance worries are addressed.

BUG= 18575 ,84047
TEST=Run Chrome on Windows without any flags. Enable auto-detect in proxy configuration. Net log should show attempts to auto-detect via DHCP.

Review URL: http://codereview.chromium.org/7167016

TBR=joi@chromium.org

NOTE: I'll roll it back in if it turns out this wasn't the problem.
Review URL: http://codereview.chromium.org/7200025
------------------------------------------------------------------------
Project Member Comment 5 by bugdroid1@chromium.org, Jun 20 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=89633

------------------------------------------------------------------------
r89633 | cevans@chromium.org | Sun Jun 19 17:28:21 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/connection_tester.cc?r1=89633&r2=89632&pathrev=89633
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/proxy_service_factory.cc?r1=89633&r2=89632&pathrev=89633
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/dhcp_proxy_script_fetcher_factory.cc?r1=89633&r2=89632&pathrev=89633
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.cc?r1=89633&r2=89632&pathrev=89633
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.h?r1=89633&r2=89632&pathrev=89633
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/dhcp_proxy_script_fetcher_factory_unittest.cc?r1=89633&r2=89632&pathrev=89633
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/dhcp_proxy_script_fetcher_factory.h?r1=89633&r2=89632&pathrev=89633

Revert 89629 - Revert 89486 - Revert 87047 - Revert 86422 - Make DHCP WPAD on by default.

Reason: Turning back on for trunk to collect data as performance worries are addressed.

BUG= 18575 ,84047
TEST=Run Chrome on Windows without any flags. Enable auto-detect in proxy configuration. Net log should show attempts to auto-detect via DHCP.

Review URL: http://codereview.chromium.org/7167016

TBR=joi@chromium.org

NOTE: I'll roll it back in if it turns out this wasn't the problem.
Review URL: http://codereview.chromium.org/7200025

TBR=cevans@chromium.org
Review URL: http://codereview.chromium.org/7204024
------------------------------------------------------------------------
Blocking: chromium:18575
Should this be marked as Fixed at this point? I believe we have DHCP WPAD on by default for Windows now.
Comment 9 by joi@chromium.org, Aug 9 2012
Summary: User experience metrics show DHCP WPAD feature on Windows could be improved (was: NULL)
There were two observations from the usage data:
a) GetAdaptersAddresses occasionally takes a very long time;
b) It could benefit some users if we changed things to do DHCP and DNS auto-detect in parallel.

Only (a) has been fixed.  Whether to do (b) is a judgment call.  For sure, I don't think it blocks  issue 18575  so will remove that annotation on 18575 right away.
Comment 10 by joi@chromium.org, Aug 9 2012
Blocking: -chromium:18575
Project Member Comment 11 by bugdroid1@chromium.org, Mar 10 2013
Blocking: -chromium:18575 chromium:18575
Labels: -Area-Internals -Internals-Network-Proxy Cr-Internals Cr-Internals-Network-Proxy
Comment 12 by joi@chromium.org, Mar 27 2014
Owner: ----
Status: Available
Comment 13 by laforge@google.com, Apr 28 2015
Cc: -wtc@chromium.org
Labels: -Cr-Internals Hotlist-Polish Fixit-Net
The suggestion here is to make the ProxyScriptDecider check DHCP and WPAD in parallel.  Think it's worth keeping this open - shouldn't be too hard to do, but may be worth adding metrics to see how long each phase takes, and if there's any benefit to be had here.
I agree with the conclusion.

Just a nit on the wording: it is about doing the different parts of WPAD in parallel (i.e. WPAD can be done using DHCP and DNS; right now it does the DHCP tests first, then the DNS ones).
Project Member Comment 16 by sheriffbot@chromium.org, Jun 29 2016
Labels: Hotlist-OpenBugWithCL
A change has landed for this issue, but it's been open for over 6 months. Please review and close it if applicable. If this issue should remain open, remove the "Hotlist-OpenBugWithCL" label. If no action is taken, it will be archived in 30 days.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -FixIt-Net -Hotlist-OpenBugWithCL Fixit-Net
This bug is blocking 18575, so removing "Hotlist-OpenBugWithCL" label.

Project Member Comment 18 by sheriffbot@chromium.org, Jul 24 (3 days ago)
Labels: Hotlist-Recharge-Cold
Status: Untriaged
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Sign in to add a comment