New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 840464 link

Starred by 2 users
Status: Fixed
Owner:
xingliu@chromium.org
Closed: Jul 26
Cc:
█ wnwen@chromium.org
dtrainor@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Remove lint suppression for download location strings.

Project Member Reported by xingliu@chromium.org, May 7 2018 
Chrome Version: M68.

Download location strings in suppressions.xml should be removed once they are used in feature code.

We add these 3 strings for early translation effort.

Comment 1 by wnwen@chromium.org, Jul 25 

Is the feature already landed? Just wanted to get an update on the status.

Comment 2 by xingliu@chromium.org, Jul 25

Status: Started (was: Assigned)
Yes. But some strings may not be used in M68. I probably can delete those.
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a44663b5400871ba527677173aca56add1ffea6a

commit a44663b5400871ba527677173aca56add1ffea6a
Author: Xing Liu <xingliu@chromium.org>
Date: Thu Jul 26 22:18:29 2018

Download location: Remove unused strings.

This CL removes unused strings for download location feature.

Bug:  840464 
Change-Id: I06f4113dc06224645fa625d2ce38fd48868a184a
Reviewed-on: https://chromium-review.googlesource.com/1150509
Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578462}
[modify] https://crrev.com/a44663b5400871ba527677173aca56add1ffea6a/build/android/lint/suppressions.xml
[modify] https://crrev.com/a44663b5400871ba527677173aca56add1ffea6a/chrome/android/java/strings/android_chrome_strings.grd

Comment 4 by xingliu@chromium.org, Jul 26

Status: Fixed (was: Started)
►

Sign in to add a comment