Refactor offline_internals.js to eliminate `var` usage |
||||||
Issue descriptionAs suggested by dpapad@ [1] the `var` usage inside offline_internals.js [2] should be eliminated in favor of `let` and `const`. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1040659/8/chrome/browser/resources/offline_pages/offline_internals.js#283 [2] https://cs.chromium.org/chromium/src/chrome/browser/resources/offline_pages/offline_internals.js?type=cs&q=file:/offline_internals.js&sq=package:chromium&l=1
,
May 8 2018
+dpapad@ who suggested this to see if he has comments on this potential iOS issue.
,
May 8 2018
Can you paste the exact error you encountered? Was it coming from [1]? This check should only be checking some shared JS code locations (locations that might potentially hold iOS code) for potential iOS breakages. If you are sure that the feature is not used in iOS, even though the code is residing such a location, you can ignore the warning and proceed. [1] https://cs.chromium.org/chromium/src/PRESUBMIT.py?type=cs&q=_CheckForRiskyJsConstLet+-file:third_party+-file:infra+-file:out/Debug&l=2545
,
Jul 30
WontFix, as per #3
,
Jul 30
offline_internals.js still uses var. Comment#3 implies that the PRESUBMIT warning can be ignored since offline_internals is not used on iOS, therefore this bug is still relevant.
,
Jul 30
,
Aug 14
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by petewil@chromium.org
, May 7 2018