Repopulate STHs from the component updater if the network service crashes |
||||
Issue descriptionThe flow (will) goes from Browser -> NetworkService via UpdateSTH, which provides the STHs received by the component updater to propagate into the NetworkService. In the event the NetworkService crashes, this means that STHs won't flow until the next update of the component (~8 - 24 hours), causing SCTs to be queued in the network service waiting for a newer STH. The STH component should be smarter, and monitor for network service termination so that it can ensure the correct config.
,
Sep 28
Ryan: will you have time to look at this in the next week, or should I take a look?
,
Sep 28
I am not working on this. In the time since this bug was filed, the Component Updater team did advise on how to resolve this - which is a model similar to https://chromium.googlesource.com/chromium/src/+/b369d717da1996c2ead6fd86a1111e0d82260f32 , and in particular, https://chromium.googlesource.com/chromium/src/+/db70928281bc0bbe825e5b15fb7df8d1825adf8c/chrome/browser/component_updater/crl_set_component_installer.h#29 and https://chromium.googlesource.com/chromium/src/+/master/chrome/browser/component_updater/crl_set_component_installer_unittest.cc Because https://chromium.googlesource.com/chromium/src/+/db70928281bc0bbe825e5b15fb7df8d1825adf8c/content/browser/network_service_instance.cc#127 is synchronous (as part of https://chromium.googlesource.com/chromium/src/+/db70928281bc0bbe825e5b15fb7df8d1825adf8c/content/browser/network_service_instance.cc#62 ), it seems the best that can be done is merely asynchronously trigger an update from the component.
,
Sep 28
Sounds good, I'll take a look.
,
Sep 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec6bdd1c7cf4047f974f9ee6f60492a37a0f83cb commit ec6bdd1c7cf4047f974f9ee6f60492a37a0f83cb Author: John Abd-El-Malek <jam@chromium.org> Date: Sat Sep 29 05:43:10 2018 Repopulate Signed Tree Heads in the network process after it crashes. Bug: 840444 Change-Id: Idb614469052bbb9bff0232513e88879e1dbd8b2c Reviewed-on: https://chromium-review.googlesource.com/1252502 Reviewed-by: Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#595304} [modify] https://crrev.com/ec6bdd1c7cf4047f974f9ee6f60492a37a0f83cb/chrome/browser/component_updater/sth_set_component_installer.cc [modify] https://crrev.com/ec6bdd1c7cf4047f974f9ee6f60492a37a0f83cb/chrome/browser/component_updater/sth_set_component_installer.h [modify] https://crrev.com/ec6bdd1c7cf4047f974f9ee6f60492a37a0f83cb/chrome/browser/component_updater/sth_set_component_installer_unittest.cc [modify] https://crrev.com/ec6bdd1c7cf4047f974f9ee6f60492a37a0f83cb/chrome/browser/net/system_network_context_manager.cc
,
Oct 3
|
||||
►
Sign in to add a comment |
||||
Comment 1 by mmenke@chromium.org
, Sep 28