New issue
Advanced search Search tips

Issue 840435 link

Starred by 6 users

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocked on:
issue 841631
issue 806071
issue 840451
issue 840453
issue 840560



Sign in to add a comment

Remove Mac OSX 10.9 code

Project Member Reported by spqc...@chromium.org, May 7 2018

Issue description

Chromium has stopped supporting OS X 10.9 starting in M65. This is a meta bug that will be used to track the work of turning down old infrastructure, deleting old code, etc.
 
 
Blockedon: 840560
Blockedon: 840451
Blockedon: 840453
Project Member

Comment 4 by bugdroid1@chromium.org, May 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2acfa74883c7948d08ac0967407ec0b59e8b21e0

commit 2acfa74883c7948d08ac0967407ec0b59e8b21e0
Author: spqchan <spqchan@chromium.org>
Date: Tue May 08 18:03:55 2018

[Mac] Remove code that uses base::mac::IsOS10_9()

Bug: 840435
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I8b8e51220cf7c83d87762c6c62c68878777098bc
Reviewed-on: https://chromium-review.googlesource.com/1047952
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556869}
[modify] https://crrev.com/2acfa74883c7948d08ac0967407ec0b59e8b21e0/chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm
[modify] https://crrev.com/2acfa74883c7948d08ac0967407ec0b59e8b21e0/chrome/browser/ui/views/harmony/layout_provider_unittest.cc
[modify] https://crrev.com/2acfa74883c7948d08ac0967407ec0b59e8b21e0/ui/gfx/mac/io_surface.cc
[modify] https://crrev.com/2acfa74883c7948d08ac0967407ec0b59e8b21e0/ui/gfx/platform_font_mac_unittest.mm
[modify] https://crrev.com/2acfa74883c7948d08ac0967407ec0b59e8b21e0/ui/gl/test/gl_image_test_template.h
[modify] https://crrev.com/2acfa74883c7948d08ac0967407ec0b59e8b21e0/ui/views/style/typography_provider.cc

Blockedon: 841631
Blockedon: 806071
spqchan: I found more 10.10 checks, but they were not trivial to remove. Can you take over https://chromium-review.googlesource.com/c/chromium/src/+/1150694 ?
Sure thing!
Owner: ellyjo...@chromium.org
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4a5a407efdf4a5b10fbc65b8624bf661e0214a0

commit f4a5a407efdf4a5b10fbc65b8624bf661e0214a0
Author: Robert Sesek <rsesek@chromium.org>
Date: Wed Dec 05 10:02:25 2018

Remove 10.9 support from Mac sandbox policy files.

Bug: 840435
Change-Id: Ifa7d2e98519f0d980ed473c36386226f6d05c751
Reviewed-on: https://chromium-review.googlesource.com/c/1361330
Commit-Queue: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613923}
[modify] https://crrev.com/f4a5a407efdf4a5b10fbc65b8624bf661e0214a0/services/service_manager/sandbox/mac/common_v2.sb
[modify] https://crrev.com/f4a5a407efdf4a5b10fbc65b8624bf661e0214a0/services/service_manager/sandbox/mac/gpu_v2.sb

Sign in to add a comment