New issue
Advanced search Search tips

Issue 840429 link

Starred by 2 users
Status: Assigned
Owner:
gab@chromium.org
Cc:
thestig@chromium.org
dcheng@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 840050



Sign in to add a comment

base::debug::StackTrace().Print() is flaky

Project Member Reported by gab@chromium.org, May 7 2018 
trunk @ r556432

Tried to use base::debug::StackTrace().Print() in a unit test and it was flakily crashing on many POSIX bots (see  issue 840050 ).

We should write unittests for base/debug/stack_trace.h to ensure quality of stack traces (and ensure bots don't regress -- today many bots are lacking symbols and this sometimes gets worse... symbol-less bots are often frustratingly useless).
Project Member

Comment 1 by bugdroid1@chromium.org, May 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be2419c13b0a7a1c43d9aeef8804266c923c0191

commit be2419c13b0a7a1c43d9aeef8804266c923c0191
Author: Gabriel Charette <gab@chromium.org>
Date: Mon May 07 18:32:11 2018

Reland "[TaskScheduler] Label SchedulerWorker threads stacks with an identifying frame"

This is a reland of 5b0cb536a073784425e1ba4e1fa594aefb58bebe

It was reverted @ r556169 because the tests were flaky on POSIX.
I believe the instability is in base::debug::StackTrace().Print().

This reland excludes the tests on POSIX. The logic is cross-platform
and the tests on Windows prove it works. I will investigate POSIX
separately in crbug.com/840429


Original change's description:
> [TaskScheduler] Label SchedulerWorker threads stacks with an identifying frame
>
> I intentionally didn't add "Foreground" to non "Background" workers as
> they may be used for background tasks in some configurations and I don't
> want it to be confusing for developers.
>
> R=fdoray@chromium.org
>
> Bug:  839525 
> Change-Id: I8c1e928914aa6d2e35fedc1db4e8a639d39116b2
> Reviewed-on: https://chromium-review.googlesource.com/1044501
> Commit-Queue: Gabriel Charette <gab@chromium.org>
> Reviewed-by: François Doray <fdoray@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#556169}

TBR=fdoray@chromium.org

Bug:  839525 ,  840050 , 840429
Change-Id: Id1ee52a52483717990336920487ea1eee790358b
Reviewed-on: https://chromium-review.googlesource.com/1047846
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556506}
[modify] https://crrev.com/be2419c13b0a7a1c43d9aeef8804266c923c0191/base/task_scheduler/scheduler_single_thread_task_runner_manager.cc
[modify] https://crrev.com/be2419c13b0a7a1c43d9aeef8804266c923c0191/base/task_scheduler/scheduler_single_thread_task_runner_manager.h
[modify] https://crrev.com/be2419c13b0a7a1c43d9aeef8804266c923c0191/base/task_scheduler/scheduler_worker.cc
[modify] https://crrev.com/be2419c13b0a7a1c43d9aeef8804266c923c0191/base/task_scheduler/scheduler_worker.h
[modify] https://crrev.com/be2419c13b0a7a1c43d9aeef8804266c923c0191/base/task_scheduler/scheduler_worker_pool_impl.cc
[modify] https://crrev.com/be2419c13b0a7a1c43d9aeef8804266c923c0191/base/task_scheduler/scheduler_worker_stack_unittest.cc
[modify] https://crrev.com/be2419c13b0a7a1c43d9aeef8804266c923c0191/base/task_scheduler/scheduler_worker_unittest.cc
[modify] https://crrev.com/be2419c13b0a7a1c43d9aeef8804266c923c0191/base/task_scheduler/task_scheduler_impl_unittest.cc
►

Sign in to add a comment