Issue metadata
Sign in to add a comment
|
Webpages are not loaded properly after evicted. |
||||||||||||||||||||
Issue descriptionThis issue is same as https://bugs.chromium.org/p/chromium/issues/detail?id=770914, still happening on iOS11.4, 11.3 after the revert. App Version: 67.0.3396.35 beta iOS Version: 11.4, Device: iPhone6s, iPhoneX URL: fark.com, news.ycombinator.com Steps to reproduce: 1. Launch Google Chrome 2. Navigate to fark.com and news.ycombinator.com in two different tabs 3. Navigate to http://browsingtest.appspot.com/venti.html in two other tabs, so that the tabs from step#2 are evicted. 4. Navigate to the tabs from step#2 Observed results: Observe that the tabs are reloaded but not rendered completely and interactable. Expected results: Tabs should reloaded correctly and functional. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Safari/Firefox: Firefox: NO, Safari: NO Bug reproducible on current stable build (App Version, iOS Version): M66 NO Bug reproducible on the current beta channel build (App Version, iOS Version): M67 YES Link to video/image: https://drive.google.com/file/d/1Z_V9pfYA2OVwCUbywtRSNP7u0rG2G39c/view
,
May 7 2018
I could not reproduce the problem using test app on iOS 11.3. Apparently the system bug was not fixed (or not fully fixed).
,
May 7 2018
,
May 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/967e1009de96fd906c00c1a29e2ddaa30a597ada commit 967e1009de96fd906c00c1a29e2ddaa30a597ada Author: Eugene But <eugenebut@google.com> Date: Tue May 08 03:19:00 2018 Revert "Removed rdar://35063950 workaround for iOS 11.3." rdar://35063950 is not fixed and workaround is still needed. Bug: 840426 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I033a508aadc0dad25bc2b70b0db5527a5800e4c5 Reviewed-on: https://chromium-review.googlesource.com/1048566 Reviewed-by: Peter Lee <pkl@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#556670} [modify] https://crrev.com/967e1009de96fd906c00c1a29e2ddaa30a597ada/ios/web/web_state/ui/crw_web_controller.mm
,
May 8 2018
,
May 8 2018
This bug requires manual review: Less than 17 days to go before AppStore submit on M67 Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 8 2018
Should we file a new radar? If the test app doesn't exhibit the problem, what are we doing wrong in Chrome?
,
May 8 2018
Apple did not comment on the old radar, so I would prefer to to spend time on the new one. FWIW, I tested and could not reproduce this bug on the same phone (I think it was iPhone SE running 11.3) using Chrome and test radar app.
,
May 9 2018
Sorry I'm not following what's happening here. Are you filing a new radar to cover this issue? Do we know this fixes the issue with the workaround back in place on 11.3?
,
May 9 2018
>>> Sorry I'm not following what's happening here. Are you filing a new radar to cover this issue? I'm not filing a new radar. The old radar was not marked as fixed and apparently was not fixed. The fact that I was not able to reproduce the problem on iPhone SE does not mean that the problem does not exist on other devices. If I remember correctly it was not very easy for me to reproduce the bug when it first appeared. >>> Do we know this fixes the issue with the workaround back in place on 11.3? Srikanth, could you please verify with the next beta.
,
May 9 2018
Just to clarify what has actually happened to avoid further confusion: 1.) rdar://35063950 was filed in October. I could not consistently reproduce the issue, but I got lucky a few times. 2.) On December rdar was closed as dup of 34415016 3.) In February me and Pink commented on crbug.com/770914 that rdar://35063950 was marked as fixed (because Apple told us so) 4.) Srikhang said that the bug is still reproducible with M61 (this build does not have a workaround) 5.) I removed workaround and tested with ToT and could not repro the bug on iPhone SE iOS 11.3 (probably had false negative) 6.) I could not repro the bug on iPhone SE iOS 11.3 using rdar://35063950 sample app (probably had false negative) 7.) Since M61 was built with old SDK and I said: "let's revert the workaround on trunk and retest in Canary" 8.) Turns out the bug is still reproducible 9.) I re-landed the workaround and requested M67 cherry-pick
,
May 10 2018
Approved.
,
May 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/21256567ebb346b0671a595019c0ddccdbd46b72 commit 21256567ebb346b0671a595019c0ddccdbd46b72 Author: Eugene But <eugenebut@google.com> Date: Thu May 10 18:09:10 2018 Revert "Removed rdar://35063950 workaround for iOS 11.3." rdar://35063950 is not fixed and workaround is still needed. TBR=eugenebut@google.com (cherry picked from commit 967e1009de96fd906c00c1a29e2ddaa30a597ada) Bug: 840426 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I033a508aadc0dad25bc2b70b0db5527a5800e4c5 Reviewed-on: https://chromium-review.googlesource.com/1048566 Reviewed-by: Peter Lee <pkl@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#556670} Reviewed-on: https://chromium-review.googlesource.com/1054169 Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#547} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/21256567ebb346b0671a595019c0ddccdbd46b72/ios/web/web_state/ui/crw_web_controller.mm
,
May 15 2018
Verified in 68.0.3431.0 Canary in iPhone8plus(iOS 11.4 beta), iPhoneX(iOS 11.3.1) Tabs reloads correctly after following the steps mentioned in comment #0, looks good. Link to video: https://drive.google.com/file/d/1R-2D4dheJoJ9TqE0dzWvFUeogZH9MxNt/view?usp=sharing
,
May 15 2018
Verified in 68.0.3396.47 Beta in iPhone8plus(iOS 11.4 beta), iPhoneX(iOS 11.3.1) Tabs reloads correctly after following the steps mentioned in comment #0, looks good. Link to video: https://drive.google.com/file/d/18s3joV6v_IoX56emaqG2etlHJYadSvVi/view?usp=sharing
,
May 18 2018
Verified the issue on 67.0.3396.50 beta tested on iPhone iOS 11.3.1 Tabs are reloaded properly works fine. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by pinkerton@chromium.org
, May 7 2018