New issue
Advanced search Search tips

Issue 840412 link

Starred by 4 users

Issue metadata

Status: WontFix
Owner:
Closed: Oct 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug
Proj-Servicification

Blocking:
issue 837333



Sign in to add a comment

Figure out what is needed to support ChannelIDService in network service

Project Member Reported by xunji...@chromium.org, May 7 2018

Issue description

Filing a bug to figure out what is needed for ChannelIDService in network service.

The current usages include getting and creating channel ids. E.g. extensions/browser/api/messaging/message_property_provider.cc
 
Cc: nhar...@chromium.org
nharper@ is actively working on deprecating this. I believe the timeframe is 68 desktop and 69 Android, which may be easier than trying to get something working for a single release, for Android (i.e. assuming we're not going to solve it within the next week) and then trying to gracefully rip it all out.
Channel ID is being deprecated in M68 (except Android, which is M69), but ChannelIDService is also used for Token Binding, and there aren't any plans to deprecate/remove Token Binding yet.
@nharper: Is the plan to still expose it to extensions? If it's kept wholly in the network service, it seems significantly easier to figure out what needs to be done - but given the current API is related to CID, I wasn't sure.
There isn't any plan to not expose Token Binding IDs (formerly Channel IDs) to extensions. (The includeTlsChannelId extension API exposes both Channel IDs and Token Binding IDs - it isn't limited to just Channel ID right now.)

If we want to deprecate includeTlsChannelId, the first step would probably be to add UMA metrics to it to get a sense of how much it's being used. I'm guessing there are internal extensions using it that wouldn't want to see it disappear.

Comment 5 by dxie@chromium.org, May 14 2018

Labels: -Pri-3 Proj-Servicification-Canary OS-Chrome OS-Linux OS-Mac OS-Windows Pri-1
Status: Available (was: Untriaged)
Owner: dougt@chromium.org
Status: Assigned (was: Available)
dougt@, assigning to you to figure out the next steps.
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/302deadb0f151b3a52536a81882ada00549b11d3

commit 302deadb0f151b3a52536a81882ada00549b11d3
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Wed Jul 18 14:25:28 2018

[Extensions] Add metrics for including TLS channel ID

Bug:  840412 
Change-Id: I3da214023c2e896266e171cb153d367c43d6b2ba
Reviewed-on: https://chromium-review.googlesource.com/1141069
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Nick Harper <nharper@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576043}
[modify] https://crrev.com/302deadb0f151b3a52536a81882ada00549b11d3/extensions/browser/api/messaging/message_service.cc
[modify] https://crrev.com/302deadb0f151b3a52536a81882ada00549b11d3/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/302deadb0f151b3a52536a81882ada00549b11d3/tools/metrics/histograms/histograms.xml

currently, we are looking at the usage of Token Binding and Channel ID. We probably won't be migrating this to network service. We need to check the behavior of not migrating this next.
Labels: -Proj-Servicification-Canary
removing Proj-Servicification-Canary. Not blocking canary.
Status: WontFix (was: Assigned)
See bug 875053.

Sign in to add a comment