New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 840404 link

Starred by 5 users
Status: Fixed
Owner:
█ pilgrim@chromium.org
Last visit > 30 days ago
Closed: Jul 16
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug
Proj-Servicification

Blocking:
issue 773295



Sign in to add a comment

Migrate components/search_engines/template_url_fetcher.cc to network service

Project Member Reported by xunji...@chromium.org, May 7 2018 
components/search_engines/template_url_fetcher.cc is a dependency of chrome/browser/search_engines/template_url_fetcher_factory.cc.

template_url_fetcher.cc uses net::URLFetcher and net::URLRequestContextGetter (through StoragePartition::GetURLRequestContext). It needs to be converted to using network service's SimpleURLLoader and StoragePartition::GetNetworkContext.

Comment 1 by xunji...@chromium.org, May 8 2018

Blocking: -837333 773295

Comment 2 by dxie@chromium.org, May 14 2018

Labels: -Pri-3 Proj-Servicification-Canary OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows Pri-1

Comment 3 by dxie@google.com, Jun 27 2018

Labels: Proj-Servicification-network-url

Comment 4 by pilgrim@chromium.org, Jul 11 

 Issue 844961  has been merged into this issue.

Comment 5 by pilgrim@chromium.org, Jul 11

Status: Started (was: Available)

Comment 6 by pilgrim@chromium.org, Jul 11

Owner: pilgrim@chromium.org
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f752a674a40519fc3f45523c5334c8d40f873749

commit f752a674a40519fc3f45523c5334c8d40f873749
Author: John Abd-El-Malek <jam@chromium.org>
Date: Mon Jul 16 23:01:09 2018

Migrate TemplateURLFetcher to SimpleURLLoader

Bug:  840404 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ia73f1165adc28625f396437d394606d259317a7c
Reviewed-on: https://chromium-review.googlesource.com/1134023
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575464}
[modify] https://crrev.com/f752a674a40519fc3f45523c5334c8d40f873749/chrome/browser/search_engines/template_url_fetcher_factory.cc
[modify] https://crrev.com/f752a674a40519fc3f45523c5334c8d40f873749/chrome/browser/search_engines/template_url_fetcher_unittest.cc
[modify] https://crrev.com/f752a674a40519fc3f45523c5334c8d40f873749/chrome/browser/ui/search_engines/search_engine_tab_helper.cc
[modify] https://crrev.com/f752a674a40519fc3f45523c5334c8d40f873749/components/search_engines/BUILD.gn
[modify] https://crrev.com/f752a674a40519fc3f45523c5334c8d40f873749/components/search_engines/DEPS
[modify] https://crrev.com/f752a674a40519fc3f45523c5334c8d40f873749/components/search_engines/template_url_fetcher.cc
[modify] https://crrev.com/f752a674a40519fc3f45523c5334c8d40f873749/components/search_engines/template_url_fetcher.h
[modify] https://crrev.com/f752a674a40519fc3f45523c5334c8d40f873749/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/f752a674a40519fc3f45523c5334c8d40f873749/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/f752a674a40519fc3f45523c5334c8d40f873749/content/common/BUILD.gn
[delete] https://crrev.com/4224f9470e01e1709d634434b96e47205bf51176/content/common/net/url_fetcher.cc
[modify] https://crrev.com/f752a674a40519fc3f45523c5334c8d40f873749/content/public/browser/render_frame_host.h
[modify] https://crrev.com/f752a674a40519fc3f45523c5334c8d40f873749/content/public/common/BUILD.gn
[delete] https://crrev.com/4224f9470e01e1709d634434b96e47205bf51176/content/public/common/url_fetcher.h
[modify] https://crrev.com/f752a674a40519fc3f45523c5334c8d40f873749/extensions/browser/api/guest_view/web_view/web_view_internal_api.cc
[modify] https://crrev.com/f752a674a40519fc3f45523c5334c8d40f873749/extensions/browser/api/web_request/web_request_info.cc
[modify] https://crrev.com/f752a674a40519fc3f45523c5334c8d40f873749/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Comment 8 by jam@chromium.org, Jul 16

Status: Fixed (was: Started)
►

Sign in to add a comment