New issue
Advanced search Search tips

Issue 840399 link

Starred by 2 users

Issue metadata

Status: Duplicate
Owner:
Closed: Dec 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 797979



Sign in to add a comment

Possibly refactor capping pages to own resource handles outside of Page load metrics

Project Member Reported by ryansturm@chromium.org, May 7 2018

Issue description

Currently, a page load metrics observer owns the pause resource loading handles and triggers capped pages. We should consider moving this functionality/ownership to a different WebContentsObserver and just source information from page load metrics to that WebContentsObserver. 

Typically, PLM observers do not modify the state of the page, which page capping does. Typical "TabHelpers" which are WCO's are more closely aligned in design with page capping than PLM observers. There are some technical concerns about supporting a WCO that gets messages from a PLM observer, so those need to be investigated before moving.
 

Comment 1 by bengr@chromium.org, May 7 2018

Can you say a bit more about why this is a desirable change?
Description: Show this description
Blockedon: 797979
Can you say a bit more about why this is a desirable change?
Mergedinto: 909916
Status: Duplicate (was: Assigned)
The code will be removed entirely, so marking this as a dupe with that bug.

Sign in to add a comment