New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 840396 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug
Proj-Servicification

Blocking:
issue 773295
issue 789670
issue 840390



Sign in to add a comment

Migrate to google_apis/gaia/ to network service

Project Member Reported by xunji...@chromium.org, May 7 2018

Issue description

google_apis/gaia/gaia_auth_fetcher.cc is a dependency of chrome/browser/ui/webui/signin/inline_login_handler_impl.cc. 

google_apis/gaia/gaia_auth_fetcher.cc uses net::URLFetcher and net::URLRequestContextGetter (through StoragePartition::GetURLRequestContext). It needs to converted to using network service's SimpleURLLoader and StoragePartition::GetNetworkContext.

 
Status: Available (was: Untriaged)
Summary: Migrate to google_apis/gaia/ to network service (was: Migrate to google_apis/gaia/gaia_auth_fetcher.cc network service)
Other usages of net::URLFetchers in google_apis/gaia/ that need to be converted as well:

- google_apis/gaia/gaia_oauth_client.cc
- google_apis/gaia/oauth2_access_token_fetcher_impl.cc
- google_apis/gaia/oauth2_api_call_flow.cc

https://cs.chromium.org/search/?q=TrafficAnnotation+file:%5Esrc/google_apis/gaia/+package:%5Echromium$&type=cs

Blocking: -837333 773295

Comment 3 by dxie@chromium.org, May 14 2018

Labels: -Pri-3 Proj-Servicification-Canary Pri-1

Comment 4 by dxie@chromium.org, May 18 2018

Labels: OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows

Comment 5 by roc...@chromium.org, May 30 2018

 Issue 839037  has been merged into this issue.
Owner: jcivelli@chromium.org
Blocking: 840390
Status: Started (was: Available)
Cc: morlovich@chromium.org
I think 844983, 844982, 844981 are probably the same thing in a different guise.
Also, you might find the just-landed-pray-it-doesn't-get-reverted SigninClient::GetURLLoaderFactory useful when porting things that use these.

 Bug 844984 , too.

And  bug 844985 . (I am pretty bad at reading tables today..)

Project Member

Comment 12 by bugdroid1@chromium.org, Jun 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ab180d2e31baedb52fc299660c46003e2c70d76

commit 6ab180d2e31baedb52fc299660c46003e2c70d76
Author: Jay Civelli <jcivelli@google.com>
Date: Thu Jun 21 23:02:58 2018

Converted OAuth2AccessTokenFetcher to using SimplerURLLoader.

This impacted a lot of APIs that now need to be provided with a
SharedURLLoaderFactory. Note that in many of these APIs we still need
also the net::URLRequestContextGetter as other GAIA requests still use
the networ API directly. Once all GAIA code uses the network service,
all APIs will be changed to only take the SharedURLLoaderFactory.

Many tests that simulate URL responses had to be changed and use a
TestURLLoaderFactory. In some instances, we need the
TestURLLoaderFactory for the OAuth token but still mock the URLRequests
directly for other operations.

Also:
- split up OAuth2AccessTokenFetcherImplTest.MakeGetAccessTokenBody
  into smaller tests
- exposing ways to simulate URL responses directly in
  TestURLLoaderFactory as it was required by some tests

Bug:  840396 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I6d1d1081238aa5e1d8dc5f1469e4c752c93729fc
Reviewed-on: https://chromium-review.googlesource.com/1096309
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569408}
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/android/signin/signin_manager_android.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/browser_process_impl.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/chromeos/drive/drive_integration_service.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_impl.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/chromeos/login/existing_user_controller.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/chromeos/oauth2_token_service_delegate.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/chromeos/oauth2_token_service_delegate.h
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/chromeos/policy/affiliated_invalidation_service_provider_impl_unittest.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/chromeos/policy/cloud_external_data_policy_observer_unittest.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/chromeos/policy/device_cloud_policy_initializer.h
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/chromeos/policy/device_local_account_policy_service.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/chromeos/policy/device_local_account_policy_service.h
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/chromeos/policy/device_local_account_policy_service_unittest.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/chromeos/policy/policy_oauth2_token_fetcher.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/chromeos/policy/policy_oauth2_token_fetcher.h
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/chromeos/policy/upload_job_unittest.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.h
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_unittest.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/chromeos/policy/wildcard_login_checker.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/chromeos/settings/device_oauth2_token_service.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/chromeos/settings/device_oauth2_token_service.h
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/chromeos/settings/device_oauth2_token_service_delegate.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/chromeos/settings/device_oauth2_token_service_delegate.h
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/chromeos/settings/device_oauth2_token_service_factory.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/chromeos/settings/device_oauth2_token_service_factory.h
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/chromeos/settings/device_oauth2_token_service_unittest.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/extensions/api/enterprise_reporting_private/enterprise_reporting_private_api.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/extensions/api/enterprise_reporting_private/enterprise_reporting_private_api.h
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/extensions/api/enterprise_reporting_private/enterprise_reporting_private_unittest.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/extensions/api/sync_file_system/sync_file_system_browsertest.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/metrics/ukm_browsertest.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/policy/chrome_browser_policy_connector.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/policy/chrome_browser_policy_connector.h
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/policy/cloud/cloud_policy_browsertest.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/policy/cloud/cloud_policy_manager_browsertest.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/policy/cloud/machine_level_user_cloud_policy_helper.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/policy/cloud/machine_level_user_cloud_policy_helper.h
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/policy/cloud/user_policy_signin_service.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/policy/cloud/user_policy_signin_service.h
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/policy/cloud/user_policy_signin_service_base.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/policy/cloud/user_policy_signin_service_base.h
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/policy/cloud/user_policy_signin_service_factory.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/policy/cloud/user_policy_signin_service_factory.h
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/policy/cloud/user_policy_signin_service_mobile.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/policy/cloud/user_policy_signin_service_mobile.h
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/policy/machine_level_user_cloud_policy_controller.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/policy/machine_level_user_cloud_policy_controller.h
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/signin/chrome_signin_client.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/signin/chrome_signin_client.h
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/signin/mutable_profile_oauth2_token_service_delegate.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/signin/mutable_profile_oauth2_token_service_delegate.h
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/signin/mutable_profile_oauth2_token_service_delegate_unittest.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/signin/oauth2_token_service_delegate_android.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/signin/oauth2_token_service_delegate_android.h
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/sync/test/integration/sync_auth_test.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/sync/test/integration/sync_test.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/sync/test/integration/sync_test.h
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/sync_file_system/drive_backend/sync_engine.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/sync_file_system/drive_backend/sync_engine.h
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/ui/sync/one_click_signin_sync_starter.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/ui/webui/local_discovery/local_discovery_ui_browsertest.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/ui/webui/signin/dice_turn_sync_on_helper.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chrome/browser/ui/webui/signin/dice_turn_sync_on_helper_unittest.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chromeos/BUILD.gn
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chromeos/DEPS
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chromeos/account_manager/account_manager.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/chromeos/account_manager/account_manager.h
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/components/drive/DEPS
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/components/drive/service/drive_api_service.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/components/drive/service/drive_api_service.h
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/components/policy/core/DEPS
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/components/policy/core/browser/browser_policy_connector.h
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/components/policy/core/common/BUILD.gn
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/components/policy/core/common/cloud/cloud_policy_client.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/components/policy/core/common/cloud/cloud_policy_client.h
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/components/policy/core/common/cloud/cloud_policy_client_registration_helper.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/components/policy/core/common/cloud/cloud_policy_client_registration_helper.h
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/components/policy/core/common/cloud/cloud_policy_client_unittest.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/components/policy/core/common/cloud/mock_cloud_policy_client.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/components/policy/core/common/cloud/user_cloud_policy_manager.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/components/policy/core/common/cloud/user_cloud_policy_manager.h
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/components/policy/core/common/remote_commands/remote_commands_service_unittest.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/components/signin/DEPS
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/components/signin/core/browser/fake_profile_oauth2_token_service.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/components/signin/core/browser/fake_profile_oauth2_token_service.h
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/components/signin/core/browser/signin_client.h
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/components/signin/ios/browser/profile_oauth2_token_service_ios_delegate.h
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/components/signin/ios/browser/profile_oauth2_token_service_ios_delegate.mm
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/components/signin/ios/browser/profile_oauth2_token_service_ios_delegate_unittest.mm
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/extensions/shell/browser/shell_oauth2_token_service_delegate.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/extensions/shell/browser/shell_oauth2_token_service_delegate.h
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/google_apis/BUILD.gn
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/google_apis/DEPS
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/google_apis/drive/auth_service.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/google_apis/drive/auth_service.h
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/google_apis/gaia/DEPS
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/google_apis/gaia/fake_oauth2_token_service.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/google_apis/gaia/fake_oauth2_token_service.h
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/google_apis/gaia/fake_oauth2_token_service_delegate.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/google_apis/gaia/fake_oauth2_token_service_delegate.h
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/google_apis/gaia/oauth2_access_token_fetcher_impl.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/google_apis/gaia/oauth2_access_token_fetcher_impl.h
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/google_apis/gaia/oauth2_access_token_fetcher_impl_unittest.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/google_apis/gaia/oauth2_token_service.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/google_apis/gaia/oauth2_token_service.h
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/google_apis/gaia/oauth2_token_service_delegate.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/google_apis/gaia/oauth2_token_service_delegate.h
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/google_apis/gaia/oauth2_token_service_request_unittest.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/google_apis/gaia/oauth2_token_service_unittest.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/ios/web_view/internal/signin/ios_web_view_signin_client.mm
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/services/network/test/test_url_loader_factory.cc
[modify] https://crrev.com/6ab180d2e31baedb52fc299660c46003e2c70d76/services/network/test/test_url_loader_factory.h

Cc: reillyg@chromium.org
 Issue 844982  has been merged into this issue.
Blocking: 789670
 Issue 844983  has been merged into this issue.
 Issue 844984  has been merged into this issue.
 Issue 844985  has been merged into this issue.
Project Member

Comment 18 by bugdroid1@chromium.org, Jul 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6114e3dc456f65336364d04714dbc53505c221fa

commit 6114e3dc456f65336364d04714dbc53505c221fa
Author: Jay Civelli <jcivelli@google.com>
Date: Wed Jul 11 18:54:31 2018

Add more functionality to TestURLLoaderFactory

Adding more functionality to TestURLLoaderFactory:
- replacing the existing static SimulateResponse method with
  SimulateResponseForPendingRequest that is easier to use and supports
  setting cookies
- added support for raw headers

This is needed for an upcoming patch that changes GaiaAuthFetcher to
use SimpleURLLoader.

Bug:  840396 
TBR=msarda@chromium.org,pmarko@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ice4cc167ebecc7d690e9054a4f2ce0626edbb674
Reviewed-on: https://chromium-review.googlesource.com/1123064
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574266}
[modify] https://crrev.com/6114e3dc456f65336364d04714dbc53505c221fa/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_unittest.cc
[modify] https://crrev.com/6114e3dc456f65336364d04714dbc53505c221fa/chrome/browser/policy/cloud/test_request_interceptor.cc
[modify] https://crrev.com/6114e3dc456f65336364d04714dbc53505c221fa/google_apis/gaia/DEPS
[modify] https://crrev.com/6114e3dc456f65336364d04714dbc53505c221fa/google_apis/gaia/oauth2_token_service_unittest.cc
[modify] https://crrev.com/6114e3dc456f65336364d04714dbc53505c221fa/services/network/test/test_url_loader_factory.cc
[modify] https://crrev.com/6114e3dc456f65336364d04714dbc53505c221fa/services/network/test/test_url_loader_factory.h
[modify] https://crrev.com/6114e3dc456f65336364d04714dbc53505c221fa/services/network/test/test_url_loader_factory_unittest.cc
[modify] https://crrev.com/6114e3dc456f65336364d04714dbc53505c221fa/services/network/test/test_utils.cc
[modify] https://crrev.com/6114e3dc456f65336364d04714dbc53505c221fa/services/network/test/test_utils.h

Project Member

Comment 19 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d8dcbf6aaf6203343107cd5289b45dc64f2a5e8

commit 2d8dcbf6aaf6203343107cd5289b45dc64f2a5e8
Author: Jay Civelli <jcivelli@google.com>
Date: Thu Jul 12 16:18:37 2018

Simplify FakeGaiaCookieManagerService

Simplifying the FakeGaiaCookieManagerService API by not requiring to
call Init() with a FakeURLFetcherFactory. The FakeURLFetcherFactory is
instead a member of the FakeGaiaCookieManagerService.

This API simplification is in preparation for switching GaiaAuthFetcher
to use the SimpleURLLoader (network service).

Bug:  840396 
Change-Id: I917e4236a53bf251c3a8e82c868d5e4d99655aca
Reviewed-on: https://chromium-review.googlesource.com/1114226
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574588}
[modify] https://crrev.com/2d8dcbf6aaf6203343107cd5289b45dc64f2a5e8/chrome/browser/extensions/api/identity/identity_apitest.cc
[modify] https://crrev.com/2d8dcbf6aaf6203343107cd5289b45dc64f2a5e8/chrome/browser/search/one_google_bar/one_google_bar_service_unittest.cc
[modify] https://crrev.com/2d8dcbf6aaf6203343107cd5289b45dc64f2a5e8/chrome/browser/signin/dice_response_handler_unittest.cc
[modify] https://crrev.com/2d8dcbf6aaf6203343107cd5289b45dc64f2a5e8/chrome/browser/signin/fake_gaia_cookie_manager_service_builder.cc
[modify] https://crrev.com/2d8dcbf6aaf6203343107cd5289b45dc64f2a5e8/chrome/browser/signin/fake_gaia_cookie_manager_service_builder.h
[modify] https://crrev.com/2d8dcbf6aaf6203343107cd5289b45dc64f2a5e8/chrome/browser/signin/signin_ui_util_unittest.cc
[modify] https://crrev.com/2d8dcbf6aaf6203343107cd5289b45dc64f2a5e8/chrome/browser/supervised_user/child_accounts/child_account_service_unittest.cc
[modify] https://crrev.com/2d8dcbf6aaf6203343107cd5289b45dc64f2a5e8/chrome/browser/ui/views/frame/test_with_browser_view.cc
[modify] https://crrev.com/2d8dcbf6aaf6203343107cd5289b45dc64f2a5e8/chrome/browser/ui/views/frame/test_with_browser_view.h
[modify] https://crrev.com/2d8dcbf6aaf6203343107cd5289b45dc64f2a5e8/components/search_provider_logos/logo_service_impl_unittest.cc
[modify] https://crrev.com/2d8dcbf6aaf6203343107cd5289b45dc64f2a5e8/components/signin/core/browser/account_investigator_unittest.cc
[modify] https://crrev.com/2d8dcbf6aaf6203343107cd5289b45dc64f2a5e8/components/signin/core/browser/account_reconcilor_unittest.cc
[modify] https://crrev.com/2d8dcbf6aaf6203343107cd5289b45dc64f2a5e8/components/signin/core/browser/fake_gaia_cookie_manager_service.cc
[modify] https://crrev.com/2d8dcbf6aaf6203343107cd5289b45dc64f2a5e8/components/signin/core/browser/fake_gaia_cookie_manager_service.h
[modify] https://crrev.com/2d8dcbf6aaf6203343107cd5289b45dc64f2a5e8/components/signin/core/browser/signin_manager_unittest.cc

Project Member

Comment 20 by bugdroid1@chromium.org, Jul 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ba11572999c90d234c5e53fe7decb4bf7db1cf9

commit 1ba11572999c90d234c5e53fe7decb4bf7db1cf9
Author: Jay Civelli <jcivelli@google.com>
Date: Mon Jul 16 17:41:01 2018

Make GaiaAuthFetcher use the network::SimpleURLLoader

As part of the effort to move to the network service, changing the
GaiaAuthFetcher to use network::SimpleURLLoader instead of using
net::URLRequest.

This changes the API to take in a SharedURLLoaderFactory instead of a
net::URLRequestContextGetter and affects many callers.

Many tests also had to be changed, as it is common to mock a URLRequest
and this is now done using a TestURLLoaderFactory.

Bug:  840396 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ib93075b06855a0a5ba9349ae64e2ad43b02e0c6f
Reviewed-on: https://chromium-review.googlesource.com/1091533
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575332}
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/captive_portal/captive_portal_browsertest.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/chromeos/arc/auth/arc_auth_context.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/chromeos/login/auth/chrome_login_performer.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/chromeos/login/auth/chrome_login_performer.h
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_impl.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/chromeos/login/helper.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/chromeos/login/helper.h
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/chromeos/login/session/user_session_manager.h
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/chromeos/login/signin/oauth2_login_manager.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/chromeos/login/signin/oauth2_login_manager.h
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/chromeos/login/signin/oauth2_token_fetcher.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/chromeos/login/signin/oauth2_token_fetcher.h
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/chromeos/login/signin/oauth2_token_initializer.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/chromeos/oauth2_token_service_delegate.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/chromeos/oauth2_token_service_delegate.h
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/chromeos/oauth2_token_service_delegate_unittest.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/chromeos/policy/policy_oauth2_token_fetcher.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/chromeos/policy/policy_oauth2_token_fetcher.h
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/chromeos/policy/upload_job_unittest.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.h
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_unittest.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/chromeos/policy/wildcard_login_checker.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/chromeos/policy/wildcard_login_checker.h
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/chromeos/settings/device_oauth2_token_service.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/chromeos/settings/device_oauth2_token_service.h
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/chromeos/settings/device_oauth2_token_service_delegate.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/chromeos/settings/device_oauth2_token_service_delegate.h
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/chromeos/settings/device_oauth2_token_service_factory.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/chromeos/settings/device_oauth2_token_service_unittest.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/extensions/api/declarative_net_request/declarative_net_request_browsertest.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/extensions/api/identity/gaia_web_auth_flow.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/extensions/api/web_request/web_request_apitest.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/net/errorpage_browsertest.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/net/proxy_browsertest.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/profiles/off_the_record_profile_impl.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/profiles/off_the_record_profile_impl.h
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/profiles/profile.h
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/profiles/profile_impl.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/profiles/profile_impl.h
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/signin/chrome_signin_client.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/signin/chrome_signin_client.h
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/signin/dice_response_handler.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/signin/dice_response_handler_unittest.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/signin/mutable_profile_oauth2_token_service_delegate.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/signin/mutable_profile_oauth2_token_service_delegate.h
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/signin/mutable_profile_oauth2_token_service_delegate_unittest.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/signin/oauth2_token_service_delegate_android.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/signin/oauth2_token_service_delegate_android.h
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/signin/token_revoker_test_utils.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/sync_file_system/drive_backend/sync_engine.h
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/ui/webui/identity_internals_ui.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/ui/webui/signin/inline_login_handler_chromeos.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/ui/webui/signin/inline_login_handler_impl.h
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/test/base/testing_profile.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chrome/test/base/testing_profile.h
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chromeos/BUILD.gn
[add] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chromeos/account_manager/DEPS
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chromeos/account_manager/account_manager.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chromeos/account_manager/account_manager.h
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chromeos/account_manager/account_manager_unittest.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/chromeos/login/auth/login_performer.h
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/components/drive/DEPS
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/components/drive/service/drive_api_service.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/components/signin/core/browser/BUILD.gn
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/components/signin/core/browser/account_fetcher_service.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/components/signin/core/browser/account_reconcilor_unittest.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/components/signin/core/browser/child_account_info_fetcher.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/components/signin/core/browser/child_account_info_fetcher.h
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/components/signin/core/browser/child_account_info_fetcher_impl.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/components/signin/core/browser/child_account_info_fetcher_impl.h
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/components/signin/core/browser/fake_gaia_cookie_manager_service.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/components/signin/core/browser/fake_gaia_cookie_manager_service.h
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/components/signin/core/browser/fake_profile_oauth2_token_service.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/components/signin/core/browser/fake_profile_oauth2_token_service.h
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/components/signin/core/browser/gaia_cookie_manager_service.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/components/signin/core/browser/gaia_cookie_manager_service.h
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/components/signin/core/browser/gaia_cookie_manager_service_unittest.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/components/signin/core/browser/signin_client.h
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/components/signin/core/browser/test_signin_client.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/components/signin/core/browser/test_signin_client.h
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/components/signin/ios/browser/profile_oauth2_token_service_ios_delegate.h
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/components/signin/ios/browser/profile_oauth2_token_service_ios_delegate.mm
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/components/signin/ios/browser/profile_oauth2_token_service_ios_delegate_unittest.mm
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/content/browser/storage_partition_impl.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/content/browser/storage_partition_impl.h
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/content/browser/storage_partition_impl_browsertest.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/content/public/browser/content_browser_client.h
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/content/public/browser/storage_partition.h
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/extensions/shell/browser/api/identity/identity_api_unittest.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/extensions/shell/browser/shell_browser_main_parts.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/extensions/shell/browser/shell_oauth2_token_service.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/extensions/shell/browser/shell_oauth2_token_service.h
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/extensions/shell/browser/shell_oauth2_token_service_delegate.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/extensions/shell/browser/shell_oauth2_token_service_delegate.h
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/extensions/shell/browser/shell_oauth2_token_service_unittest.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/google_apis/BUILD.gn
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/google_apis/DEPS
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/google_apis/drive/auth_service.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/google_apis/drive/auth_service.h
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/google_apis/gaia/DEPS
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/google_apis/gaia/fake_oauth2_token_service.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/google_apis/gaia/fake_oauth2_token_service.h
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/google_apis/gaia/fake_oauth2_token_service_delegate.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/google_apis/gaia/fake_oauth2_token_service_delegate.h
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/google_apis/gaia/gaia_auth_fetcher.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/google_apis/gaia/gaia_auth_fetcher.h
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/google_apis/gaia/gaia_auth_fetcher_unittest.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/google_apis/gaia/oauth2_token_service.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/google_apis/gaia/oauth2_token_service.h
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/google_apis/gaia/oauth2_token_service_delegate.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/google_apis/gaia/oauth2_token_service_delegate.h
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/google_apis/gaia/oauth2_token_service_request_unittest.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/google_apis/gaia/oauth2_token_service_unittest.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/google_apis/gaia/ubertoken_fetcher.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/google_apis/gaia/ubertoken_fetcher.h
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/google_apis/gaia/ubertoken_fetcher_unittest.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/ios/chrome/browser/signin/gaia_auth_fetcher_ios.h
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/ios/chrome/browser/signin/gaia_auth_fetcher_ios.mm
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/ios/chrome/browser/signin/gaia_auth_fetcher_ios_unittest.mm
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/ios/chrome/browser/signin/ios_chrome_signin_client.h
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/ios/chrome/browser/signin/ios_chrome_signin_client.mm
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/ios/web_view/internal/signin/ios_web_view_signin_client.h
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/ios/web_view/internal/signin/ios_web_view_signin_client.mm
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/net/test/embedded_test_server/controllable_http_response.cc
[modify] https://crrev.com/1ba11572999c90d234c5e53fe7decb4bf7db1cf9/net/test/embedded_test_server/controllable_http_response.h

Status: Fixed (was: Started)
Are you planning any follow ups on that, or no cycles for that? 

(I suspect that a whole lot of URLRequestContextGetter wiring can be removed now --- I kept running into GaiaAuthFetcher uses when looking at it, and I would be happy to do so myself, but I don't want to get in your way)

I am not actually planning to do any specific Gaia code related follow up, so feel free to do some of the clean-up. Thanks!
Hmm, looks like google_apis/gaia/gaia_oauth_client is still using URLFetcher, so no plans on that, either?

Project Member

Comment 25 by bugdroid1@chromium.org, Oct 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0b344aaecb08c7b37504a2e00e0e7b4257371ad

commit e0b344aaecb08c7b37504a2e00e0e7b4257371ad
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Thu Oct 25 04:04:28 2018

Use TestBrowserProcess::SetSharedURLLoader factory in UserPolicySigninServiceTest

This is a clean up CL, driven-by when working on
UserPolicySigninServiceTest IdentidyManager migration.

Basically, it is possible to use the existing
TestBrowserProcess::SetSharedURLLoader API instead of adding a test-only
setter in UserPolicySigninServiceFactory.

BUG= 840396 

Change-Id: I096b56008daac945d3d9b8bd8fa536ca72cadad9
Reviewed-on: https://chromium-review.googlesource.com/c/1297930
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602604}
[modify] https://crrev.com/e0b344aaecb08c7b37504a2e00e0e7b4257371ad/chrome/browser/policy/cloud/user_policy_signin_service_factory.cc
[modify] https://crrev.com/e0b344aaecb08c7b37504a2e00e0e7b4257371ad/chrome/browser/policy/cloud/user_policy_signin_service_factory.h
[modify] https://crrev.com/e0b344aaecb08c7b37504a2e00e0e7b4257371ad/chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc

Sign in to add a comment