New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 840394 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 1
Type: Bug

Blocked on:
issue 863085

Blocking:
issue 851213



Sign in to add a comment

browser crash gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_OffscreenCanvas2DResizeOnWorker

Project Member Reported by rjkroege@chromium.org, May 7 2018

Issue description

junov@ can you redirect appropriately?
fsamuel@ CC'ed in case this is an invariants issue.

In gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_OffscreenCanvas2DResizeOnWorker, there would appear to be a renderer crash that breaks the test on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20FYI%20Debug%20(NVIDIA)

Links (may expire away):
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20FYI%20Debug%20%28NVIDIA%29/1537
https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8947180419773947040%2F%2B%2Fsteps%2Fpixel_test_on_NVIDIA_GPU_on_Linux_on_Ubuntu%2F0%2Fstdout

Stack frame segment that looks interesting:

	Thread 15 (crashed)
	 0  libc-2.19.so + 0x3a177
	    rax = 0x0000000000000006   rdx = 0x0000000000000006
	    rcx = 0xffffffffffffffff   rbx = 0x0000000000000000
	    rsi = 0x0000000000000010   rdi = 0x0000000000000001
	    rbp = 0x00007f2eb28396e0   rsp = 0x00007f2eb28395b0
	     r8 = 0x0000000000000000    r9 = 0x00007f2eb2839500
	    r10 = 0x0000000000000008   r11 = 0x0000000000000202
	    r12 = 0x0000000000000000   r13 = 0x0000000000000000
	    r14 = 0x00007f2eb28429c0   r15 = 0x00007f2eb2842700
	    rip = 0x00007f2ec52ba177
	    Found by: given as instruction pointer in context
	 1  libbase.so!base::debug::BreakDebugger() + 0x18
	    rbp = 0x00007f2eb28396f0   rsp = 0x00007f2eb28396f0
	    rip = 0x00007f2ee59707e8
	    Found by: previous frame's frame pointer
	 2  chrome!logging::(anonymous namespace)::SilentRuntimeAssertHandler(char const*, int, base::BasicStringPiece<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, base::BasicStringPiece<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >) + 0x24
	    rbp = 0x00007f2eb2839730   rsp = 0x00007f2eb2839700
	    rip = 0x00007f2ee9f63ff4
	    Found by: call frame info
	 3  chrome!Invoke<void (*const &)(const char *, int, base::BasicStringPiece<std::string>, base::BasicStringPiece<std::string>), const char *, int, base::BasicStringPiece<std::string>, base::BasicStringPiece<std::string> > [bind_internal.h : 402 + 0x20]
	    rbp = 0x00007f2eb28397c0   rsp = 0x00007f2eb2839740
	    rip = 0x00007f2ee9f66541
	    Found by: call frame info
	 4  chrome!MakeItSo<void (*const &)(const char *, int, base::BasicStringPiece<std::string>, base::BasicStringPiece<std::string>), const char *, int, base::BasicStringPiece<std::string>, base::BasicStringPiece<std::string> > [bind_internal.h : 547 + 0x5]
	    rbp = 0x00007f2eb2839820   rsp = 0x00007f2eb28397d0
	    rip = 0x00007f2ee9f6648d
	    Found by: call frame info
	 5  chrome!RunImpl<void (*const &)(const char *, int, base::BasicStringPiece<std::string>, base::BasicStringPiece<std::string>), const std::__1::tuple<> &> [bind_internal.h : 621 + 0x5]
	    rbp = 0x00007f2eb2839890   rsp = 0x00007f2eb2839830
	    rip = 0x00007f2ee9f66421
	    Found by: call frame info
	 6  chrome!Run [bind_internal.h : 603 + 0x10]
	    rbp = 0x00007f2eb2839900   rsp = 0x00007f2eb28398a0
	    rip = 0x00007f2ee9f663b3
	    Found by: call frame info
	 7  libbase.so!Run [callback.h : 125 + 0x9]
	    rbp = 0x00007f2eb2839980   rsp = 0x00007f2eb2839910
	    rip = 0x00007f2ee570fbbc
	    Found by: call frame info
	 8  libbase.so!~LogMessage [logging.cc : 835 + 0x3e]
	    rbp = 0x00007f2eb283a5f0   rsp = 0x00007f2eb2839990
	    rip = 0x00007f2ee570df8d
	    Found by: call frame info
	 9  libviz_common.so!viz::RenderPass::SetNew(unsigned long, gfx::Rect const&, gfx::Rect const&, gfx::Transform const&) + 0x24e
	    rbp = 0x00007f2eb283ab60   rsp = 0x00007f2eb283a600
	    rip = 0x00007f2edc3028ae
	    Found by: call frame info
	10  libblink_platform.so!DispatchFrame [offscreen_canvas_frame_dispatcher.cc : 167 + 0x21]
	    rbp = 0x00007f2eb283b800   rsp = 0x00007f2eb283ab70
	    rip = 0x00007f2ecd17aba0
	    Found by: call frame info
	11  libblink_core.so!PushFrame [offscreen_canvas.cc : 304 + 0x10]
	    rbx = 0x0000000000000000   rbp = 0x00007f2eb283b860
	    rsp = 0x00007f2eb283b810   rip = 0x00007f2ed023ed6e
	    Found by: call frame info
	12  libblink_modules.so!blink::OffscreenCanvasRenderingContext2D::PushFrame() + 0x7f
	    rbx = 0x0000000000000000   rbp = 0x00007f2eb283b8a0
	    rsp = 0x00007f2eb283b870   rip = 0x00007f2ecbade13f
	    Found by: call frame info
	13  libblink_core.so!blink::WorkerAnimationFrameProvider::BeginFrame() + 0xb3
	    rbx = 0x0000000000000000   rbp = 0x00007f2eb283b900
	    rsp = 0x00007f2eb283b8b0   rip = 0x00007f2ed05cc8e3
	    Found by: call frame info
	14  libblink_platform.so!blink::BeginFrameProvider::OnBeginFrame(viz::BeginFrameArgs const&) + 0x112
	    rbx = 0x0000000000000000   rbp = 0x00007f2eb283ba90
	    rsp = 0x00007f2eb283b910   rip = 0x00007f2eccf3dfb2
	    Found by: call frame info

 
Labels: -Pri-3 Pri-1
Raising priority because failing on fyi tree.
This test is also failing on mac,intel

Comment 3 by junov@chromium.org, May 7 2018

Cc: junov@chromium.org
Components: -Internals>GPU>Canvas2D
Labels: OffScreenCanvas OS-Linux
Owner: fs...@chromium.org
Status: Assigned (was: Untriaged)
@fserb: could this be due to your recent work with offscreen_canvas_frame_dispatcher?
Project Member

Comment 5 by bugdroid1@chromium.org, May 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/402c40919eae91049fc3d35b9f8042fee793c4f3

commit 402c40919eae91049fc3d35b9f8042fee793c4f3
Author: Robert Kroeger <rjkroege@chromium.org>
Date: Tue May 08 00:27:53 2018

Pixel_OffscreenCanvas2DResizeOnWorker is failing. Suppress.

Bug:  840394 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I197ac6b82a8e36e648f1c166fb9dd9bd986fef49
TBR: kbr@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1048209
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556623}
[modify] https://crrev.com/402c40919eae91049fc3d35b9f8042fee793c4f3/content/test/gpu/gpu_tests/pixel_expectations.py

Project Member

Comment 6 by bugdroid1@chromium.org, May 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c647c1abe948b6cf46c5c6a58d9337a08735e58c

commit c647c1abe948b6cf46c5c6a58d9337a08735e58c
Author: Robert Kroeger <rjkroege@chromium.org>
Date: Tue May 08 16:57:28 2018

Expand GPU test suppression for Pixel_OffscreenCanvas2DResizeOnWorker

Pixel_OffscreenCanvas2DResizeOnWorker is flaky across multiple GPUs.
Expand the test suppression.

Bug:  840394 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I009217c0c9d47d4bc854b8175e00064e70e78f8e
TBR: kbr@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1050067
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556837}
[modify] https://crrev.com/c647c1abe948b6cf46c5c6a58d9337a08735e58c/content/test/gpu/gpu_tests/pixel_expectations.py

Comment 7 by fs...@chromium.org, May 15 2018

Cc: fs...@chromium.org
 Issue 842167  has been merged into this issue.

Comment 9 by fs...@chromium.org, May 15 2018

Cc: pmonette@chromium.org
 Issue 842982  has been merged into this issue.
Project Member

Comment 10 by bugdroid1@chromium.org, May 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aedd242ea6be760bc19f38a1be3376ecbb180343

commit aedd242ea6be760bc19f38a1be3376ecbb180343
Author: Fernando Serboncini <fserb@chromium.org>
Date: Tue May 15 21:37:49 2018

Mark Pixel_WorkerRAF_OOPD tests as flaky

TBR=zmo

Bug:  840394 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I61e8896bfff86145b124b9d4b24a59e5f31c756a
Reviewed-on: https://chromium-review.googlesource.com/1060014
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558842}
[modify] https://crrev.com/aedd242ea6be760bc19f38a1be3376ecbb180343/content/test/gpu/gpu_tests/pixel_expectations.py

Components: Internals>Services>Viz
The suppression missed Linux, so going to expand it once more.
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20FYI%20Debug%20%28NVIDIA%29/1687

The failure is due to this DCHECK in RenderPass::SetNew():
[1:16:0516/081459.988376:FATAL:render_pass.cc(174)] Check failed: damage_rect.IsEmpty() || output_rect.Contains(damage_rect). damage_rect: 0,0 200x200 output_rect: 0,0 40x50
#0 0x7fc658f4831d base::debug::StackTrace::StackTrace()
#1 0x7fc658c7162c base::debug::StackTrace::StackTrace()
#2 0x7fc658ce155a logging::LogMessage::~LogMessage()
#3 0x7fc64f7abefe viz::RenderPass::SetNew()
#4 0x7fc640311439 blink::OffscreenCanvasFrameDispatcher::DispatchFrame()
#5 0x7fc64342f96e blink::OffscreenCanvas::PushFrame()
#6 0x7fc63ec3962f blink::OffscreenCanvasRenderingContext2D::PushFrame()
#7 0x7fc6437b422c blink::WorkerAnimationFrameProvider::BeginFrame()
#8 0x7fc6400d3fc6 blink::BeginFrameProvider::OnBeginFrame()
#9 0x7fc640cced26 viz::mojom::blink::CompositorFrameSinkClientStubDispatch::Accept()
#10 0x7fc6400d4c13 viz::mojom::blink::CompositorFrameSinkClientStub<>::Accept()
#11 0x7fc657081c65 mojo::InterfaceEndpointClient::HandleValidatedMessage()
#12 0x7fc6570806b1 mojo::InterfaceEndpointClient::HandleIncomingMessageThunk::Accept()
#13 0x7fc65707eb32 mojo::FilterChain::Accept()
#14 0x7fc657084895 mojo::InterfaceEndpointClient::HandleIncomingMessage()
#15 0x7fc657090ddb mojo::internal::MultiplexRouter::ProcessIncomingMessage()
#16 0x7fc657090325 mojo::internal::MultiplexRouter::Accept()
#17 0x7fc65707eb32 mojo::FilterChain::Accept()
#18 0x7fc6570709ef mojo::Connector::ReadSingleMessage()
#19 0x7fc657071a3a mojo::Connector::ReadAllAvailableMessages()
#20 0x7fc657071805 mojo::Connector::OnHandleReadyInternal()
#21 0x7fc6570716eb mojo::Connector::OnWatcherHandleReady()
#22 0x7fc6570752cf _ZN4base8internal13FunctorTraitsIMN4mojo9ConnectorEFvjEvE6InvokeIS5_PS3_JjEEEvT_OT0_DpOT1_
#23 0x7fc65707522f _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN4mojo9ConnectorEFvjEJPS5_jEEEvOT_DpOT0_
#24 0x7fc6570751c5 _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo9ConnectorEFvjEJNS0_17UnretainedWrapperIS4_EEEEEFvjEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NSF_16integer_sequenceImJXspT1_EEEEOj
#25 0x7fc6570750fb _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo9ConnectorEFvjEJNS0_17UnretainedWrapperIS4_EEEEEFvjEE3RunEPNS0_13BindStateBaseEj
#26 0x7fc65706c0ae _ZNKR4base17RepeatingCallbackIFvjEE3RunEj
#27 0x7fc65707433f mojo::SimpleWatcher::DiscardReadyState()
#28 0x7fc6570745bf _ZN4base8internal13FunctorTraitsIPFvRKNS_17RepeatingCallbackIFvjEEEjRKN4mojo18HandleSignalsStateEEvE6InvokeIRKSC_JS6_jSA_EEEvOT_DpOT0_
#29 0x7fc65707455d _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKPFvRKNS_17RepeatingCallbackIFvjEEEjRKN4mojo18HandleSignalsStateEEJS8_jSC_EEEvOT_DpOT0_
#30 0x7fc657074500 _ZN4base8internal7InvokerINS0_9BindStateIPFvRKNS_17RepeatingCallbackIFvjEEEjRKN4mojo18HandleSignalsStateEEJS5_EEEFvjSB_EE7RunImplIRKSD_RKNSt3__15tupleIJS5_EEEJLm0EEEEvOT_OT0_NSK_16integer_sequenceImJXspT1_EEEEOjSB_
#31 0x7fc657074436 _ZN4base8internal7InvokerINS0_9BindStateIPFvRKNS_17RepeatingCallbackIFvjEEEjRKN4mojo18HandleSignalsStateEEJS5_EEEFvjSB_EE3RunEPNS0_13BindStateBaseEjSB_
#32 0x7fc65700575e _ZNKR4base17RepeatingCallbackIFvjRKN4mojo18HandleSignalsStateEEE3RunEjS4_
#33 0x7fc6570050a9 mojo::SimpleWatcher::OnHandleReady()
#34 0x7fc657005f53 _ZN4base8internal13FunctorTraitsIMN4mojo13SimpleWatcherEFvijRKNS2_18HandleSignalsStateEEvE6InvokeIS8_RKNS_7WeakPtrIS3_EEJRKiRKjS6_EEEvT_OT0_DpOT1_
#35 0x7fc657005e95 _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN4mojo13SimpleWatcherEFvijRKNS4_18HandleSignalsStateEERKNS_7WeakPtrIS5_EEJRKiRKjS8_EEEvOT_OT0_DpOT1_
#36 0x7fc657005df2 _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo13SimpleWatcherEFvijRKNS3_18HandleSignalsStateEEJNS_7WeakPtrIS4_EEijS5_EEEFvvEE7RunImplIRKS9_RKNSt3__15tupleIJSB_ijS5_EEEJLm0ELm1ELm2ELm3EEEEvOT_OT0_NSI_16integer_sequenceImJXspT1_EEEE
#37 0x7fc657005c6c _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo13SimpleWatcherEFvijRKNS3_18HandleSignalsStateEEJNS_7WeakPtrIS4_EEijS5_EEEFvvEE3RunEPNS0_13BindStateBaseE
#38 0x7fc658c201fe _ZNO4base12OnceCallbackIFvvEE3RunEv
#39 0x7fc658c72af2 base::debug::TaskAnnotator::RunTask()
#40 0x7fc6405a733d base::sequence_manager::internal::ThreadControllerImpl::DoWork()
#41 0x7fc6405aa101 _ZN4base8internal13FunctorTraitsIMNS_16sequence_manager8internal20ThreadControllerImplEFvNS3_19SequencedTaskSource8WorkTypeEEvE6InvokeIS8_RKNS_7WeakPtrIS4_EEJRKS6_EEEvT_OT0_DpOT1_
#42 0x7fc6405aa065 _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMNS_16sequence_manager8internal20ThreadControllerImplEFvNS5_19SequencedTaskSource8WorkTypeEERKNS_7WeakPtrIS6_EEJRKS8_EEEvOT_OT0_DpOT1_
#43 0x7fc6405a9fdd _ZN4base8internal7InvokerINS0_9BindStateIMNS_16sequence_manager8internal20ThreadControllerImplEFvNS4_19SequencedTaskSource8WorkTypeEEJNS_7WeakPtrIS5_EES7_EEEFvvEE7RunImplIRKS9_RKNSt3__15tupleIJSB_S7_EEEJLm0ELm1EEEEvOT_OT0_NSI_16integer_sequenceImJXspT1_EEEE
#44 0x7fc6405a9eec _ZN4base8internal7InvokerINS0_9BindStateIMNS_16sequence_manager8internal20ThreadControllerImplEFvNS4_19SequencedTaskSource8WorkTypeEEJNS_7WeakPtrIS5_EES7_EEEFvvEE3RunEPNS0_13BindStateBaseE
#45 0x7fc658c201fe _ZNO4base12OnceCallbackIFvvEE3RunEv
#46 0x7fc658c72af2 base::debug::TaskAnnotator::RunTask()
#47 0x7fc658d00b59 base::internal::IncomingTaskQueue::RunTask()
#48 0x7fc658d09c47 base::MessageLoop::RunTask()
#49 0x7fc658d09eb8 base::MessageLoop::DeferOrRunPendingTask()
#50 0x7fc658d0a1e9 base::MessageLoop::DoWork()
#51 0x7fc658d0d817 base::MessagePumpDefault::Run()
#52 0x7fc658d0943b base::MessageLoop::Run()
#53 0x7fc658db2ffd base::RunLoop::Run()
#54 0x7fc658e66ae8 base::Thread::Run()
#55 0x7fc658e676a8 base::Thread::ThreadMain()
#56 0x7fc658f7d21d base::(anonymous namespace)::ThreadFunc()
#57 0x7fc6591e7184 start_thread
#58 0x7fc63848337d clone

Project Member

Comment 12 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c42a3e76aa04dcd2653a12b44a039647223a039

commit 2c42a3e76aa04dcd2653a12b44a039647223a039
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Wed May 16 21:08:47 2018

Update pixel test expectations

Pixel_OffscreenCanvas2DResizeOnWorker flaky also on Linux
Correct bug number for Pixel_WorkerRAF_OOPD expectation

TBR=kbr@chromium.org

Bug:  833902 ,  840394 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ie2d90eedc8b16baec2890f09dd8ef96c40293ada
Reviewed-on: https://chromium-review.googlesource.com/1062194
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559285}
[modify] https://crrev.com/2c42a3e76aa04dcd2653a12b44a039647223a039/content/test/gpu/gpu_tests/pixel_expectations.py

Comment 14 by kbr@chromium.org, Jun 9 2018

Blocking: 851213
Blockedon: 863085
Cc: -junov@chromium.org
Status: Fixed (was: Assigned)

Sign in to add a comment