New issue
Advanced search Search tips

Issue 840393 link

Starred by 3 users

Issue metadata

Status: Duplicate
Merged: issue 844979
Owner: ----
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug
Proj-Servicification

Blocking:
issue 773295



Sign in to add a comment

Migrate google_apis/drive/base_requests.cc to network service

Project Member Reported by xunji...@chromium.org, May 7 2018

Issue description

google_apis/drive/base_requests.cc is a dependency of chrome/browser/sync_file_system/drive_backend/sync_engine.cc.

base_requests.cc uses net::URLFetcher and net::URLRequestContextGetter (through StoragePartition::GetURLRequestContext). It should be migrated to using network service's SimpleURLLoader and StoragePartition::GetNetworkContext().

 
Blocking: -837333 773295

Comment 2 by dxie@chromium.org, May 14 2018

Labels: -Pri-3 Proj-Servicification-Canary Pri-1

Comment 3 by mastiz@chromium.org, May 16 2018

dxie@: can you please clarify why this qualifies as P1? If so, there should be an active owner assigned. Otherwise, please adjust priority.

Comment 4 by mastiz@chromium.org, May 17 2018

 dxie@: friendly ping, thanks.

Comment 5 by dxie@chromium.org, May 18 2018

np. this is a P1 because this is needed for shipping network service to canary. See go/s13n-bug-process.

Comment 6 by dxie@chromium.org, May 18 2018

Labels: OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows

Comment 7 by mastiz@chromium.org, May 18 2018

Thx! As per chromium triage best practices, P1 bugs should have an active owner. Does your team also follow this convention?

Also, to manage expectations and avoid surprises, are you expecting that the sync team will assign resources to this effort?

I'm afraid this bug doesn't qualify as P1 for our team team so we cannot commit to having resources in the short term.

Comment 8 by jkrcal@chromium.org, May 28 2018

Cc: jkrcal@chromium.org
dxie@ friendly ping!

Comment 9 by treib@chromium.org, Jun 4 2018

Components: -Services>Sync
Owner: dxie@chromium.org
Status: Assigned (was: Available)
Removing Services>Sync since this doesn't seem to be about Chrome Sync.
Also assigning dxie@ for now, since all P1s should have an owner.

Comment 10 by dxie@chromium.org, Jun 4 2018

Owner: ----
Status: Available (was: Assigned)
marking this as available. Will follow up this week in triage to see which team will move forward with this.
Mergedinto: 844979
Status: Duplicate (was: Available)

Sign in to add a comment