I'm thinking this will be --enable-features=OopAsh. In this mode ash needs to start the gpu.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/360626addbfc77a51083bf8f05d023e132aa6e76 commit 360626addbfc77a51083bf8f05d023e132aa6e76 Author: Scott Violet <sky@chromium.org> Date: Wed Jul 11 15:55:50 2018 chromeos: renames kMash to kMashDeprecated and kOopAsh to kMash This also removes mash_ash_unittests as it's no longer applicable. There is a lot of cleanup that can happen, but I'm leaving that for future patches in hopes of not making this one too big. BUG= 855767 842365 840391 TEST=covered by tests Change-Id: If97385dc0e0b65974b8773043da55d576ff3d1fb Reviewed-on: https://chromium-review.googlesource.com/1131924 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#574181} [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/BUILD.gn [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/README.md [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/accelerators/accelerator_controller.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/accessibility/accessibility_controller.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/accessibility/accessibility_highlight_controller.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/app_list/app_list_controller_impl.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/app_list/views/search_result_answer_card_view.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/ash_service.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/ash_service.h [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/display/display_color_manager.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/display/display_synchronizer.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/display/mirror_window_controller.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/display/window_tree_host_manager.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/drag_drop/drag_drop_controller_unittest.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/host/ash_window_tree_host_platform.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/ime/ime_focus_handler_unittest.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/keyboard/virtual_keyboard_controller.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/keyboard/virtual_keyboard_controller_unittest.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/magnifier/magnification_controller.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/pointer_watcher_adapter_classic_unittest.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/public/cpp/config.h [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/root_window_controller.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/shelf/shelf.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/shelf/shelf_window_watcher.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/shelf/shelf_window_watcher_unittest.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/shell.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/shell_port_mash.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/system/flag_warning/flag_warning_tray_unittest.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/system/network/network_list.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/system/network/tray_network_unittest.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/system/network/wifi_toggle_notification_controller_unittest.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/system/power/power_event_observer.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/system/status_area_widget_unittest.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/system/unified/unified_system_tray_controller_unittest.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/test/ash_test_base.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/test/ash_test_base.h [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/test/ash_test_helper.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/test/ash_test_suite.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/touch/touch_observer_hud_unittest.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/wm/lock_state_controller_unittest.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/wm/non_client_frame_controller_unittest.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/wm/overview/window_selector_unittest.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/wm/splitview/split_view_controller_unittest.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/wm/window_util.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/wm/wm_toplevel_window_event_handler.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/wm/workspace/workspace_layout_manager_unittest.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/chrome/browser/ash_service_registry.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/chrome/utility/mash_service_factory.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/mash/test/mash_test_suite.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/services/ui/demo/mus_demo_unittests.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/services/ui/ws/window_server_test_base.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/testing/buildbot/chromium.chromiumos.json [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/testing/buildbot/chromium.memory.json [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/testing/buildbot/filters/BUILD.gn [delete] https://crrev.com/b954c230264648522a5e7f96812b174cd74276f9/testing/buildbot/filters/mash.ash_unittests.filter [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/testing/buildbot/filters/mash.browser_tests.filter [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/testing/buildbot/test_suites.pyl [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ui/aura/mus/window_tree_client.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ui/aura/mus/window_tree_client.h [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ui/aura/test/aura_test_base.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ui/aura/test/aura_test_helper.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ui/aura/test/aura_test_helper.h [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ui/aura/test/mus/test_window_tree_client_setup.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ui/aura/test/mus/test_window_tree_client_setup.h [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ui/aura/test/mus/window_tree_client_private.h [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ui/aura/test/test_screen.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ui/base/ui_base_features.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ui/base/ui_base_features.h [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ui/views/mus/aura_init.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ui/views/mus/mus_client.h [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ui/views/mus/views_mus_test_suite.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0795efc4ba54976c1ea978ec4c1fafe49e3ed77a commit 0795efc4ba54976c1ea978ec4c1fafe49e3ed77a Author: James Cook <jamescook@chromium.org> Date: Wed Jul 11 23:36:17 2018 Clean up MASH_DEPRECATED in FlagWarningTray and test We don't run ash_unittests with --enable-features=Mash anymore, so manually turn on the flag to test the feature. Bug: 840391 Test: ash_unittests Change-Id: Idb61128d9a65cbc6e93095683247c3e8cd714a9d Reviewed-on: https://chromium-review.googlesource.com/1134418 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#574405} [modify] https://crrev.com/0795efc4ba54976c1ea978ec4c1fafe49e3ed77a/ash/system/flag_warning/flag_warning_tray.cc [modify] https://crrev.com/0795efc4ba54976c1ea978ec4c1fafe49e3ed77a/ash/system/flag_warning/flag_warning_tray_unittest.cc
--mash now gives ws2, so this is done.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/90b7fef81e13e1abcf8c129d9d6d57da5729b1e7 commit 90b7fef81e13e1abcf8c129d9d6d57da5729b1e7 Author: James Cook <jamescook@chromium.org> Date: Wed Jul 25 23:18:49 2018 chromeos: Clean up MASH_DEPRECATED in AccessibilityHighlightController Now that we always have a CursorManager we don't need a virtual IsCursorVisible method and we can simplify the unit test. Bug: 631103 , 840391 Test: ash_unittests Change-Id: I1af8a8f0d88df2da03147deb779cf41a13763dde Reviewed-on: https://chromium-review.googlesource.com/1150806 Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#578119} [modify] https://crrev.com/90b7fef81e13e1abcf8c129d9d6d57da5729b1e7/ash/accessibility/accessibility_highlight_controller.cc [modify] https://crrev.com/90b7fef81e13e1abcf8c129d9d6d57da5729b1e7/ash/accessibility/accessibility_highlight_controller.h [modify] https://crrev.com/90b7fef81e13e1abcf8c129d9d6d57da5729b1e7/ash/accessibility/accessibility_highlight_controller_unittest.cc
Comment 1 by sky@chromium.org
, May 9 2018