+jcivelli@: You looked into cloud print at one point. Is this tracked elsewhere? Please feel free to dup this into another crbug.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/baff73928bf3531aeebcc796c0c5456e6f2cd89c

commit baff73928bf3531aeebcc796c0c5456e6f2cd89c
Author: Jay Civelli <jcivelli@google.com>
Date: Wed May 23 18:24:52 2018

Enable PrivetRegisterTest unit-tests

Enables the PrivetRegisterTest unit-tests which werenot enabled for some
unclear reason.
This is in preparation for migrating the PrivetURLLoader to the network
service.

Bug:  840390 
Change-Id: I937d29b400424883c143ca359c7cbd91320e0302
Reviewed-on: https://chromium-review.googlesource.com/1070452
Reviewed-by: Scott Byer <scottbyer@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561167}
[modify] https://crrev.com/baff73928bf3531aeebcc796c0c5456e6f2cd89c/chrome/browser/printing/cloud_print/privet_http_unittest.cc

 Issue 844917  has been merged into this issue.

 Issue 844916  has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1bfea40e6df22fa648ab72e8b642ba63ef3c8fbf

commit 1bfea40e6df22fa648ab72e8b642ba63ef3c8fbf
Author: Jay Civelli <jcivelli@google.com>
Date: Tue Jul 24 20:13:06 2018

Privet related test clean-up

Removing wait calls from the privet_http_unittest.cc by posting tasks
without delay in tests.
Also various other clean-ups.

Bug:  840390 
Change-Id: Iac7d2cd92fcfba269e5edbf81d6df217b14016b6
Reviewed-on: https://chromium-review.googlesource.com/1146485
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577657}
[modify] https://crrev.com/1bfea40e6df22fa648ab72e8b642ba63ef3c8fbf/chrome/browser/printing/cloud_print/privet_http_impl.cc
[modify] https://crrev.com/1bfea40e6df22fa648ab72e8b642ba63ef3c8fbf/chrome/browser/printing/cloud_print/privet_http_impl.h
[modify] https://crrev.com/1bfea40e6df22fa648ab72e8b642ba63ef3c8fbf/chrome/browser/printing/cloud_print/privet_http_unittest.cc
[modify] https://crrev.com/1bfea40e6df22fa648ab72e8b642ba63ef3c8fbf/chrome/browser/printing/cloud_print/privet_url_fetcher.cc
[modify] https://crrev.com/1bfea40e6df22fa648ab72e8b642ba63ef3c8fbf/chrome/browser/printing/cloud_print/privet_url_fetcher.h
[modify] https://crrev.com/1bfea40e6df22fa648ab72e8b642ba63ef3c8fbf/chrome/browser/ui/webui/local_discovery/local_discovery_ui_browsertest.cc

I have a CL ready:
https://chromium-review.googlesource.com/c/chromium/src/+/1074189/17
but one browser test is still failing:
LocalDiscoveryUITest.RegisterTest

marking it available to be picked up.

LocalDiscoveryUITest.RegisterTest is now passing. A new CL is up and should be out for review shortly: https://crrev.com/c/1162509.

It looks like PrivetTests/* (from unit_tests) were also failing in the original https://crrev.com/c/1074189/17, so I'm working on those now...

PrivetTests* are fixed in https://crrev.com/c/1162509/4. Will send out for review after successful build.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7f320824a91d559dc27667d7df33fb794a0ba11

commit c7f320824a91d559dc27667d7df33fb794a0ba11
Author: Chris Mumford <cmumford@chromium.org>
Date: Wed Aug 08 19:39:00 2018

CloudPrint: Simplified mock test methods.

Using Googletests's testing::_ eliminates the need to separate
mock methods into the actual and a private mock method solely
for the purpose of ignoring untested parameters.

Leaving two methods unchanged as the override test method
does (or wants to do) extra work.

This is a cleanup CL and is only related to  issue 840390  in that
it factors some of the cleanup done in that CL to simplify that
review.

Bug:  840390 
Change-Id: Iaaba1d1d259df621fee0d9b98173f7f42ad261a9
Reviewed-on: https://chromium-review.googlesource.com/1163902
Reviewed-by: Wei Li <weili@chromium.org>
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581663}
[modify] https://crrev.com/c7f320824a91d559dc27667d7df33fb794a0ba11/chrome/browser/printing/cloud_print/privet_http_unittest.cc

 Issue 865381  has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d24b31e29bf10c1490a19429dd5e1dea4cbf5d74

commit d24b31e29bf10c1490a19429dd5e1dea4cbf5d74
Author: Chris Mumford <cmumford@chromium.org>
Date: Fri Aug 24 22:21:17 2018

Make PrivetURLFetcher work with the network service

Porting the PrivetURLFetcher to the network service and renaming it
PrivetURLLoader. Also cleaned-up some of the tests as part of the port,
disabling the delays in the tested code so the tests don't have to
wait.

Bug:  840390 
Change-Id: I0bf21c8f708585c00f75a088f4cc4544e0821f70
Reviewed-on: https://chromium-review.googlesource.com/1162509
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586023}
[modify] https://crrev.com/d24b31e29bf10c1490a19429dd5e1dea4cbf5d74/chrome/browser/BUILD.gn
[add] https://crrev.com/d24b31e29bf10c1490a19429dd5e1dea4cbf5d74/chrome/browser/printing/cloud_print/DEPS
[modify] https://crrev.com/d24b31e29bf10c1490a19429dd5e1dea4cbf5d74/chrome/browser/printing/cloud_print/gcd_api_flow.cc
[modify] https://crrev.com/d24b31e29bf10c1490a19429dd5e1dea4cbf5d74/chrome/browser/printing/cloud_print/gcd_api_flow.h
[modify] https://crrev.com/d24b31e29bf10c1490a19429dd5e1dea4cbf5d74/chrome/browser/printing/cloud_print/gcd_api_flow_impl.cc
[modify] https://crrev.com/d24b31e29bf10c1490a19429dd5e1dea4cbf5d74/chrome/browser/printing/cloud_print/gcd_api_flow_impl.h
[modify] https://crrev.com/d24b31e29bf10c1490a19429dd5e1dea4cbf5d74/chrome/browser/printing/cloud_print/gcd_api_flow_unittest.cc
[modify] https://crrev.com/d24b31e29bf10c1490a19429dd5e1dea4cbf5d74/chrome/browser/printing/cloud_print/privet_http.h
[modify] https://crrev.com/d24b31e29bf10c1490a19429dd5e1dea4cbf5d74/chrome/browser/printing/cloud_print/privet_http_asynchronous_factory.cc
[modify] https://crrev.com/d24b31e29bf10c1490a19429dd5e1dea4cbf5d74/chrome/browser/printing/cloud_print/privet_http_asynchronous_factory.h
[modify] https://crrev.com/d24b31e29bf10c1490a19429dd5e1dea4cbf5d74/chrome/browser/printing/cloud_print/privet_http_asynchronous_factory_impl.cc
[modify] https://crrev.com/d24b31e29bf10c1490a19429dd5e1dea4cbf5d74/chrome/browser/printing/cloud_print/privet_http_asynchronous_factory_impl.h
[modify] https://crrev.com/d24b31e29bf10c1490a19429dd5e1dea4cbf5d74/chrome/browser/printing/cloud_print/privet_http_impl.cc
[modify] https://crrev.com/d24b31e29bf10c1490a19429dd5e1dea4cbf5d74/chrome/browser/printing/cloud_print/privet_http_impl.h
[modify] https://crrev.com/d24b31e29bf10c1490a19429dd5e1dea4cbf5d74/chrome/browser/printing/cloud_print/privet_http_unittest.cc
[modify] https://crrev.com/d24b31e29bf10c1490a19429dd5e1dea4cbf5d74/chrome/browser/printing/cloud_print/privet_local_printer_lister.cc
[modify] https://crrev.com/d24b31e29bf10c1490a19429dd5e1dea4cbf5d74/chrome/browser/printing/cloud_print/privet_local_printer_lister.h
[modify] https://crrev.com/d24b31e29bf10c1490a19429dd5e1dea4cbf5d74/chrome/browser/printing/cloud_print/privet_local_printer_lister_unittest.cc
[modify] https://crrev.com/d24b31e29bf10c1490a19429dd5e1dea4cbf5d74/chrome/browser/printing/cloud_print/privet_notifications.cc
[modify] https://crrev.com/d24b31e29bf10c1490a19429dd5e1dea4cbf5d74/chrome/browser/printing/cloud_print/privet_notifications_unittest.cc
[delete] https://crrev.com/e885cc7afc5f8b87febc1634556d9cc0c3a7f9b9/chrome/browser/printing/cloud_print/privet_url_fetcher.cc
[delete] https://crrev.com/e885cc7afc5f8b87febc1634556d9cc0c3a7f9b9/chrome/browser/printing/cloud_print/privet_url_fetcher_unittest.cc
[add] https://crrev.com/d24b31e29bf10c1490a19429dd5e1dea4cbf5d74/chrome/browser/printing/cloud_print/privet_url_loader.cc
[rename] https://crrev.com/d24b31e29bf10c1490a19429dd5e1dea4cbf5d74/chrome/browser/printing/cloud_print/privet_url_loader.h
[add] https://crrev.com/d24b31e29bf10c1490a19429dd5e1dea4cbf5d74/chrome/browser/printing/cloud_print/privet_url_loader_unittest.cc
[modify] https://crrev.com/d24b31e29bf10c1490a19429dd5e1dea4cbf5d74/chrome/browser/ui/webui/local_discovery/local_discovery_ui_browsertest.cc
[modify] https://crrev.com/d24b31e29bf10c1490a19429dd5e1dea4cbf5d74/chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc
[modify] https://crrev.com/d24b31e29bf10c1490a19429dd5e1dea4cbf5d74/chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.h
[modify] https://crrev.com/d24b31e29bf10c1490a19429dd5e1dea4cbf5d74/chrome/browser/ui/webui/print_preview/privet_printer_handler.cc
[modify] https://crrev.com/d24b31e29bf10c1490a19429dd5e1dea4cbf5d74/chrome/test/BUILD.gn
[modify] https://crrev.com/d24b31e29bf10c1490a19429dd5e1dea4cbf5d74/net/http/http_status_code_list.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/966419491bdc88d1adb06ac0c47a85d966a47180

commit 966419491bdc88d1adb06ac0c47a85d966a47180
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Thu Sep 13 18:12:47 2018

Use network::GetUploadData in PrivetHTTPTest

Driven by follow up of [1].

[1] https://chromium-review.googlesource.com/1162509

TBR=thestig@chromium.org

BUG= 840390 

Change-Id: Ic3b022e68d01c5019b9efe717d92f477f1d33328
Reviewed-on: https://chromium-review.googlesource.com/1224750
Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#591073}
[modify] https://crrev.com/966419491bdc88d1adb06ac0c47a85d966a47180/chrome/browser/printing/cloud_print/privet_http_unittest.cc