Port DomainReliabilityMonitor off URLRequestContextGetter and ChromeNetworkDelegate |
|||||||
Issue descriptionRight now DomainReliabilityMonitor does two things that won't play nice with network service: 1) The monitoring is hooked into via ChromeNetworkDelegate, in OnCompleted and on OnBeforeRedirect 2 It uses URLRequestContext[Getter] and URLFetcher to do its posts. (it's also currently seems to be disabled with network service: https://cs.chromium.org/chromium/src/chrome/browser/profiles/profile_io_data.cc?rcl=793ee520fa91a8b6c95385351dab589897321616&l=1225)
,
May 14 2018
,
May 18 2018
,
Jul 26
Taking this one assuming no one is working on it.
,
Jul 30
+juliatuttle@: Can I have some more information about the requirements for |DomainReliabilityMonitor| regarding |ChromeNetworkDelegate|? More specifically: 1. Will it cause any problem if we use |WebContentsObserver| instead of |ChromeNetworkDelegate|? * e.g. Looking at the code and it doesn't seem that |DomainReliabilityMonitor| wants to block or defer loading. 2. Do we need |DomainReliabilityMonitor| for navigation only or subresource loading as well? Also, it would be really helpful if I could have a pointer to the design doc to better understand |DomainReliabilityMonitor|. Thanks!
,
Jul 30
Also I noticed that Domain Reliability is going to be deprecated[1] and replaced by Network Error Logging (issue 748549). +dcreager@: Can I have some info on the status of Network Error Logging? More specifically: Is it already usable, or do we have a target milestone? I ask because we probably don't have to port Domain Reliability if Network Error Logging is shipping soon. Thanks! [1] https://groups.google.com/a/chromium.org/d/msg/chromium-dev/bIbPyQvXtpo/7RZEA1uX4wcJ
,
Jul 30
Just noticed that there was a consensus that domain reliability doesn't block canary. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by morlovich@chromium.org
, May 7 2018