The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9cebd3448f6604ed3b1398cc8e993ec272e063a

commit d9cebd3448f6604ed3b1398cc8e993ec272e063a
Author: James Cook <jamescook@chromium.org>
Date: Fri May 11 19:48:02 2018

cros: Run touch HUD mojo app in ash_shell_with_content

The touch HUD mojo app is a new way to support the "Show taps"
ash UI feature. Previously it only worked with out-of-process
ash ("mash") but we're getting it working with in-process ash
("classic"). This CL adds support for the touch hud app to
the ash_shell_with_content executable, which is used by
developers to work on ash without building chrome.

Introduce --show-taps-app so it can run without turning on ash's
built-in touch hud impl.

Make the app open its window on startup so it can run without the
mash:launchable mojo interface, similar to quick launch. This avoids
//mash dependencies.

Introduce a constant for "touch_hud_app".

TODO: Remove the launchable interface from touch_hud_app entirely

Bug:  840380 
Test: ash_shell_with_content --show-taps-app opens a window
Change-Id: Ief7433e61916025c1dff349142ea9802a7238963
Reviewed-on: https://chromium-review.googlesource.com/1055208
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557983}
[modify] https://crrev.com/d9cebd3448f6604ed3b1398cc8e993ec272e063a/ash/BUILD.gn
[modify] https://crrev.com/d9cebd3448f6604ed3b1398cc8e993ec272e063a/ash/DEPS
[add] https://crrev.com/d9cebd3448f6604ed3b1398cc8e993ec272e063a/ash/components/touch_hud/public/mojom/BUILD.gn
[add] https://crrev.com/d9cebd3448f6604ed3b1398cc8e993ec272e063a/ash/components/touch_hud/public/mojom/OWNERS
[add] https://crrev.com/d9cebd3448f6604ed3b1398cc8e993ec272e063a/ash/components/touch_hud/public/mojom/constants.mojom
[modify] https://crrev.com/d9cebd3448f6604ed3b1398cc8e993ec272e063a/ash/components/touch_hud/touch_hud_application.cc
[modify] https://crrev.com/d9cebd3448f6604ed3b1398cc8e993ec272e063a/ash/public/cpp/ash_switches.cc
[modify] https://crrev.com/d9cebd3448f6604ed3b1398cc8e993ec272e063a/ash/public/cpp/ash_switches.h
[modify] https://crrev.com/d9cebd3448f6604ed3b1398cc8e993ec272e063a/ash/root_window_controller.cc
[modify] https://crrev.com/d9cebd3448f6604ed3b1398cc8e993ec272e063a/ash/shell.cc
[modify] https://crrev.com/d9cebd3448f6604ed3b1398cc8e993ec272e063a/ash/shell/BUILD.gn
[modify] https://crrev.com/d9cebd3448f6604ed3b1398cc8e993ec272e063a/ash/shell/ash_shell_resources.grd
[modify] https://crrev.com/d9cebd3448f6604ed3b1398cc8e993ec272e063a/ash/shell/content/client/DEPS
[modify] https://crrev.com/d9cebd3448f6604ed3b1398cc8e993ec272e063a/ash/shell/content/client/shell_browser_main_parts.cc
[modify] https://crrev.com/d9cebd3448f6604ed3b1398cc8e993ec272e063a/ash/shell/content/client/shell_content_browser_client.cc
[modify] https://crrev.com/d9cebd3448f6604ed3b1398cc8e993ec272e063a/ash/shell/content/client/shell_main_delegate.cc
[modify] https://crrev.com/d9cebd3448f6604ed3b1398cc8e993ec272e063a/chrome/browser/DEPS
[modify] https://crrev.com/d9cebd3448f6604ed3b1398cc8e993ec272e063a/chrome/browser/ash_service_registry.cc
[modify] https://crrev.com/d9cebd3448f6604ed3b1398cc8e993ec272e063a/chrome/utility/BUILD.gn
[modify] https://crrev.com/d9cebd3448f6604ed3b1398cc8e993ec272e063a/chrome/utility/DEPS
[modify] https://crrev.com/d9cebd3448f6604ed3b1398cc8e993ec272e063a/chrome/utility/mash_service_factory.cc

Things to fix:
1. Window is not transparent and is in wrong ash window container. Should be fixed by msw's work in window properties.
2. Doesn't work in chrome due to viz/gpu client init problems. sky is looking at that.
3. Doesn't work on secondary displays.
3.1. Pointer event screen coordinates are wrong on secondary displays.
3.2. Widget GetBoundsInScreen() is wrong on secondary displays, at least under ash_shell_with_content
3.3. The touch hud app itself needs to open multiple widgets.

I think 1, 2 and 3.1 are fixed no tip-of-tree now. Do I have that right?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f41362bacf2f71e419784a6fbd88a2556170698b

commit f41362bacf2f71e419784a6fbd88a2556170698b
Author: James Cook <jamescook@chromium.org>
Date: Mon May 14 17:14:05 2018

Fix pointer watcher screen coordinates under mus

Previously we were using the "root location" as the screen coordinates
for events sent to pointer watchers. This was sometimes incorrect on
secondary displays.

Instead, plumb around the display id for the event and compute the
correct screen coordinates in the //ui/views/mus layer.

This is needed to get the touch hud app working with the new
Window Service on Chrome OS.

TBR=tsepez@chromium.org

Bug: 608547,  840380 
Test: added to views_mus_unittests and aura_unittests
Change-Id: I46e90b76ec1562a5277a5679d8a4a9d64fd4333c
Reviewed-on: https://chromium-review.googlesource.com/1056205
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558347}
[modify] https://crrev.com/f41362bacf2f71e419784a6fbd88a2556170698b/ash/window_manager.cc
[modify] https://crrev.com/f41362bacf2f71e419784a6fbd88a2556170698b/ash/window_manager.h
[modify] https://crrev.com/f41362bacf2f71e419784a6fbd88a2556170698b/ash/window_manager_unittest.cc
[modify] https://crrev.com/f41362bacf2f71e419784a6fbd88a2556170698b/mash/simple_wm/simple_wm.cc
[modify] https://crrev.com/f41362bacf2f71e419784a6fbd88a2556170698b/mash/simple_wm/simple_wm.h
[modify] https://crrev.com/f41362bacf2f71e419784a6fbd88a2556170698b/services/ui/demo/mus_demo.cc
[modify] https://crrev.com/f41362bacf2f71e419784a6fbd88a2556170698b/services/ui/demo/mus_demo.h
[modify] https://crrev.com/f41362bacf2f71e419784a6fbd88a2556170698b/services/ui/test_wm/test_wm.cc
[modify] https://crrev.com/f41362bacf2f71e419784a6fbd88a2556170698b/services/ui/ws/window_server_test_base.cc
[modify] https://crrev.com/f41362bacf2f71e419784a6fbd88a2556170698b/services/ui/ws/window_server_test_base.h
[modify] https://crrev.com/f41362bacf2f71e419784a6fbd88a2556170698b/ui/aura/mus/window_tree_client.cc
[modify] https://crrev.com/f41362bacf2f71e419784a6fbd88a2556170698b/ui/aura/mus/window_tree_client_delegate.h
[modify] https://crrev.com/f41362bacf2f71e419784a6fbd88a2556170698b/ui/aura/mus/window_tree_client_unittest.cc
[modify] https://crrev.com/f41362bacf2f71e419784a6fbd88a2556170698b/ui/aura/test/aura_test_base.cc
[modify] https://crrev.com/f41362bacf2f71e419784a6fbd88a2556170698b/ui/aura/test/aura_test_base.h
[modify] https://crrev.com/f41362bacf2f71e419784a6fbd88a2556170698b/ui/aura/test/mus/test_window_tree_client_delegate.cc
[modify] https://crrev.com/f41362bacf2f71e419784a6fbd88a2556170698b/ui/aura/test/mus/test_window_tree_client_delegate.h
[modify] https://crrev.com/f41362bacf2f71e419784a6fbd88a2556170698b/ui/events/mojo/event_struct_traits.cc
[modify] https://crrev.com/f41362bacf2f71e419784a6fbd88a2556170698b/ui/views/mus/mus_client.cc
[modify] https://crrev.com/f41362bacf2f71e419784a6fbd88a2556170698b/ui/views/mus/mus_client.h
[modify] https://crrev.com/f41362bacf2f71e419784a6fbd88a2556170698b/ui/views/mus/pointer_watcher_event_router.cc
[modify] https://crrev.com/f41362bacf2f71e419784a6fbd88a2556170698b/ui/views/mus/pointer_watcher_event_router.h
[modify] https://crrev.com/f41362bacf2f71e419784a6fbd88a2556170698b/ui/views/mus/pointer_watcher_event_router_unittest.cc
[modify] https://crrev.com/f41362bacf2f71e419784a6fbd88a2556170698b/ui/wm/test/wm_test_helper.cc
[modify] https://crrev.com/f41362bacf2f71e419784a6fbd88a2556170698b/ui/wm/test/wm_test_helper.h

sky - status update:

FIXED - 1. Window is not transparent and is in wrong ash window container. Should be fixed by msw's work in window properties.
FIXED - 2. Doesn't work in chrome due to viz/gpu client init problems.
3. Doesn't work on secondary displays.
FIXED - 3.1. Pointer event screen coordinates are wrong on secondary displays.
OUT FOR REVIEW - 3.2. Widget GetBoundsInScreen() is wrong on secondary displays, at least under ash_shell_with_content
OUT FOR REVIEW - 3.3. The touch hud app itself needs to open multiple widgets.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e319550a9b6a02666101511418b472b80c98a9b7

commit e319550a9b6a02666101511418b472b80c98a9b7
Author: James Cook <jamescook@chromium.org>
Date: Tue May 15 16:09:29 2018

cros: Fix touch HUD application to support multiple displays

Create one touch hud views::Widget per display and open/close new
widgets as displays are added and removed.

Bug:  840380 
Test: run chrome --show-taps-app and add/remove displays
Change-Id: I21c87b35ec520bd1501f0cbf02c073d030c7ff64
Reviewed-on: https://chromium-review.googlesource.com/1058591
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558731}
[modify] https://crrev.com/e319550a9b6a02666101511418b472b80c98a9b7/ash/components/touch_hud/DEPS
[modify] https://crrev.com/e319550a9b6a02666101511418b472b80c98a9b7/ash/components/touch_hud/touch_hud_application.cc
[modify] https://crrev.com/e319550a9b6a02666101511418b472b80c98a9b7/ash/components/touch_hud/touch_hud_application.h

I'm removing 837692 as a blocker for this. While 837692 is not done, pointerevents now work, which is all TouchHud needs.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ef853dee0937a2595a5c4be5db4ec762228cf67

commit 4ef853dee0937a2595a5c4be5db4ec762228cf67
Author: James Cook <jamescook@chromium.org>
Date: Tue May 15 16:53:21 2018

cros: Fix Widget::GetWindowBoundsInScreen under mus

This is needed to get the touch hud application running out-of-process.
GetWindowBoundsInScreen was returning root-window coordinates, not
screen coordinates.

Bug:  840380 
Test: added to views_mus_unittest
Change-Id: I1364d17a6eb87a748e50c5367dcf9164c25b5274
Reviewed-on: https://chromium-review.googlesource.com/1058320
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558752}
[modify] https://crrev.com/4ef853dee0937a2595a5c4be5db4ec762228cf67/ui/views/mus/desktop_window_tree_host_mus.cc
[modify] https://crrev.com/4ef853dee0937a2595a5c4be5db4ec762228cf67/ui/views/mus/desktop_window_tree_host_mus_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84fdb54ea8d7150d538d2e8c81a3ca896a2ad649

commit 84fdb54ea8d7150d538d2e8c81a3ca896a2ad649
Author: James Cook <jamescook@chromium.org>
Date: Wed May 16 22:04:16 2018

cros: Clean up TouchHudApplication in preparation for adding tests

In a later CL I'm creating and tearing down the UI widgets for the
touch HUD app, which revealed problems with widget ownership and
child views::View teardown.

* Use a single PointerWatcher across all displays (since PointerWatcher
  tracks events on all displays)
* Fork ash::TouchHudRenderer. The legacy ash one will go away when the
  mojo app becomes the default.
* Make the app own the TouchHudRenderers and TouchHudRenderer own the
  views::Widget.

TODO: Eliminate Launchable interface.

Tbr: sky@chromium.org
Bug:  840380 
Test: chrome --show-taps-app paints touch points
Change-Id: Icba099a00f284835099af244db8afd93b9ed7a48
Reviewed-on: https://chromium-review.googlesource.com/1060523
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559304}
[modify] https://crrev.com/84fdb54ea8d7150d538d2e8c81a3ca896a2ad649/ash/components/touch_hud/BUILD.gn
[modify] https://crrev.com/84fdb54ea8d7150d538d2e8c81a3ca896a2ad649/ash/components/touch_hud/DEPS
[modify] https://crrev.com/84fdb54ea8d7150d538d2e8c81a3ca896a2ad649/ash/components/touch_hud/touch_hud_application.cc
[modify] https://crrev.com/84fdb54ea8d7150d538d2e8c81a3ca896a2ad649/ash/components/touch_hud/touch_hud_application.h
[add] https://crrev.com/84fdb54ea8d7150d538d2e8c81a3ca896a2ad649/ash/components/touch_hud/touch_hud_renderer.cc
[add] https://crrev.com/84fdb54ea8d7150d538d2e8c81a3ca896a2ad649/ash/components/touch_hud/touch_hud_renderer.h
[modify] https://crrev.com/84fdb54ea8d7150d538d2e8c81a3ca896a2ad649/ash/touch_hud/touch_hud_renderer.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/211e27c281bdd7c94d235011b07421904e6d48be

commit 211e27c281bdd7c94d235011b07421904e6d48be
Author: James Cook <jamescook@chromium.org>
Date: Thu May 17 14:15:02 2018

touch_hud: Remove mash::mojom::Launchable interface

It is never used.

Also remove support for running as a standalone binary, which is also
unused.

This is more cleanup before landing tests.

Bug:  840380 
Test: compiles, chrome --show-taps-app works with and without mash
Change-Id: Ib6c8e07ca12d1e12072f9af210355be7a12a2a86
Reviewed-on: https://chromium-review.googlesource.com/1062949
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559522}
[modify] https://crrev.com/211e27c281bdd7c94d235011b07421904e6d48be/ash/BUILD.gn
[modify] https://crrev.com/211e27c281bdd7c94d235011b07421904e6d48be/ash/components/touch_hud/BUILD.gn
[modify] https://crrev.com/211e27c281bdd7c94d235011b07421904e6d48be/ash/components/touch_hud/DEPS
[delete] https://crrev.com/177f6ea9952d0a4c65be251f383a6268c10f2c78/ash/components/touch_hud/main.cc
[modify] https://crrev.com/211e27c281bdd7c94d235011b07421904e6d48be/ash/components/touch_hud/manifest.json
[modify] https://crrev.com/211e27c281bdd7c94d235011b07421904e6d48be/ash/components/touch_hud/touch_hud_application.cc
[modify] https://crrev.com/211e27c281bdd7c94d235011b07421904e6d48be/ash/components/touch_hud/touch_hud_application.h
[modify] https://crrev.com/211e27c281bdd7c94d235011b07421904e6d48be/ash/manifest.json
[modify] https://crrev.com/211e27c281bdd7c94d235011b07421904e6d48be/mash/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3dc33e303f38b2d807eeb0c6590ec261b0db7057

commit 3dc33e303f38b2d807eeb0c6590ec261b0db7057
Author: James Cook <jamescook@chromium.org>
Date: Fri May 18 01:36:08 2018

cros: Add unit tests for mojo touch HUD application

This is an example of how to write unit tests for an ash component mojo
application.

Run the test in ash_unittests so we don't have to add another test
suite. Use AuraTestBase instead of AshTestBase because the application
doesn't run inside the ash process, can't use ash::Shell, etc.

Support initializing MusClient with AuraTestBase/AuraTestHelper's
TestWindowTreeClient so the test doesn't need a window service
to supply the mojo WindowTree interface.

Bug:  840380 
Test: ash_unittests, views_mus_unittests, run chrome with/without mash
Change-Id: I24cf056fcfe6a3794d7e21226133bd8ea61c5304
Reviewed-on: https://chromium-review.googlesource.com/1064569
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559773}
[modify] https://crrev.com/3dc33e303f38b2d807eeb0c6590ec261b0db7057/ash/BUILD.gn
[modify] https://crrev.com/3dc33e303f38b2d807eeb0c6590ec261b0db7057/ash/components/touch_hud/BUILD.gn
[modify] https://crrev.com/3dc33e303f38b2d807eeb0c6590ec261b0db7057/ash/components/touch_hud/touch_hud_application.h
[add] https://crrev.com/3dc33e303f38b2d807eeb0c6590ec261b0db7057/ash/components/touch_hud/touch_hud_application_unittest.cc
[modify] https://crrev.com/3dc33e303f38b2d807eeb0c6590ec261b0db7057/ash/components/touch_hud/touch_hud_renderer.h
[modify] https://crrev.com/3dc33e303f38b2d807eeb0c6590ec261b0db7057/chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc
[modify] https://crrev.com/3dc33e303f38b2d807eeb0c6590ec261b0db7057/ui/views/mus/BUILD.gn
[modify] https://crrev.com/3dc33e303f38b2d807eeb0c6590ec261b0db7057/ui/views/mus/aura_init.cc
[modify] https://crrev.com/3dc33e303f38b2d807eeb0c6590ec261b0db7057/ui/views/mus/mus_client.cc
[modify] https://crrev.com/3dc33e303f38b2d807eeb0c6590ec261b0db7057/ui/views/mus/mus_client.h
[delete] https://crrev.com/5b2d937d9580176baf3449043d77352cc5b5fc3f/ui/views/mus/test_utils.h
[modify] https://crrev.com/3dc33e303f38b2d807eeb0c6590ec261b0db7057/ui/views/mus/views_mus_test_suite.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c73f2943df47da69147b7c1f304e6aa039831e0

commit 4c73f2943df47da69147b7c1f304e6aa039831e0
Author: James Cook <jamescook@chromium.org>
Date: Mon May 21 18:00:26 2018

chromeos: Add 'Show taps with mojo app' to about:flags

Preparation for turning the new mojo app implementation on by default.
Change the switch to a base::Feature so we can trivially change the
default (or turn it off via Finch) if necessary.

Bug:  840380 
Test: ash_unittests, unit_tests for about:flags
Change-Id: Ia1c2cf5d3bb2ae77dc01e9c26c5941e1643b54cb
Reviewed-on: https://chromium-review.googlesource.com/1066826
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560298}
[modify] https://crrev.com/4c73f2943df47da69147b7c1f304e6aa039831e0/ash/public/cpp/ash_features.cc
[modify] https://crrev.com/4c73f2943df47da69147b7c1f304e6aa039831e0/ash/public/cpp/ash_features.h
[modify] https://crrev.com/4c73f2943df47da69147b7c1f304e6aa039831e0/ash/public/cpp/ash_switches.cc
[modify] https://crrev.com/4c73f2943df47da69147b7c1f304e6aa039831e0/ash/public/cpp/ash_switches.h
[modify] https://crrev.com/4c73f2943df47da69147b7c1f304e6aa039831e0/ash/root_window_controller.cc
[modify] https://crrev.com/4c73f2943df47da69147b7c1f304e6aa039831e0/ash/shell.cc
[modify] https://crrev.com/4c73f2943df47da69147b7c1f304e6aa039831e0/ash/shell/content/client/shell_browser_main_parts.cc
[modify] https://crrev.com/4c73f2943df47da69147b7c1f304e6aa039831e0/chrome/browser/about_flags.cc
[modify] https://crrev.com/4c73f2943df47da69147b7c1f304e6aa039831e0/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/4c73f2943df47da69147b7c1f304e6aa039831e0/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/4c73f2943df47da69147b7c1f304e6aa039831e0/tools/metrics/histograms/enums.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1b750fd0bca1b77f1d110ead88f9a26d6194182

commit c1b750fd0bca1b77f1d110ead88f9a26d6194182
Author: James Cook <jamescook@chromium.org>
Date: Mon May 21 21:56:17 2018

chromeos: Enable "Show taps" mojo app by default

It seems to work properly, has tests, starts up quickly, and generates
proper crash reports. Turn it on for everybody.

Note: This app only runs if the user sets "Show taps" in about:flags
or passes the --show-taps command line switch.

Bug:  840380 
Test: chrome --show-taps still shows touch points on the screen
Change-Id: I8df4dff6ecdd9f15ed4409112161152fbb344b00
Reviewed-on: https://chromium-review.googlesource.com/1067783
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560361}
[modify] https://crrev.com/c1b750fd0bca1b77f1d110ead88f9a26d6194182/ash/public/cpp/ash_features.cc
[modify] https://crrev.com/c1b750fd0bca1b77f1d110ead88f9a26d6194182/ash/touch/touch_observer_hud_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a938409801bba0e815fcc1a7d1ba498099da96ab

commit a938409801bba0e815fcc1a7d1ba498099da96ab
Author: James Cook <jamescook@chromium.org>
Date: Wed May 23 02:54:26 2018

chromeos: Rename "touch_hud" mojo app to "tap_visualizer"

It implements the "Show Taps" UI feature and is turned on via the flag
--show-taps, so use a name with "taps" in it.

Bug:  840380 
Test: compiles, ash_unittests
Change-Id: I84784115cb7ba26bfcac8c28db293df62b95ebf5
Reviewed-on: https://chromium-review.googlesource.com/1067851
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560907}
[modify] https://crrev.com/a938409801bba0e815fcc1a7d1ba498099da96ab/ash/BUILD.gn
[modify] https://crrev.com/a938409801bba0e815fcc1a7d1ba498099da96ab/ash/DEPS
[rename] https://crrev.com/a938409801bba0e815fcc1a7d1ba498099da96ab/ash/components/tap_visualizer/BUILD.gn
[rename] https://crrev.com/a938409801bba0e815fcc1a7d1ba498099da96ab/ash/components/tap_visualizer/DEPS
[rename] https://crrev.com/a938409801bba0e815fcc1a7d1ba498099da96ab/ash/components/tap_visualizer/OWNERS
[rename] https://crrev.com/a938409801bba0e815fcc1a7d1ba498099da96ab/ash/components/tap_visualizer/manifest.json
[rename] https://crrev.com/a938409801bba0e815fcc1a7d1ba498099da96ab/ash/components/tap_visualizer/public/mojom/BUILD.gn
[rename] https://crrev.com/a938409801bba0e815fcc1a7d1ba498099da96ab/ash/components/tap_visualizer/public/mojom/OWNERS
[rename] https://crrev.com/a938409801bba0e815fcc1a7d1ba498099da96ab/ash/components/tap_visualizer/public/mojom/constants.mojom
[rename] https://crrev.com/a938409801bba0e815fcc1a7d1ba498099da96ab/ash/components/tap_visualizer/tap_renderer.cc
[rename] https://crrev.com/a938409801bba0e815fcc1a7d1ba498099da96ab/ash/components/tap_visualizer/tap_renderer.h
[rename] https://crrev.com/a938409801bba0e815fcc1a7d1ba498099da96ab/ash/components/tap_visualizer/tap_visualizer_app.cc
[rename] https://crrev.com/a938409801bba0e815fcc1a7d1ba498099da96ab/ash/components/tap_visualizer/tap_visualizer_app.h
[rename] https://crrev.com/a938409801bba0e815fcc1a7d1ba498099da96ab/ash/components/tap_visualizer/tap_visualizer_app_unittest.cc
[modify] https://crrev.com/a938409801bba0e815fcc1a7d1ba498099da96ab/ash/public/cpp/ash_features.cc
[modify] https://crrev.com/a938409801bba0e815fcc1a7d1ba498099da96ab/ash/public/cpp/ash_features.h
[modify] https://crrev.com/a938409801bba0e815fcc1a7d1ba498099da96ab/ash/root_window_controller.cc
[modify] https://crrev.com/a938409801bba0e815fcc1a7d1ba498099da96ab/ash/shell.cc
[modify] https://crrev.com/a938409801bba0e815fcc1a7d1ba498099da96ab/ash/shell/BUILD.gn
[modify] https://crrev.com/a938409801bba0e815fcc1a7d1ba498099da96ab/ash/shell/ash_shell_resources.grd
[modify] https://crrev.com/a938409801bba0e815fcc1a7d1ba498099da96ab/ash/shell/content/client/DEPS
[modify] https://crrev.com/a938409801bba0e815fcc1a7d1ba498099da96ab/ash/shell/content/client/shell_browser_main_parts.cc
[modify] https://crrev.com/a938409801bba0e815fcc1a7d1ba498099da96ab/ash/shell/content/client/shell_content_browser_client.cc
[modify] https://crrev.com/a938409801bba0e815fcc1a7d1ba498099da96ab/ash/shell/content/client/shell_main_delegate.cc
[modify] https://crrev.com/a938409801bba0e815fcc1a7d1ba498099da96ab/ash/touch/touch_observer_hud_unittest.cc
[modify] https://crrev.com/a938409801bba0e815fcc1a7d1ba498099da96ab/chrome/app/BUILD.gn
[modify] https://crrev.com/a938409801bba0e815fcc1a7d1ba498099da96ab/chrome/browser/DEPS
[modify] https://crrev.com/a938409801bba0e815fcc1a7d1ba498099da96ab/chrome/browser/about_flags.cc
[modify] https://crrev.com/a938409801bba0e815fcc1a7d1ba498099da96ab/chrome/browser/ash_service_registry.cc
[modify] https://crrev.com/a938409801bba0e815fcc1a7d1ba498099da96ab/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/a938409801bba0e815fcc1a7d1ba498099da96ab/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/a938409801bba0e815fcc1a7d1ba498099da96ab/chrome/utility/BUILD.gn
[modify] https://crrev.com/a938409801bba0e815fcc1a7d1ba498099da96ab/chrome/utility/DEPS
[modify] https://crrev.com/a938409801bba0e815fcc1a7d1ba498099da96ab/chrome/utility/mash_service_factory.cc
[modify] https://crrev.com/a938409801bba0e815fcc1a7d1ba498099da96ab/tools/metrics/histograms/enums.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22c0a70c04a1f444a9856591a0c8284fd769f066

commit 22c0a70c04a1f444a9856591a0c8284fd769f066
Author: James Cook <jamescook@chromium.org>
Date: Wed May 30 04:35:36 2018

chromeos: Record histogram for mash service launch

As part of out-of-process ash we're converting UI features to small
mojo apps. Record a histogram for app launch. Use an enum so we can
compare the relative frequency of individual UI feature service
launches to the overall out-of-process-ash service launch.

Bug:  840380 
Test: manual, check chrome://histograms after --show-taps
Change-Id: Id4451c5b6b8e091e245518d4cc200cc90d14e6ff
Reviewed-on: https://chromium-review.googlesource.com/1077168
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562733}
[modify] https://crrev.com/22c0a70c04a1f444a9856591a0c8284fd769f066/chrome/utility/mash_service_factory.cc
[modify] https://crrev.com/22c0a70c04a1f444a9856591a0c8284fd769f066/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/22c0a70c04a1f444a9856591a0c8284fd769f066/tools/metrics/histograms/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08ebee4244fdeebca9aa0613020bc83193ac7b8c

commit 08ebee4244fdeebca9aa0613020bc83193ac7b8c
Author: James Cook <jamescook@chromium.org>
Date: Tue Aug 07 04:06:42 2018

chromeos: Delete legacy non-app version of "show taps" feature

The mojo app version is the default in stable channel in M68.
Delete the legacy non-app version and remove the feature flag.
Clean up touch HUD unit tests.

Bug:  840380 
Test: ash_unittests
Change-Id: I940a3344eed05404fe4656827bad98749244f0b1
Reviewed-on: https://chromium-review.googlesource.com/1164480
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581127}
[modify] https://crrev.com/08ebee4244fdeebca9aa0613020bc83193ac7b8c/ash/BUILD.gn
[modify] https://crrev.com/08ebee4244fdeebca9aa0613020bc83193ac7b8c/ash/public/cpp/ash_features.cc
[modify] https://crrev.com/08ebee4244fdeebca9aa0613020bc83193ac7b8c/ash/public/cpp/ash_features.h
[modify] https://crrev.com/08ebee4244fdeebca9aa0613020bc83193ac7b8c/ash/root_window_controller.cc
[modify] https://crrev.com/08ebee4244fdeebca9aa0613020bc83193ac7b8c/ash/root_window_controller.h
[modify] https://crrev.com/08ebee4244fdeebca9aa0613020bc83193ac7b8c/ash/shell.cc
[modify] https://crrev.com/08ebee4244fdeebca9aa0613020bc83193ac7b8c/ash/shell/content/client/shell_browser_main_parts.cc
[delete] https://crrev.com/d6ab8b2e0fdfb32db994680a2392d19d50e85319/ash/touch/touch_hud_projection.cc
[delete] https://crrev.com/d6ab8b2e0fdfb32db994680a2392d19d50e85319/ash/touch/touch_hud_projection.h
[modify] https://crrev.com/08ebee4244fdeebca9aa0613020bc83193ac7b8c/ash/touch/touch_observer_hud.h
[modify] https://crrev.com/08ebee4244fdeebca9aa0613020bc83193ac7b8c/ash/touch/touch_observer_hud_unittest.cc
[delete] https://crrev.com/d6ab8b2e0fdfb32db994680a2392d19d50e85319/ash/touch_hud/BUILD.gn
[delete] https://crrev.com/d6ab8b2e0fdfb32db994680a2392d19d50e85319/ash/touch_hud/ash_touch_hud_export.h
[delete] https://crrev.com/d6ab8b2e0fdfb32db994680a2392d19d50e85319/ash/touch_hud/touch_hud_renderer.cc
[delete] https://crrev.com/d6ab8b2e0fdfb32db994680a2392d19d50e85319/ash/touch_hud/touch_hud_renderer.h
[modify] https://crrev.com/08ebee4244fdeebca9aa0613020bc83193ac7b8c/chrome/browser/about_flags.cc
[modify] https://crrev.com/08ebee4244fdeebca9aa0613020bc83193ac7b8c/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/08ebee4244fdeebca9aa0613020bc83193ac7b8c/chrome/browser/flag_descriptions.h