New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 840368 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
OOO until Feb 4th
Closed: May 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 620034



Sign in to add a comment

Add google() repository for android studio

Project Member Reported by wnwen@chromium.org, May 7 2018

Issue description

Once we are using Gradle 4.0+ on stable

  allprojects {
    repositories {
      jcenter()
      google()
    }
  }
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3c401c7f25b5dfeb934212ab0934c638855a7ac

commit f3c401c7f25b5dfeb934212ab0934c638855a7ac
Author: Peter Wen <wnwen@chromium.org>
Date: Thu May 10 16:16:05 2018

Android: Basic support for C++ in Android Studio

Add a new flag for generate_gradle.py, --native-target <gn target name>.
This allows C++ editing when --all is either passed or implicit (by
default). Starting with --native-target //chrome/android:monochrome in
Android Studio Canary (3.2) will result in most of the C++ files being
indexed and available both via the Android project view as well as the
double shift "search everywhere" box.

Switched maven URL to use "google()" instead, this works for all Android
Studio 3.0+, which covers all of stable/beta/canary.

Add specific AndroidManifest.xml to be used for the _all pseudo gradle
module since Android Studio now requires minSdk to not be specified in
the AndroidManifest.xml file.

Bug: 841529,827294, 840368 
Change-Id: Ifdee12bf7f9e7faf81cabf92dbf4c5613eb89996
Reviewed-on: https://chromium-review.googlesource.com/1053117
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557543}
[add] https://crrev.com/f3c401c7f25b5dfeb934212ab0934c638855a7ac/build/android/gradle/AndroidManifest.xml
[modify] https://crrev.com/f3c401c7f25b5dfeb934212ab0934c638855a7ac/build/android/gradle/android.jinja
[add] https://crrev.com/f3c401c7f25b5dfeb934212ab0934c638855a7ac/build/android/gradle/cmake.jinja
[modify] https://crrev.com/f3c401c7f25b5dfeb934212ab0934c638855a7ac/build/android/gradle/generate_gradle.py
[modify] https://crrev.com/f3c401c7f25b5dfeb934212ab0934c638855a7ac/build/android/gradle/root.jinja

Comment 2 by wnwen@chromium.org, May 10 2018

Status: Fixed (was: Assigned)

Sign in to add a comment