New issue
Advanced search Search tips

Issue 840359 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Aug 27
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug
Proj-Servicification


Sign in to add a comment

Port functionality of ChromeNetworkDelegate (tracking bug)

Project Member Reported by morlovich@chromium.org, May 7 2018

Issue description

Just an organizational bug to note everything it does (much, but not all, of which already has bugs)
 
Blockedon: 838906
Blockedon: 789636
Blockedon: 789632
Blockedon: 803452
Blocking: 598073
Blockedon: 840386
Here is a summary of hopefully everything it implements:
- Extensions code gets forwarded ~everything
- Header rewriting:
  - Stripping referrers (#838906)
  - Adding headers or rewriting URLs to force google or youtube safe search, based on prefs [no bug for port yet]
  - Adding some sort of google apps related header, based on a pref [no bug for port yet]
- Removal of variations headers on redirects (see #794644 for context), [no bug
  for port yet]
- DomainReliabilityMonitor (#840386)
- Cookie policy (#803452, #789632); including OnCanEnablePrivacyMode
- Also reporting policy, which seems to rely partly on cookie policy, but also has its own thing. [no bug for port yet]
- Which cookies were sent to this URL UI --- #789636
- Policy for file:///. Presumably we won't want network service to handle file:/// at all, due to sandbox,
  but the support in browser should probably implement the same policies. [no bug for port yet]
- OnAreExperimentalCookieFeaturesEnabled --- just a bool from a switch [no bug for port yet]
- Byte transfer metrics:
  - TaskManagerInterface::OnRawBytesRead (and Sent); which also uses content::ResourceRequestInfo::ForRequest(net::URLRequest* request)
    to associate with child and "route_id"
  - data_usage::DataUseAggregator: also looks up LoadTimingInfo for the request, and things like
    request->site_for_cookies()
- Stats & co:
  - RecordNetworkErrorHistograms records Net.HttpRequestCompletionErrorCodes and
    Net.HttpRequestCompletionErrorCodes.MainFrame (based on LOAD_MAIN_FRAME_DEPRECATED).
    This can probably just be in net/?
  - OnCancelURLWithPolicyViolatingReferrerHandler does a DumpWithoutCrashing and adds to another
    Net. histogram
Blockedon: 841309
Blockedon: 841313
Blockedon: 841316
Hmm, I am not sure OnAreExperimentalCookieFeaturesEnabled is actually used any more, might be able to just excise. 
Blocking: 837333

Comment 14 by dxie@chromium.org, May 14 2018

Labels: -Pri-3 Proj-Servicification-Canary Pri-1

Comment 15 by dougt@chromium.org, May 17 2018

Status: Available (was: Untriaged)

Comment 16 by dxie@chromium.org, May 18 2018

Labels: OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
Blockedon: 852859
Blockedon: 852861
Labels: -Pri-1 Pri-2
Status: Fixed (was: Available)
All blocked bugs resolved.  Resolving Fixed.

Sign in to add a comment