New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 840357 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Task

Blocking:
issue 851433



Sign in to add a comment

Separate UserConsents from UserEvents

Project Member Reported by vitaliii@chromium.org, May 7 2018

Issue description

Add a new sync datatype specifically for UserConsents instead of special casing them in UserEvents. There is already a lot of special casing and the last argument for the separation was that we need to record user consents always and all other user events only when history sync is enabled (issue 839421).


 
Project Member

Comment 1 by bugdroid1@chromium.org, May 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0998a8a21f5e0542da21365a3abaaaae2da12a2

commit f0998a8a21f5e0542da21365a3abaaaae2da12a2
Author: vitaliii <vitaliii@chromium.org>
Date: Thu May 17 08:19:07 2018

[Sync] Add consent_specifics proto.

Add consent_specifics proto as a preparation for separation of consents
into a separate model type from user events. The proto is based on
UserEventSpecifics::UserConsent. The proto has to land before the actual
split itself, so that the server is aware of the new datatype.

Bug:  840357 
Change-Id: I2d3ab6575990d081315a93725fb5cee655af63b9
Reviewed-on: https://chromium-review.googlesource.com/1055567
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Markus Heintz <markusheintz@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559453}
[modify] https://crrev.com/f0998a8a21f5e0542da21365a3abaaaae2da12a2/components/sync/protocol/proto_enum_conversions.cc
[modify] https://crrev.com/f0998a8a21f5e0542da21365a3abaaaae2da12a2/components/sync/protocol/proto_enum_conversions.h
[modify] https://crrev.com/f0998a8a21f5e0542da21365a3abaaaae2da12a2/components/sync/protocol/proto_value_conversions.cc
[modify] https://crrev.com/f0998a8a21f5e0542da21365a3abaaaae2da12a2/components/sync/protocol/proto_value_conversions.h
[modify] https://crrev.com/f0998a8a21f5e0542da21365a3abaaaae2da12a2/components/sync/protocol/proto_value_conversions_unittest.cc
[modify] https://crrev.com/f0998a8a21f5e0542da21365a3abaaaae2da12a2/components/sync/protocol/proto_visitors.h
[modify] https://crrev.com/f0998a8a21f5e0542da21365a3abaaaae2da12a2/components/sync/protocol/protocol_sources.gni
[modify] https://crrev.com/f0998a8a21f5e0542da21365a3abaaaae2da12a2/components/sync/protocol/sync.proto
[add] https://crrev.com/f0998a8a21f5e0542da21365a3abaaaae2da12a2/components/sync/protocol/user_consent_specifics.proto

Comment 2 Deleted

We probably won't make it into M68.
Project Member

Comment 4 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ef021b6d000c97eb57c7a34ae4e0c8c63d9e213

commit 3ef021b6d000c97eb57c7a34ae4e0c8c63d9e213
Author: vitaliii <vitaliii@chromium.org>
Date: Tue May 22 15:49:47 2018

[Sync] Move shared user consent types into a separate file.

This CL moves shared user consent types from UserConsentSpecifics and
UserEventSpecifics::UserConsent into a new proto file and then just
imports them.

Reason: Server does not allow protos with the same name in the same
package.

Bug:  840357 
Change-Id: Ib43a827ea046cf417c49d5a8e02251f525ea44f5
Reviewed-on: https://chromium-review.googlesource.com/1065819
Reviewed-by: Markus Heintz <markusheintz@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560609}
[modify] https://crrev.com/3ef021b6d000c97eb57c7a34ae4e0c8c63d9e213/components/consent_auditor/consent_auditor.cc
[modify] https://crrev.com/3ef021b6d000c97eb57c7a34ae4e0c8c63d9e213/components/sync/protocol/proto_enum_conversions.cc
[modify] https://crrev.com/3ef021b6d000c97eb57c7a34ae4e0c8c63d9e213/components/sync/protocol/proto_enum_conversions.h
[modify] https://crrev.com/3ef021b6d000c97eb57c7a34ae4e0c8c63d9e213/components/sync/protocol/proto_enum_conversions_unittest.cc
[modify] https://crrev.com/3ef021b6d000c97eb57c7a34ae4e0c8c63d9e213/components/sync/protocol/proto_visitors.h
[modify] https://crrev.com/3ef021b6d000c97eb57c7a34ae4e0c8c63d9e213/components/sync/protocol/protocol_sources.gni
[modify] https://crrev.com/3ef021b6d000c97eb57c7a34ae4e0c8c63d9e213/components/sync/protocol/user_consent_specifics.proto
[add] https://crrev.com/3ef021b6d000c97eb57c7a34ae4e0c8c63d9e213/components/sync/protocol/user_consent_types.proto
[modify] https://crrev.com/3ef021b6d000c97eb57c7a34ae4e0c8c63d9e213/components/sync/protocol/user_event_specifics.proto

Project Member

Comment 5 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0debefc5963913307abc4d5b7ddf5b2d181e4c66

commit 0debefc5963913307abc4d5b7ddf5b2d181e4c66
Author: vitaliii <vitaliii@chromium.org>
Date: Wed May 30 14:33:57 2018

[Sync] Add ConsentSyncBridge without wiring it.

Add ConsentSyncBridge (interface and implementation) without actually
wiring it to the ConsentAuditor. The bridge itself is heavily based on
UserEventSyncBridge, but the user event related bits were removed. Also
I've tried to make tests easier to understand.

This is the first change in a series to split user consents from user
events into a separate datatype.

Bug:  840357 
Change-Id: Ief8d178d5aaf4b3bc3be68eb4580c811e8c50bb0
Reviewed-on: https://chromium-review.googlesource.com/1076248
Reviewed-by: Markus Heintz <markusheintz@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562814}
[modify] https://crrev.com/0debefc5963913307abc4d5b7ddf5b2d181e4c66/components/consent_auditor/BUILD.gn
[add] https://crrev.com/0debefc5963913307abc4d5b7ddf5b2d181e4c66/components/consent_auditor/consent_sync_bridge.cc
[add] https://crrev.com/0debefc5963913307abc4d5b7ddf5b2d181e4c66/components/consent_auditor/consent_sync_bridge.h
[add] https://crrev.com/0debefc5963913307abc4d5b7ddf5b2d181e4c66/components/consent_auditor/consent_sync_bridge_impl.cc
[add] https://crrev.com/0debefc5963913307abc4d5b7ddf5b2d181e4c66/components/consent_auditor/consent_sync_bridge_impl.h
[add] https://crrev.com/0debefc5963913307abc4d5b7ddf5b2d181e4c66/components/consent_auditor/consent_sync_bridge_impl_unittest.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Jun 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f6e2b469d473e7f1561842d7a1f9b95299d9354

commit 5f6e2b469d473e7f1561842d7a1f9b95299d9354
Author: vitaliii <vitaliii@chromium.org>
Date: Mon Jun 04 08:09:53 2018

[Sync] Add USER_CONSENTS datatype without enabling it yet.

Add USER_CONSENTS sync datatype without actually enabling and wiring it
(i.e. nothing creates it yet).

This is the second change in a series to split user consents from user
events into a separate datatype.

Bug:  840357 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I92ff38b6c7957d6a5bc366ee01e65bc4ca55c679
Reviewed-on: https://chromium-review.googlesource.com/1078440
Commit-Queue: vitaliii <vitaliii@chromium.org>
Reviewed-by: Siddhartha S <ssid@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564015}
[modify] https://crrev.com/5f6e2b469d473e7f1561842d7a1f9b95299d9354/base/trace_event/memory_infra_background_whitelist.cc
[modify] https://crrev.com/5f6e2b469d473e7f1561842d7a1f9b95299d9354/chrome/browser/sync/chrome_sync_client.cc
[modify] https://crrev.com/5f6e2b469d473e7f1561842d7a1f9b95299d9354/chrome/browser/sync/profile_sync_service_factory_unittest.cc
[modify] https://crrev.com/5f6e2b469d473e7f1561842d7a1f9b95299d9354/components/browser_sync/profile_sync_components_factory_impl.cc
[modify] https://crrev.com/5f6e2b469d473e7f1561842d7a1f9b95299d9354/components/browser_sync/profile_sync_service.cc
[modify] https://crrev.com/5f6e2b469d473e7f1561842d7a1f9b95299d9354/components/sync/base/data_type_histogram.h
[modify] https://crrev.com/5f6e2b469d473e7f1561842d7a1f9b95299d9354/components/sync/base/model_type.h
[modify] https://crrev.com/5f6e2b469d473e7f1561842d7a1f9b95299d9354/components/sync/base/pref_names.cc
[modify] https://crrev.com/5f6e2b469d473e7f1561842d7a1f9b95299d9354/components/sync/base/pref_names.h
[modify] https://crrev.com/5f6e2b469d473e7f1561842d7a1f9b95299d9354/components/sync/base/sync_prefs.cc
[modify] https://crrev.com/5f6e2b469d473e7f1561842d7a1f9b95299d9354/components/sync/driver/model_association_manager.cc
[modify] https://crrev.com/5f6e2b469d473e7f1561842d7a1f9b95299d9354/components/sync/protocol/proto_value_conversions_unittest.cc
[modify] https://crrev.com/5f6e2b469d473e7f1561842d7a1f9b95299d9354/components/sync/protocol/proto_visitors.h
[modify] https://crrev.com/5f6e2b469d473e7f1561842d7a1f9b95299d9354/components/sync/syncable/model_type.cc
[modify] https://crrev.com/5f6e2b469d473e7f1561842d7a1f9b95299d9354/components/sync/syncable/nigori_util.cc
[modify] https://crrev.com/5f6e2b469d473e7f1561842d7a1f9b95299d9354/ios/chrome/browser/sync/ios_chrome_sync_client.mm
[modify] https://crrev.com/5f6e2b469d473e7f1561842d7a1f9b95299d9354/ios/chrome/browser/sync/profile_sync_service_factory_unittest.cc
[modify] https://crrev.com/5f6e2b469d473e7f1561842d7a1f9b95299d9354/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/5f6e2b469d473e7f1561842d7a1f9b95299d9354/tools/metrics/histograms/histograms.xml

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9e0780d4c1e5cde333bb2804a552203f452e94c

commit b9e0780d4c1e5cde333bb2804a552203f452e94c
Author: vitaliii <vitaliii@chromium.org>
Date: Mon Jun 04 08:56:07 2018

[Sync::Cleanup] Build auditor class on demand in its unittests.

Previously, ConsentAuditor was built in SetUp, however, in future we
will need to build it with different parameters in different tests. In
this CL, the tests are refactored to support setting parameters and
building the class on-demand in a test itself.

Bug:  840357 
Change-Id: I49403cafba4cad7a9d36b9afcdec49f30810937d
Reviewed-on: https://chromium-review.googlesource.com/1082482
Reviewed-by: Markus Heintz <markusheintz@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564028}
[modify] https://crrev.com/b9e0780d4c1e5cde333bb2804a552203f452e94c/components/consent_auditor/consent_auditor_unittest.cc

Status: Started (was: Assigned)
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24dfd16490697fb51483555152504665df197a79

commit 24dfd16490697fb51483555152504665df197a79
Author: vitaliii <vitaliii@chromium.org>
Date: Thu Jun 07 18:17:40 2018

[Sync] Wire ConsentSyncBridge behind a feature (not on iOS).

Connect ConsentSyncBridge to ConsentAuditor behind a feature
on all platforms except iOS. ConsentAuditor does not use the
bridge at all yet.

This CL is a part of a series to split user consents from user events
into a separate datatype.

Bug:  840357 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Id23914d4afcf105f21dab856208d98979aa82209
Reviewed-on: https://chromium-review.googlesource.com/1084475
Commit-Queue: vitaliii <vitaliii@chromium.org>
Reviewed-by: Benoit Zanotti <bzanotti@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Markus Heintz <markusheintz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565353}
[modify] https://crrev.com/24dfd16490697fb51483555152504665df197a79/chrome/browser/consent_auditor/consent_auditor_factory.cc
[modify] https://crrev.com/24dfd16490697fb51483555152504665df197a79/chrome/browser/sync/chrome_sync_client.cc
[modify] https://crrev.com/24dfd16490697fb51483555152504665df197a79/chrome/browser/sync/profile_sync_service_factory.cc
[modify] https://crrev.com/24dfd16490697fb51483555152504665df197a79/chrome/browser/sync/profile_sync_service_factory_unittest.cc
[modify] https://crrev.com/24dfd16490697fb51483555152504665df197a79/chrome/browser/sync/user_event_service_factory.cc
[modify] https://crrev.com/24dfd16490697fb51483555152504665df197a79/components/browser_sync/profile_sync_components_factory_impl.cc
[modify] https://crrev.com/24dfd16490697fb51483555152504665df197a79/components/consent_auditor/consent_auditor.cc
[modify] https://crrev.com/24dfd16490697fb51483555152504665df197a79/components/consent_auditor/consent_auditor.h
[modify] https://crrev.com/24dfd16490697fb51483555152504665df197a79/components/consent_auditor/consent_auditor_unittest.cc
[modify] https://crrev.com/24dfd16490697fb51483555152504665df197a79/components/consent_auditor/fake_consent_auditor.cc
[modify] https://crrev.com/24dfd16490697fb51483555152504665df197a79/components/sync/driver/sync_driver_switches.cc
[modify] https://crrev.com/24dfd16490697fb51483555152504665df197a79/components/sync/driver/sync_driver_switches.h
[modify] https://crrev.com/24dfd16490697fb51483555152504665df197a79/ios/chrome/browser/consent_auditor/consent_auditor_factory.cc
[modify] https://crrev.com/24dfd16490697fb51483555152504665df197a79/ios/chrome/browser/sync/profile_sync_service_factory_unittest.cc
[modify] https://crrev.com/24dfd16490697fb51483555152504665df197a79/ios/chrome/browser/ui/authentication/chrome_signin_view_controller_unittest.mm

Project Member

Comment 11 by bugdroid1@chromium.org, Jun 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d36191b3c7cd522efaa31751719d2f953ca3715e

commit d36191b3c7cd522efaa31751719d2f953ca3715e
Author: vitaliii <vitaliii@chromium.org>
Date: Mon Jun 11 07:40:49 2018

[Sync] Emit consents as a separate datatype behind a feature.

If kSyncUserConsentSeparateType feature is enabled (as well as emitting
consents in general), then emit user consents through a separate
datatype instead of user events.

This CL is a part of a series to split user consents from user events
into a separate datatype.

Bug:  840357 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I2a8c4423ba71cb8d31740fb9395f431149414610
Reviewed-on: https://chromium-review.googlesource.com/1084835
Reviewed-by: Markus Heintz <markusheintz@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565942}
[modify] https://crrev.com/d36191b3c7cd522efaa31751719d2f953ca3715e/chrome/browser/about_flags.cc
[modify] https://crrev.com/d36191b3c7cd522efaa31751719d2f953ca3715e/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/d36191b3c7cd522efaa31751719d2f953ca3715e/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/d36191b3c7cd522efaa31751719d2f953ca3715e/components/consent_auditor/BUILD.gn
[modify] https://crrev.com/d36191b3c7cd522efaa31751719d2f953ca3715e/components/consent_auditor/DEPS
[modify] https://crrev.com/d36191b3c7cd522efaa31751719d2f953ca3715e/components/consent_auditor/consent_auditor.cc
[modify] https://crrev.com/d36191b3c7cd522efaa31751719d2f953ca3715e/components/consent_auditor/consent_auditor.h
[modify] https://crrev.com/d36191b3c7cd522efaa31751719d2f953ca3715e/components/consent_auditor/consent_auditor_unittest.cc
[modify] https://crrev.com/d36191b3c7cd522efaa31751719d2f953ca3715e/tools/metrics/histograms/enums.xml

Blocking: 851433
Consents as a separate datatype should already work on non-iOS devices behind a flag (kSyncUserConsentSeparateType, "enable-sync-user-consent-separate-type"). The CL for iOS is ready, waiting for review from Markus.
https://chromium-review.googlesource.com/c/chromium/src/+/1087269

There is remaining cleanup work and we also need to check that the new type works when history sync is disabled. This work will be tracked in separate bugs (see the tracking bug).

Can this we marked as fixed?
I haven't landed the iOS CL yet, thus, no.
Project Member

Comment 15 by bugdroid1@chromium.org, Jun 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17c8012a5f141c22dcc0fc14f2400d1958809fa4

commit 17c8012a5f141c22dcc0fc14f2400d1958809fa4
Author: vitaliii <vitaliii@chromium.org>
Date: Mon Jun 25 09:52:31 2018

[Sync] Use USER_CONSENTS in consent_sync_bridge.

Previously I had to temporarily use USER_EVENTS in
consent_sync_bridge_impl, because it was added before the new datatype.
This CL fixes this.

Bug:  840357 
Change-Id: I4d21598c8155e44baa6b5d99de42416c00996243
Reviewed-on: https://chromium-review.googlesource.com/1095306
Reviewed-by: Markus Heintz <markusheintz@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569994}
[modify] https://crrev.com/17c8012a5f141c22dcc0fc14f2400d1958809fa4/components/consent_auditor/consent_sync_bridge_impl.cc

Project Member

Comment 16 by bugdroid1@chromium.org, Jun 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a4de8ea67d1df1dbd6bd0f51c3d8876be4b5841

commit 0a4de8ea67d1df1dbd6bd0f51c3d8876be4b5841
Author: vitaliii <vitaliii@chromium.org>
Date: Mon Jun 25 09:52:36 2018

[Sync] Wire ConsentSyncBridge behind a feature on iOS.

Connect ConsentSyncBridge to ConsentAuditor behind a feature
on iOS. ConsentAuditor does not use the bridge at all yet.

The bridge is wired to the auditor on all other platforms in
https://chromium-review.googlesource.com/c/chromium/src/+/1084475.

This CL is a part of a series to split user consents from user events
into a separate datatype.

Bug:  840357 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ie47fb3241cfdd64f7962d9d8b62f28578a76c0a1
Reviewed-on: https://chromium-review.googlesource.com/1087269
Reviewed-by: Markus Heintz <markusheintz@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569995}
[modify] https://crrev.com/0a4de8ea67d1df1dbd6bd0f51c3d8876be4b5841/ios/chrome/browser/consent_auditor/BUILD.gn
[modify] https://crrev.com/0a4de8ea67d1df1dbd6bd0f51c3d8876be4b5841/ios/chrome/browser/consent_auditor/consent_auditor_factory.cc
[modify] https://crrev.com/0a4de8ea67d1df1dbd6bd0f51c3d8876be4b5841/ios/chrome/browser/sync/profile_sync_service_factory.cc

Triage ping: Can this be marked as fixed?
(alternatively, are you sure this is a P1 issue?)
Labels: -Pri-1 Pri-2
Status: Fixed (was: Started)
There is still some followup work described in the tracking issue 851433.
The new type is behind SyncUserConsentSeparateType feature.
One can either enable it via about:flags or pass --enable-features=SyncUserConsentSeparateType to the executable
Wiring creates a BUILD.gn cycle (i.e. issue 850428).
Project Member

Comment 22 by bugdroid1@chromium.org, Jul 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/002e7e5bfeed31e6152641759e516a9e28bcc606

commit 002e7e5bfeed31e6152641759e516a9e28bcc606
Author: vitaliii <vitaliii@chromium.org>
Date: Wed Jul 18 13:55:54 2018

[Sync::Consent::iOS] Move factory to sync folder.

Temporarily move consent_auditor_factory.{h,cc} to
ios/chrome/browser/sync.

Otherwise I cannot wire ControllerDelegateOnUIThread for USER_CONSENTS
in ios_chrome_sync_client, because consent_auditor_factory depends on
UserEventService, which is located in sync folder (i.e. this leads to
BUILD.gn cycle).

The plan is to move it back once it does not depend on UserEventService
anymore (i.e. USER_CONSENTS are completely launched).

Bug:  840357 ,850428
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I2157e913ee6d6d3adde86b3121fdb021aed3614c
Reviewed-on: https://chromium-review.googlesource.com/1141583
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Markus Heintz <markusheintz@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576025}
[modify] https://crrev.com/002e7e5bfeed31e6152641759e516a9e28bcc606/ios/chrome/browser/browser_state/BUILD.gn
[modify] https://crrev.com/002e7e5bfeed31e6152641759e516a9e28bcc606/ios/chrome/browser/browser_state/browser_state_keyed_service_factories.mm
[delete] https://crrev.com/1655037ead023cea3b18757ce10b2a98135a34ed/ios/chrome/browser/consent_auditor/BUILD.gn
[delete] https://crrev.com/1655037ead023cea3b18757ce10b2a98135a34ed/ios/chrome/browser/consent_auditor/OWNERS
[modify] https://crrev.com/002e7e5bfeed31e6152641759e516a9e28bcc606/ios/chrome/browser/prefs/BUILD.gn
[modify] https://crrev.com/002e7e5bfeed31e6152641759e516a9e28bcc606/ios/chrome/browser/sync/BUILD.gn
[rename] https://crrev.com/002e7e5bfeed31e6152641759e516a9e28bcc606/ios/chrome/browser/sync/DEPS
[modify] https://crrev.com/002e7e5bfeed31e6152641759e516a9e28bcc606/ios/chrome/browser/sync/OWNERS
[rename] https://crrev.com/002e7e5bfeed31e6152641759e516a9e28bcc606/ios/chrome/browser/sync/consent_auditor_factory.cc
[rename] https://crrev.com/002e7e5bfeed31e6152641759e516a9e28bcc606/ios/chrome/browser/sync/consent_auditor_factory.h
[modify] https://crrev.com/002e7e5bfeed31e6152641759e516a9e28bcc606/ios/chrome/browser/ui/authentication/BUILD.gn
[modify] https://crrev.com/002e7e5bfeed31e6152641759e516a9e28bcc606/ios/chrome/browser/ui/authentication/chrome_signin_view_controller.mm
[modify] https://crrev.com/002e7e5bfeed31e6152641759e516a9e28bcc606/ios/chrome/browser/ui/authentication/chrome_signin_view_controller_unittest.mm

Project Member

Comment 23 by bugdroid1@chromium.org, Jul 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec63e94d1b4ffb3d08c97f5f8c7126ea5dd6d6cf

commit ec63e94d1b4ffb3d08c97f5f8c7126ea5dd6d6cf
Author: vitaliii <vitaliii@chromium.org>
Date: Wed Jul 18 14:16:25 2018

[Sync::Consent::iOS] Wire controller delegate.

Bug:  840357 ,850428
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I21266676a5e097dac3d7cc75dbff8b65a2ce9d1e
Reviewed-on: https://chromium-review.googlesource.com/1141724
Commit-Queue: vitaliii <vitaliii@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576034}
[modify] https://crrev.com/ec63e94d1b4ffb3d08c97f5f8c7126ea5dd6d6cf/ios/chrome/browser/sync/ios_chrome_sync_client.mm
[modify] https://crrev.com/ec63e94d1b4ffb3d08c97f5f8c7126ea5dd6d6cf/ios/chrome/browser/sync/profile_sync_service_factory.cc

Status: Fixed (was: Assigned)

Sign in to add a comment