Issue metadata
Sign in to add a comment
|
Android: Alter framebust / popup UI for unification of the setting |
||||||||||||||||||||||||
Issue descriptionSee go/popup-redirect-unification-ui for mocks. At a high level, we want to add a sticky setting for declining the framebust / tab-under intervention, and we're using the popup setting as our mechanism. This bug should cover the following UIs: - Framebust infobar (used by framebusting and tab-under blocking) - Site settings - Site details - Page info
,
May 7 2018
,
May 7 2018
After chatting with srahim, we decided to use a different string for the site settings view. Screenshot here (replaces the TENTATIVE screenshot above).
,
May 7 2018
Thanks csharrison@! On page-info.png - could you hyphenate 'pop-ups'? Thanks!
,
May 7 2018
Yes it was pre-existing. Thanks for fixing it together, csharrison@!
,
May 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/27b4b13bd0ac8fb50a68ccc2d4b64a77db0ad8ea commit 27b4b13bd0ac8fb50a68ccc2d4b64a77db0ad8ea Author: Charlie Harrison <csharrison@chromium.org> Date: Tue May 08 15:06:30 2018 Add "redirects" to the popup UI on Android This CL: - Makes the framebust infobar's OK button set the popup setting to ALLOW for that site. The OK button is changed to say "ALWAYS ALLOW". - Minor string changes to the framebust infobar - Adds "redirects" to the popup permission, this affects site details, site settings, and page info. Mocks at http://go/popup-redirect-unification-ui Screenshots are located in the linked bug. Bug: 840355 Change-Id: Idd35540d985ae9b61c81c70306868d57fc678742 Reviewed-on: https://chromium-review.googlesource.com/1043470 Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Reviewed-by: Patti <patricialor@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#556799} [modify] https://crrev.com/27b4b13bd0ac8fb50a68ccc2d4b64a77db0ad8ea/chrome/android/java/src/org/chromium/chrome/browser/infobar/FramebustBlockInfoBar.java [modify] https://crrev.com/27b4b13bd0ac8fb50a68ccc2d4b64a77db0ad8ea/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ContentSettingsResources.java [modify] https://crrev.com/27b4b13bd0ac8fb50a68ccc2d4b64a77db0ad8ea/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/27b4b13bd0ac8fb50a68ccc2d4b64a77db0ad8ea/chrome/browser/android/oom_intervention/oom_intervention_tab_helper.cc [modify] https://crrev.com/27b4b13bd0ac8fb50a68ccc2d4b64a77db0ad8ea/chrome/browser/android/oom_intervention/oom_intervention_tab_helper.h [modify] https://crrev.com/27b4b13bd0ac8fb50a68ccc2d4b64a77db0ad8ea/chrome/browser/ui/android/infobars/framebust_block_infobar.cc [modify] https://crrev.com/27b4b13bd0ac8fb50a68ccc2d4b64a77db0ad8ea/chrome/browser/ui/interventions/framebust_block_message_delegate.cc [modify] https://crrev.com/27b4b13bd0ac8fb50a68ccc2d4b64a77db0ad8ea/chrome/browser/ui/interventions/framebust_block_message_delegate.h [modify] https://crrev.com/27b4b13bd0ac8fb50a68ccc2d4b64a77db0ad8ea/chrome/browser/ui/interventions/intervention_delegate.h [modify] https://crrev.com/27b4b13bd0ac8fb50a68ccc2d4b64a77db0ad8ea/chrome/browser/ui/page_info/page_info_ui.cc [modify] https://crrev.com/27b4b13bd0ac8fb50a68ccc2d4b64a77db0ad8ea/components/page_info_strings.grdp
,
May 8 2018
That should be everything. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by csharrison@chromium.org
, May 7 201841.4 KB
41.4 KB View Download
45.1 KB
45.1 KB View Download
44.1 KB
44.1 KB View Download
35.0 KB
35.0 KB View Download
48.4 KB
48.4 KB View Download