New issue
Advanced search Search tips

Issue 840352 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 839446



Sign in to add a comment

Allow framebusts from a site if the user allowed popups on that site

Project Member Reported by csharrison@chromium.org, May 7 2018

Issue description

See more information on  issue 839446 . We are combining the popup setting into a "popup and redirects" setting.

This will involve plumbing the "popup" content setting rules into the renderer via mojo.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4dfc4d7fbbea2d059fc53cee2fed70a63d4960c0

commit 4dfc4d7fbbea2d059fc53cee2fed70a63d4960c0
Author: Charlie Harrison <csharrison@chromium.org>
Date: Mon May 07 21:58:11 2018

Framebusting: Control via popup setting

Some of the new redirect-style interventions require a sticky
permission bit. There is a plan to govern these interventions via
the popup setting.

This CL does a few things:
1. Start sending down popup settings to the renderer via
   content_settings.mojom

2. Modify framebust logic to allow the framebust (but still log a
   warning) if the setting is set to allow

3. Modify FramebustBlockTabHelper to allow for setting multiple observers,
   to aid in test ergonomics.

4. Add a few browsertests which exercise the new logic end to end.

Follow-up CLs will actually improve the UI to allow for setting this
in response to a framebust being blocked.

Bug:  840352 
Change-Id: Id05eeb20a488ab8691384362c544e1a42f4b5ed6
Reviewed-on: https://chromium-review.googlesource.com/1042360
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556581}
[modify] https://crrev.com/4dfc4d7fbbea2d059fc53cee2fed70a63d4960c0/chrome/browser/ui/blocked_content/framebust_block_tab_helper.cc
[modify] https://crrev.com/4dfc4d7fbbea2d059fc53cee2fed70a63d4960c0/chrome/browser/ui/blocked_content/framebust_block_tab_helper.h
[modify] https://crrev.com/4dfc4d7fbbea2d059fc53cee2fed70a63d4960c0/chrome/browser/ui/content_settings/content_setting_bubble_model.cc
[modify] https://crrev.com/4dfc4d7fbbea2d059fc53cee2fed70a63d4960c0/chrome/browser/ui/content_settings/framebust_block_browsertest.cc
[modify] https://crrev.com/4dfc4d7fbbea2d059fc53cee2fed70a63d4960c0/chrome/renderer/content_settings_observer.cc
[modify] https://crrev.com/4dfc4d7fbbea2d059fc53cee2fed70a63d4960c0/chrome/renderer/content_settings_observer.h
[modify] https://crrev.com/4dfc4d7fbbea2d059fc53cee2fed70a63d4960c0/components/content_settings/core/browser/content_settings_utils.cc
[modify] https://crrev.com/4dfc4d7fbbea2d059fc53cee2fed70a63d4960c0/components/content_settings/core/common/content_settings.h
[modify] https://crrev.com/4dfc4d7fbbea2d059fc53cee2fed70a63d4960c0/components/content_settings/core/common/content_settings.mojom
[modify] https://crrev.com/4dfc4d7fbbea2d059fc53cee2fed70a63d4960c0/components/content_settings/core/common/content_settings_struct_traits.cc
[modify] https://crrev.com/4dfc4d7fbbea2d059fc53cee2fed70a63d4960c0/components/content_settings/core/common/content_settings_struct_traits.h
[modify] https://crrev.com/4dfc4d7fbbea2d059fc53cee2fed70a63d4960c0/components/content_settings/core/common/content_settings_types.h
[modify] https://crrev.com/4dfc4d7fbbea2d059fc53cee2fed70a63d4960c0/third_party/blink/public/platform/web_content_settings_client.h
[modify] https://crrev.com/4dfc4d7fbbea2d059fc53cee2fed70a63d4960c0/third_party/blink/renderer/core/frame/content_settings_client.cc
[modify] https://crrev.com/4dfc4d7fbbea2d059fc53cee2fed70a63d4960c0/third_party/blink/renderer/core/frame/content_settings_client.h
[modify] https://crrev.com/4dfc4d7fbbea2d059fc53cee2fed70a63d4960c0/third_party/blink/renderer/core/frame/local_frame.cc

Status: Fixed (was: Started)

Sign in to add a comment