New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 840348 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-05-17
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug-Regression

Blocking:
issue 706331



Sign in to add a comment

some videos no longer play on Chrome PC beta and Android Beta

Reported by bgin...@gmail.com, May 7 2018

Issue description

Chrome Version       : Version 67.0.3396.30 (PC) Version 67.0.3396.29 (Android)
URLs (if applicable) : Most videos on vrv.co. Example: https://vrv.co/watch/GRGG8JE1R/My-Hero-Academia:Izuku-Midoriya-Origin


Other browsers tested:
  Add OK or FAIL after other browsers where you have tested this issue:

       Edge: 42.17134.1.0 PASSES
Older Version of Chrome: Version 66.0.3359.139 (Official Build) (64-bit) PASSES
Current Version of Android Chrome: Version 66.0.3359.126 PASSES

What steps will reproduce the problem?
(1) Enter URL https://vrv.co/watch/GRGG8JE1R/My-Hero-Academia:Izuku-Midoriya-Origin into browser
(2) Try to play and pause video
(3)

What is the expected result?
 Able to play and pause video on vrv.co in Chrome Beta browsers


What happens instead?
Unable to play videos to cast or play in Daydream


Please provide any additional information below. Attach a screenshot if
possible.


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 
Components: Internals>Media>Video
Labels: Needs-Triage-M67
Cc: krajshree@chromium.org
Labels: Needs-Feedback Triaged-ET
bgino74@ - Thanks for filing the issue...!!

Could you please provide any other sample file/url to test the issue from TE-end as the url provided in comment #0 i.e https://vrv.co/watch/GRGG8JE1R/My-Hero-Academia:Izuku-Midoriya-Origin is not available at our region.

Thanks...!!
Screen Shot 2018-05-08 at 18.27.39.png
917 KB View Download

Comment 4 by bgin...@gmail.com, May 8 2018

Unfortunately I have not found another site where I am experiencing this issue. I have also opened a support ticket with VRV to let them know about this potential issue. I noticed it was only happening with certain videos linked to specific channels while others would play from other channels. 
Project Member

Comment 5 by sheriffbot@chromium.org, May 8 2018

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: phanindra.mandapaka@chromium.org
Labels: TE-NeedsTriageFromMTV
Unable to test this issue from TE end as "not available at your region""error is seen.Hence forwarding this issue to MTV, could any one of the team have a look on this issue.

Thanks..! 
Cc: pbomm...@chromium.org rsgav...@chromium.org ligim...@chromium.org
Labels: -Type-Bug -Pri-3 ReleaseBlock-Stable M-67 Needs-Bisect OS-Android Pri-1 Type-Bug-Regression
Works fine in stable- 66.0.3359.170 , but broken in Beta- 67.0.3396.40.

Over to MTV folks since HYD team cannot access the URLs.
Cc: prashanthpola@chromium.org
Cc: hbengali@chromium.org johnpallett@chromium.org
looks like a site issue, +pms who might have a contact there.
Labels: -TE-NeedsTriageFromMTV -Needs-Bisect -Needs-Triage-M67 hasbisect-per-revision
Owner: horo@chromium.org
Status: Assigned (was: Unconfirmed)
We are able to repro the issue on Chrome:67.0.3396.42 Device:Pixel 2 XL/8.1.0

Bisect info:
Good build:67.0.3379.0
Bad build:67.0.3381.0
Regression range:
https://chromium.googlesource.com/chromium/src/+log/67.0.3379.0..67.0.3381.0?pretty=fuller&n=10000

Good commit:545753
Bad commit:545754
Culprit CL: 
https://chromium.googlesource.com/chromium/src/+/5e1b52dd7e828fb2e4bd69f599c0c30eec3e873c

Comment 11 by horo@chromium.org, May 15 2018

I can't access the URL from Japan...
M67 Stable promotion is coming soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. Thank you.
Is there anyone on the loading team in the US that you can assign this to horo@ ? I also sent you an e-mail with some other details. Here are the error logs:

Creating Application Cache with manifest https://static.vrv.co/vilos/manifest.appcache
My-Hero-Academia:Izuku-Midoriya-Origin:1 Application Cache Checking event
My-Hero-Academia:Izuku-Midoriya-Origin:1 Application Cache Downloading event
player.html:2840 VIDEOJS: WARN: this.options() has been deprecated and will be moved to the constructor in 6.0
c.logByType @ player.html:2840
My-Hero-Academia:Izuku-Midoriya-Origin:1 Application Cache Progress event (0 of 9) https://static.vrv.co/vilos/libass/both/subtitles-octopus-worker.data
My-Hero-Academia:Izuku-Midoriya-Origin:1 Application Cache Progress event (1 of 9) https://static.vrv.co/vilos/libass/both/subtitles-octopus-worker.js.mem
2VM65 player.html:2840 VIDEOJS: WARN: this.options() has been deprecated and will be moved to the constructor in 6.0
c.logByType @ VM65 player.html:2840
My-Hero-Academia:Izuku-Midoriya-Origin:1 Application Cache Progress event (2 of 9) https://static.vrv.co/vilos/libass/both/subtitles-octopus-worker.asm.js
35fd74.v.fwmrm.net/:1 Uncaught ReferenceError: sdnyads146 is not defined
    at 5fd74.v.fwmrm.net/:1
My-Hero-Academia:Izuku-Midoriya-Origin:1 Application Cache Progress event (3 of 9) https://static.vrv.co/vilos/libass/both/subtitles-octopus-worker.wasm
My-Hero-Academia:Izuku-Midoriya-Origin:1 Application Cache Progress event (4 of 9) https://static.vrv.co/vilos/libass/asmjs/subtitles-octopus-worker.js.mem
My-Hero-Academia:Izuku-Midoriya-Origin:1 Application Cache Progress event (5 of 9) https://static.vrv.co/vilos/libass/both/subtitles-octopus-worker.js
My-Hero-Academia:Izuku-Midoriya-Origin:1 Application Cache Progress event (6 of 9) https://static.vrv.co/vilos/libass/asmjs/subtitles-octopus-worker.js
My-Hero-Academia:Izuku-Midoriya-Origin:1 Application Cache Progress event (7 of 9) https://static.vrv.co/vilos/player.html
My-Hero-Academia:Izuku-Midoriya-Origin:1 Application Cache Progress event (8 of 9) https://static.vrv.co/vilos/libass/asmjs/subtitles-octopus-worker.data
My-Hero-Academia:Izuku-Midoriya-Origin:1 Application Cache Progress event (9 of 9) 
My-Hero-Academia:Izuku-Midoriya-Origin:1 Application Cache Cached event
player.html:2840 VIDEOJS: Video.js: volume unavailable on Html5 playback technology element. TypeError: Cannot read property 'volume' of null
    at b.J.(anonymous function) [as volume] (https://static.vrv.co/vilos/player.html:2838:29446)
    at b.techGet_ (player.html:2837)
    at b.volume (player.html:2837)
    at Object.get (player.html:2826)
    at f.get (player.html:2824)
    at f.volumeChange (player.html:2823)
    at f.adTriggerReady (player.html:2823)
    at d (player.html:2823)
    at f.e (player.html:2823)
    at f.<anonymous> (player.html:2823)
player.html:2837 Uncaught TypeError: Cannot read property 'volume' of null
    at b.J.(anonymous function) [as volume] (https://static.vrv.co/vilos/player.html:2838:29446)
    at b.techGet_ (player.html:2837)
    at b.volume (player.html:2837)
    at Object.get (player.html:2826)
    at f.get (player.html:2824)
    at f.volumeChange (player.html:2823)
    at f.adTriggerReady (player.html:2823)
    at d (player.html:2823)
    at f.e (player.html:2823)
    at f.<anonymous> (player.html:2823)
player.html:2840 VIDEOJS: Video.js: volume unavailable on Html5 playback technology element. TypeError: Cannot read property 'volume' of null
    at b.J.(anonymous function) [as volume] (https://static.vrv.co/vilos/player.html:2838:29446)
    at b.techGet_ (player.html:2837)
    at b.volume (player.html:2837)
    at Object.get (player.html:2826)
    at f.get (player.html:2824)
    at f.volumeChange (player.html:2823)
    at f.adTriggerReady (player.html:2823)
    at d (player.html:2823)
    at f.e (player.html:2823)
    at f.<anonymous> (player.html:2823)
player.html:2837 Uncaught TypeError: Cannot read property 'volume' of null
    at b.J.(anonymous function) [as volume] (https://static.vrv.co/vilos/player.html:2838:29446)
    at b.techGet_ (player.html:2837)
    at b.volume (player.html:2837)
    at Object.get (player.html:2826)
    at f.get (player.html:2824)
    at f.volumeChange (player.html:2823)
    at f.adTriggerReady (player.html:2823)
    at d (player.html:2823)
    at f.e (player.html:2823)
    at f.<anonymous> (player.html:2823)
player.html:2827 Uncaught Error: Worker error: [object ErrorEvent]
    at Worker.d.workerError (player.html:2827)

Comment 14 by horo@chromium.org, May 16 2018

Components: Blink>Workers

Comment 15 by horo@chromium.org, May 16 2018

Components: Blink>Network>XHR Blink>Loader

Comment 16 by horo@chromium.org, May 16 2018

Status: Started (was: Assigned)

Comment 17 by horo@chromium.org, May 16 2018

Blocking: 706331
Project Member

Comment 18 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14b1861dc42443535a48b97c09126f1f59cd4088

commit 14b1861dc42443535a48b97c09126f1f59cd4088
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Wed May 16 09:44:48 2018

Revive WorkerThreadableLoader for sync XHR again

The cl "5e1b52dd7e828fb2e4bd69f599c0c30eec3e873c" which made ThreadableLoader
use DocumentThreadableLoader for sync loading from worker thread had broken
existing site.  https://crbug.com/840348 

This is because DocumentThreadableLoader::LoadResourceSynchronously() doesn't
support CORS after redirect.

It is difficult to make DocumentThreadableLoader::LoadResourceSynchronously()
support it. So This CL revives WorkerThreadableLoader for sync XHR.

Bug:  840348 ,  706331 
Change-Id: Ib41fc442ddca508011431609cad1b6b6f9bda537
Reviewed-on: https://chromium-review.googlesource.com/1060793
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559023}
[modify] https://crrev.com/14b1861dc42443535a48b97c09126f1f59cd4088/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/workers/access-control-basic-get-fail-non-simple-expected.txt
[modify] https://crrev.com/14b1861dc42443535a48b97c09126f1f59cd4088/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/workers/cross-origin-unsupported-url-expected.txt
[add] https://crrev.com/14b1861dc42443535a48b97c09126f1f59cd4088/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/workers/resources/sync-cors-after-redirect-on-worker-worker.js
[add] https://crrev.com/14b1861dc42443535a48b97c09126f1f59cd4088/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/workers/sync-cors-after-redirect-on-worker.html
[modify] https://crrev.com/14b1861dc42443535a48b97c09126f1f59cd4088/third_party/blink/renderer/core/loader/threadable_loader.cc

Comment 19 by horo@chromium.org, May 16 2018

Status: Fixed (was: Started)
I think this issue was fixed by 14b1861dc42443535a48b97c09126f1f59cd4088.

dalecurtis@
Could you please verify that this issue is fixed after the patch will land in Canary?
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-67; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-67 label, otherwise remove Merge-TBD label. Thanks.

Comment 21 by horo@chromium.org, May 16 2018

Labels: -Merge-TBD Merge-Request-67
Project Member

Comment 22 by sheriffbot@chromium.org, May 16 2018

Labels: -Merge-Request-67 Merge-Review-67 Hotlist-Merge-Review
This bug requires manual review: We are only 12 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 23 by horo@chromium.org, May 16 2018

Labels: OS-Chrome OS-Linux OS-Mac
Project Member

Comment 24 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b00991ee27817b60b2a142261bd1d89ca253615

commit 4b00991ee27817b60b2a142261bd1d89ca253615
Author: Łukasz Anforowicz <lukasza@chromium.org>
Date: Wed May 16 15:11:09 2018

Revert "Revive WorkerThreadableLoader for sync XHR again"

This reverts commit 14b1861dc42443535a48b97c09126f1f59cd4088.

Reason for revert: This CL introduced a layout test that seems to be consistently failing on Win10 starting in https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/35033 in http/tests/xmlhttprequest/workers/sync-cors-after-redirect-on-worker.html:

FAIL Synchronous CORS XHR after redirect on worker assert_equals: expected "PASS: Cross-domain access allowed.\n" but got "PASS: Cross-domain access allowed.\r\n"

Original change's description:
> Revive WorkerThreadableLoader for sync XHR again
> 
> The cl "5e1b52dd7e828fb2e4bd69f599c0c30eec3e873c" which made ThreadableLoader
> use DocumentThreadableLoader for sync loading from worker thread had broken
> existing site.  https://crbug.com/840348 
> 
> This is because DocumentThreadableLoader::LoadResourceSynchronously() doesn't
> support CORS after redirect.
> 
> It is difficult to make DocumentThreadableLoader::LoadResourceSynchronously()
> support it. So This CL revives WorkerThreadableLoader for sync XHR.
> 
> Bug:  840348 ,  706331 
> Change-Id: Ib41fc442ddca508011431609cad1b6b6f9bda537
> Reviewed-on: https://chromium-review.googlesource.com/1060793
> Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#559023}

TBR=horo@chromium.org,kinuko@chromium.org

Change-Id: I1605a0b591d59737fa09951e6f8d5f3d907d52b4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  840348 ,  706331 
Reviewed-on: https://chromium-review.googlesource.com/1061894
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559101}
[modify] https://crrev.com/4b00991ee27817b60b2a142261bd1d89ca253615/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/workers/access-control-basic-get-fail-non-simple-expected.txt
[modify] https://crrev.com/4b00991ee27817b60b2a142261bd1d89ca253615/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/workers/cross-origin-unsupported-url-expected.txt
[delete] https://crrev.com/f5f34321c9cc5fc976bb8dbb514ead9597ed9d73/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/workers/resources/sync-cors-after-redirect-on-worker-worker.js
[delete] https://crrev.com/f5f34321c9cc5fc976bb8dbb514ead9597ed9d73/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/workers/sync-cors-after-redirect-on-worker.html
[modify] https://crrev.com/4b00991ee27817b60b2a142261bd1d89ca253615/third_party/blink/renderer/core/loader/threadable_loader.cc

Project Member

Comment 25 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1e172c8d0e85286f9025f291c3fc3e719bc30ff

commit b1e172c8d0e85286f9025f291c3fc3e719bc30ff
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Wed May 16 15:26:48 2018

Reland "Revive WorkerThreadableLoader for sync XHR again"

This reverts commit 4b00991ee27817b60b2a142261bd1d89ca253615.

Reason for revert: It is easy to fix the test failure.

Original change's description:
> Revert "Revive WorkerThreadableLoader for sync XHR again"
> 
> This reverts commit 14b1861dc42443535a48b97c09126f1f59cd4088.
> 
> Reason for revert: This CL introduced a layout test that seems to be consistently failing on Win10 starting in https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/35033 in http/tests/xmlhttprequest/workers/sync-cors-after-redirect-on-worker.html:
> 
> FAIL Synchronous CORS XHR after redirect on worker assert_equals: expected "PASS: Cross-domain access allowed.\n" but got "PASS: Cross-domain access allowed.\r\n"
> 
> Original change's description:
> > Revive WorkerThreadableLoader for sync XHR again
> > 
> > The cl "5e1b52dd7e828fb2e4bd69f599c0c30eec3e873c" which made ThreadableLoader
> > use DocumentThreadableLoader for sync loading from worker thread had broken
> > existing site.  https://crbug.com/840348 
> > 
> > This is because DocumentThreadableLoader::LoadResourceSynchronously() doesn't
> > support CORS after redirect.
> > 
> > It is difficult to make DocumentThreadableLoader::LoadResourceSynchronously()
> > support it. So This CL revives WorkerThreadableLoader for sync XHR.
> > 
> > Bug:  840348 ,  706331 
> > Change-Id: Ib41fc442ddca508011431609cad1b6b6f9bda537
> > Reviewed-on: https://chromium-review.googlesource.com/1060793
> > Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#559023}
> 
> TBR=horo@chromium.org,kinuko@chromium.org
> 
> Change-Id: I1605a0b591d59737fa09951e6f8d5f3d907d52b4
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  840348 ,  706331 
> Reviewed-on: https://chromium-review.googlesource.com/1061894
> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#559101}

TBR=horo@chromium.org,kinuko@chromium.org,lukasza@chromium.org

Change-Id: I6d078b4124defec2f9d7514b95eed00ff6f685f5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  840348 ,  706331 
Reviewed-on: https://chromium-review.googlesource.com/1061435
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559107}
[modify] https://crrev.com/b1e172c8d0e85286f9025f291c3fc3e719bc30ff/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/workers/access-control-basic-get-fail-non-simple-expected.txt
[modify] https://crrev.com/b1e172c8d0e85286f9025f291c3fc3e719bc30ff/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/workers/cross-origin-unsupported-url-expected.txt
[add] https://crrev.com/b1e172c8d0e85286f9025f291c3fc3e719bc30ff/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/workers/resources/sync-cors-after-redirect-on-worker-worker.js
[add] https://crrev.com/b1e172c8d0e85286f9025f291c3fc3e719bc30ff/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/workers/sync-cors-after-redirect-on-worker.html
[modify] https://crrev.com/b1e172c8d0e85286f9025f291c3fc3e719bc30ff/third_party/blink/renderer/core/loader/threadable_loader.cc

Comment 26 Deleted

This cl was reverted at #24 and reland with test failure fix at #25. 
Will this be a safe merge to M67? Also pls update the bug with canary result tomorrow.

Comment 28 by horo@chromium.org, May 16 2018

It is safe to merge to M67.
This CL was reverted just because the added test failed on windows because of the newline character difference "\n vs \r\n".
Thank you horo@. Change is not yet baked/verified in canary yet, so pls update the bug with canary result tomorrow.
Today's canary didn't get the fix, will have to try tomorrow.
Yes, the change will be in tonight's canary which will be cut at 8:00 PM PT today.

Comment 32 by horo@chromium.org, May 17 2018

The patch b1e172c8d0e85286f9025f291c3fc3e719bc30ff landed in 68.0.3433.0.
And I verified that Mac Chrome Canary 68.0.3433.0 can play the video of https://vrv.co/watch/GRGG8JE1R/My-Hero-Academia:Izuku-Midoriya-Origin.
The NextAction date has arrived: 2018-05-17
Labels: -Merge-Review-67 Merge-Approved-67
Approving merge to M67 branch 3396 based on comment #28 and #32. Pls merge if change continue to look good in canary (no stability or any other regression due to this fix). Thank you.
Project Member

Comment 35 by bugdroid1@chromium.org, May 18 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6375357dec9578dc907cacc22824c0923754adbf

commit 6375357dec9578dc907cacc22824c0923754adbf
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Fri May 18 00:42:09 2018

[Merge to M67] Reland "Revive WorkerThreadableLoader for sync XHR again"

TBR=kinuko@chromium.org

This reverts commit 4b00991ee27817b60b2a142261bd1d89ca253615.

Reason for revert: It is easy to fix the test failure.

Original change's description:
> Revert "Revive WorkerThreadableLoader for sync XHR again"
>
> This reverts commit 14b1861dc42443535a48b97c09126f1f59cd4088.
>
> Reason for revert: This CL introduced a layout test that seems to be consistently failing on Win10 starting in https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/35033 in http/tests/xmlhttprequest/workers/sync-cors-after-redirect-on-worker.html:
>
> FAIL Synchronous CORS XHR after redirect on worker assert_equals: expected "PASS: Cross-domain access allowed.\n" but got "PASS: Cross-domain access allowed.\r\n"
>
> Original change's description:
> > Revive WorkerThreadableLoader for sync XHR again
> >
> > The cl "5e1b52dd7e828fb2e4bd69f599c0c30eec3e873c" which made ThreadableLoader
> > use DocumentThreadableLoader for sync loading from worker thread had broken
> > existing site.  https://crbug.com/840348 
> >
> > This is because DocumentThreadableLoader::LoadResourceSynchronously() doesn't
> > support CORS after redirect.
> >
> > It is difficult to make DocumentThreadableLoader::LoadResourceSynchronously()
> > support it. So This CL revives WorkerThreadableLoader for sync XHR.
> >
> > Bug:  840348 ,  706331 
> > Change-Id: Ib41fc442ddca508011431609cad1b6b6f9bda537
> > Reviewed-on: https://chromium-review.googlesource.com/1060793
> > Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#559023}
>
> TBR=horo@chromium.org,kinuko@chromium.org
>
> Change-Id: I1605a0b591d59737fa09951e6f8d5f3d907d52b4
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  840348 ,  706331 
> Reviewed-on: https://chromium-review.googlesource.com/1061894
> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#559101}

TBR=horo@chromium.org,kinuko@chromium.org,lukasza@chromium.org

(cherry picked from commit b1e172c8d0e85286f9025f291c3fc3e719bc30ff)

Change-Id: I6d078b4124defec2f9d7514b95eed00ff6f685f5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  840348 ,  706331 
Reviewed-on: https://chromium-review.googlesource.com/1061435
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#559107}
Reviewed-on: https://chromium-review.googlesource.com/1064652
Cr-Commit-Position: refs/branch-heads/3396@{#633}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/6375357dec9578dc907cacc22824c0923754adbf/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/workers/access-control-basic-get-fail-non-simple-expected.txt
[modify] https://crrev.com/6375357dec9578dc907cacc22824c0923754adbf/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/workers/cross-origin-unsupported-url-expected.txt
[add] https://crrev.com/6375357dec9578dc907cacc22824c0923754adbf/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/workers/resources/sync-cors-after-redirect-on-worker-worker.js
[add] https://crrev.com/6375357dec9578dc907cacc22824c0923754adbf/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/workers/sync-cors-after-redirect-on-worker.html
[modify] https://crrev.com/6375357dec9578dc907cacc22824c0923754adbf/third_party/blink/renderer/core/loader/threadable_loader.cc

Sign in to add a comment