New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 840347 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

AEC3 echo leakage for closed headsets with non-negligible echo

Project Member Reported by peah@chromium.org, May 7 2018

Issue description

Some closed headsets have fairly strong echo leakage due to the electrical coupling between the headset wires. Often that leakage is time-varying. AEC3 has been shown to perform poorly for some such setups.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 7 2018

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/9ad845d2ab5cbc146c4afbe9cf7158a2bb710626

commit 9ad845d2ab5cbc146c4afbe9cf7158a2bb710626
Author: Per Åhgren <peah@webrtc.org>
Date: Mon May 07 13:52:08 2018

Soften the AEC3 transparent mode to handle broken headsets

This CL softens the effect of the AEC3 transparent mode to also handle
headsets that leak low-level echoes in a nonlinear way.
This is handled by reintroducing the limit in the echo path gain for the
nonlinear mode. Due to recent improvements in echo suppressor behavior
this is now possible to do with a limited impact on the near-end speech.

Bug:  webrtc:9246 , chromium:840347 
Change-Id: I0ca5157160d1884ba93b962323b56016756986d3
Reviewed-on: https://webrtc-review.googlesource.com/74703
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Commit-Queue: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23145}
[modify] https://crrev.com/9ad845d2ab5cbc146c4afbe9cf7158a2bb710626/modules/audio_processing/aec3/residual_echo_estimator.cc
[modify] https://crrev.com/9ad845d2ab5cbc146c4afbe9cf7158a2bb710626/modules/audio_processing/aec3/residual_echo_estimator.h

Project Member

Comment 2 by bugdroid1@chromium.org, May 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71098015063adea710cce4616686d08d65fc1940

commit 71098015063adea710cce4616686d08d65fc1940
Author: webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Mon May 07 20:43:08 2018

Roll src/third_party/webrtc/ 823f9135f..d5ef6ff25 (15 commits)

https://webrtc.googlesource.com/src.git/+log/823f9135f858..d5ef6ff258da

$ git log 823f9135f..d5ef6ff25 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=chromium:None,chromium:None,chromium:840347,chromium:839860,chromium:838402


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ibaedd51469f75941f90aed9f4ba6bb686cd79f6c
Reviewed-on: https://chromium-review.googlesource.com/1048112
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#556561}
[modify] https://crrev.com/71098015063adea710cce4616686d08d65fc1940/DEPS

Project Member

Comment 3 by bugdroid1@chromium.org, May 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1429ef7c2699d69eec780f6f8beba5ecab9e312

commit d1429ef7c2699d69eec780f6f8beba5ecab9e312
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Tue May 08 03:27:37 2018

Revert "Roll src/third_party/webrtc/ 823f9135f..d5ef6ff25 (15 commits)"

This reverts commit 71098015063adea710cce4616686d08d65fc1940.

Reason for revert: ios build is still broken.
https://ci.chromium.org/buildbot/chromium.mac/ios-device-xcode-clang/59679

Original change's description:
> Roll src/third_party/webrtc/ 823f9135f..d5ef6ff25 (15 commits)
> 
> https://webrtc.googlesource.com/src.git/+log/823f9135f858..d5ef6ff258da
> 
> $ git log 823f9135f..d5ef6ff25 --date=short --no-merges --format='%ad %ae %s'
> 
> Created with:
>   roll-dep src/third_party/webrtc
> BUG=chromium:None,chromium:None,chromium:840347,chromium:839860,chromium:838402
> 
> 
> The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org
> 
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
> 
> If the roll is causing failures, please contact the current sheriff, who should
> be CC'd on the roll, and stop the roller if necessary.
> 
> 
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
> TBR=webrtc-chromium-sheriffs-robots@google.com
> 
> Change-Id: Ibaedd51469f75941f90aed9f4ba6bb686cd79f6c
> Reviewed-on: https://chromium-review.googlesource.com/1048112
> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
> Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#556561}

TBR=webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com,webrtc-chromium-sheriffs-robots@google.com

Change-Id: I2823387c7aadad799befbf88cc5b4503a379dd3c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:None, chromium:840347, chromium:839860, chromium:838402
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/1049345
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556675}
[modify] https://crrev.com/d1429ef7c2699d69eec780f6f8beba5ecab9e312/DEPS

Project Member

Comment 4 by bugdroid1@chromium.org, May 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebc7dc2c2cccb2e04ed594fa68c0a1fb0d7a59e6

commit ebc7dc2c2cccb2e04ed594fa68c0a1fb0d7a59e6
Author: webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue May 08 14:16:42 2018

Roll src/third_party/webrtc/ 823f9135f..826738b78 (29 commits)

https://webrtc.googlesource.com/src.git/+log/823f9135f858..826738b78c6a

$ git log 823f9135f..826738b78 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:840347,chromium:839860,chromium:838402


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I555e922aefb9dac0e262c32fe8562a47f7a15144
Reviewed-on: https://chromium-review.googlesource.com/1049945
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#556789}
[modify] https://crrev.com/ebc7dc2c2cccb2e04ed594fa68c0a1fb0d7a59e6/DEPS

Comment 5 by peah@chromium.org, May 11 2018

Cc: gustaf@chromium.org huib@chromium.org hlundin@chromium.org
Labels: Merge-Request-67
We would like to merge this into M67. 

The CL addresses problems with VoIP calls with poor headsets that leaked echo identified during testing of the last M67 Beta.

The CL we would like to merge is:
-https://webrtc-review.googlesource.com/74703 (Soften the AEC3 transparent mode to handle broken headsets)

The CL has been tested both in Canary and in offline testing and works well.

The merge is safe in the sense that the code affected is beneath an experimental flag. Furthermore, a field_trial switch was added that can be used to turn off the functionality if needed. 
Project Member

Comment 6 by sheriffbot@chromium.org, May 11 2018

Labels: -Merge-Request-67 Merge-Review-67 Hotlist-Merge-Review
This bug requires manual review: DEPS changes referenced in bugdroid comments.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by gov...@chromium.org, May 11 2018

Same comment apply here for M67 merge request - https://bugs.chromium.org/p/chromium/issues/detail?id=841193#c5.

Comment 8 by gov...@chromium.org, May 11 2018

Labels: -Merge-Review-67 Merge-Approved-67
Approving merge to M67 based on comment - https://bugs.chromium.org/p/chromium/issues/detail?id=841193#c6.

Comment 9 by peah@chromium.org, May 12 2018

The CL in #5 was merged.
The merge CL was:
-https://webrtc-review.googlesource.com/c/src/+/76321

Comment 10 by peah@chromium.org, May 12 2018

Labels: M-67 merge-merged-67 Merge-Merged

Comment 11 by peah@chromium.org, May 12 2018

Labels: -Merge-Approved-67

Comment 12 by peah@chromium.org, May 12 2018

Status: Fixed (was: Assigned)

Sign in to add a comment