New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 840345 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 2
Type: Feature


Participants' hotlists:
AudioService-FixIt


Sign in to add a comment

Figure out how to limit audio input stream lifetime to document lifetime

Project Member Reported by maxmorin@chromium.org, May 7 2018

Issue description

The current logic for clearing streams on navigation
void ForwardingAudioStreamFactory::DidFinishNavigation(
    NavigationHandle* navigation_handle) {
  DCHECK_CURRENTLY_ON(BrowserThread::UI);
  if (!navigation_handle->IsSameDocument()) {
    // Document of frame will be destroyed, don't keep any streams around.
    CleanupStreamsBelongingTo(navigation_handle->GetRenderFrameHost());
  }
}

sometimes crashes (saw it in try jobs). Maybe we have to filter out failed navigations or something like that. We can figure it out later. I'll go ahead and remove the navigation-listening code for now.
 
Max - is it still relevant?

Sign in to add a comment