Issue metadata
Sign in to add a comment
|
Regression: Spacing between 'New tab' button and highlight on avatar icon is not proper.
Reported by
db...@etouch.net,
May 7 2018
|
||||||||||||||||||||||
Issue descriptionChrome Version : 68.0.3423.0 (Official Build) 027d74876b8ce24839788395c78dce28b3750d2a-refs/branch-heads/3423@{#1} 32/64-bit OS:Windows 10 What steps will reproduce the problem? (1) Launch chrome, open multiple NTP and then click on avatar icon. (2) Observe space between New tab button and highlight on avatar icon. Actual: Spacing between 'New tab' button and highlight on avatar icon is not proper. Expected: Spacing between 'New tab' button and highlight on avatar icon should be proper. This is a regression issue, broken in 'M68', below is bisect info: Good Build: 68.0.3417.0 Bad Build: 68.0.3418.0 Narrow Bisect: You are probably looking for a change made after 555241 (known good), but no later than 555324 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/faa9754ca738373e93a1fd42c830d8e48232d127..126f89615d87f545ac273ec0ca5a9c1e82bf7e49 Suspect: r555249 ? @pkasting : Could you please help to reassign if your change is not the cause for this change. Note: 1.Unable to narrow down range using bisect per revision hence provinding suspect from narrow bisect. 2.Above is not seen on Windows(7,8,8.1), Mac(10.12.6,10.13.1,10.13.5) and Linux(14.04 LTS) OS.2.
,
Jun 18 2018
,
Jul 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29cbb720f7e3d59ccaf96bbc44fff3a923c3caae commit 29cbb720f7e3d59ccaf96bbc44fff3a923c3caae Author: Peter Kasting <pkasting@chromium.org> Date: Fri Jul 13 03:57:47 2018 Space the new tab button away from the avatar button in maximized mode. This fix applies solely to pre-refresh and corrects a regression in previous refactoring I did in https://crrev.com/555249 . Bug: 840338 Test: Launch chrome in Material (not Refresh) mode; maximized the window and open enough tabs to fill the strip. The new tab button should not be near-touching the profile avatar button. Change-Id: I60598a1e7bcf45e039d19424c8639958094b7658 Reviewed-on: https://chromium-review.googlesource.com/1136065 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#574833} [modify] https://crrev.com/29cbb720f7e3d59ccaf96bbc44fff3a923c3caae/chrome/browser/ui/views/frame/glass_browser_frame_view.cc
,
Jul 13
,
Jul 16
Update : Rechecked the above issue on Windows(10) OS with latest Canary Chrome version : 69.0.3493.0 and the issue is Fixed.Kindly refer the attached screen cast for reference. Thank you.
,
Jul 16
As noted on my checkin instructions, this can't be verified in Refresh mode, only in pre-refresh. That's OK; I don't really care about having test verify it.
,
Jul 31
Unfortunately this bug is now in the stable channel as Chrome 68 is released
,
Jul 31
Yeah, the problem is not big enough to justify a merge of the fix to Chrome 68.
,
Jul 31
workaround: to drag the window you can click on the small triangles between tabs
,
Aug 1
Issue 869373 has been merged into this issue.
,
Aug 6
It sounds like we're planning to do a 68 respin. There's been a number of complaints about this bug publicly. It's been baking on 69/70 for several weeks and the fix is extremely simple and localized. I'd like the M68 release managers to at least consider a 68 merge for this.
,
Aug 7
Thanks pkasting@ - can you please test and verify it? Seems like validation in #6 was done in refresh mode.
,
Aug 7
I verified this in non-refresh (the fix only affects non-refresh).
,
Aug 7
Approving merge to M68. Branch:3440
,
Aug 7
Are you confident that this will not break anything else?
,
Aug 7
Yep. The code is exactly identical in every case but non-refresh maximized windows, and in that case it does something very simple.
,
Aug 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0debdc357c555b53d283725c619968980ceb5879 commit 0debdc357c555b53d283725c619968980ceb5879 Author: Peter Kasting <pkasting@chromium.org> Date: Tue Aug 07 19:28:49 2018 Space the new tab button away from the avatar button in maximized mode. This fix applies solely to pre-refresh and corrects a regression in previous refactoring I did in https://crrev.com/555249 . Bug: 840338 Test: Launch chrome in Material (not Refresh) mode; maximized the window and open enough tabs to fill the strip. The new tab button should not be near-touching the profile avatar button. Change-Id: I60598a1e7bcf45e039d19424c8639958094b7658 Reviewed-on: https://chromium-review.googlesource.com/1136065 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#574833}(cherry picked from commit 29cbb720f7e3d59ccaf96bbc44fff3a923c3caae) Reviewed-on: https://chromium-review.googlesource.com/1165704 Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#793} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/0debdc357c555b53d283725c619968980ceb5879/chrome/browser/ui/views/frame/glass_browser_frame_view.cc
,
Aug 8
Update : Rechecked the above issue on Windows(10) OS with latest StableChrome version : 68.0.3440.106 and the issue is Fixed.Kindly refer the attached screen cast for reference. Thank you.
,
Aug 10
Issue 872970 has been merged into this issue. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by pkasting@chromium.org
, May 7 2018