Issue metadata
Sign in to add a comment
|
[Regression] DevTools: "Store as global variable" not working in Network -> WS -> Frames
Reported by
josh.buc...@gig.com,
May 7 2018
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3423.0 Safari/537.36 Steps to reproduce the problem: 1. Open websocket connection (that is talking JSON) in Network pane 2. Right-click an object in a body, then click "Store as global variable" 3. Observe that the variable (e.g. temp1) is `undefined` What is the expected behavior? The stored variable should reference the object which was stored What went wrong? Variable is not stored Did this work before? Yes Current Stable Chrome version: 68.0.3423.0 Channel: canary OS Version: OS X 10.13.4 Flash Version:
,
May 7 2018
,
May 7 2018
*** Bulk Edit *** M67 Stable promotion is coming VERY soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. If fix is already merged to M67 and nothing else is pending, pls mark the bug as fixed. Thank you.
,
May 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c304c47ca16e77c6a39bc428600d2cf8249f9f90 commit c304c47ca16e77c6a39bc428600d2cf8249f9f90 Author: Erik Luo <luoe@chromium.org> Date: Tue May 08 00:40:41 2018 DevTools: properly call unserializableValue for LocalJSONObject 'Store as global variable' path for LocalJSONObject (e.g. JSONView) was not tested, and broke because: - LocalJSONObject did not override unserializableValue() - ToCallArgument returned instead of invoking unserializableValue() Bug: 840313 Change-Id: I19c7e5eda2d788fdbba397e00af2eecfab7b2888 Reviewed-on: https://chromium-review.googlesource.com/1048105 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#556625} [add] https://crrev.com/c304c47ca16e77c6a39bc428600d2cf8249f9f90/third_party/WebKit/LayoutTests/http/tests/devtools/unit/remote-object-from-local-expected.txt [add] https://crrev.com/c304c47ca16e77c6a39bc428600d2cf8249f9f90/third_party/WebKit/LayoutTests/http/tests/devtools/unit/remote-object-from-local.js [modify] https://crrev.com/c304c47ca16e77c6a39bc428600d2cf8249f9f90/third_party/blink/renderer/devtools/front_end/sdk/RemoteObject.js [modify] https://crrev.com/c304c47ca16e77c6a39bc428600d2cf8249f9f90/third_party/blink/renderer/devtools/front_end/sdk/RuntimeModel.js
,
May 9 2018
This is working again in latest Canary. Thanks!
,
May 9 2018
luoe@ can you please merge-request the CL from Comment#4 into M67 branch.
,
May 9 2018
Thanks for the reminder, requesting here.
,
May 9 2018
This bug requires manual review: M67 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 9 2018
Approving merge to M67 branch 3396 based on comment #5 & per offline chat with luoe@. Please merge ASAP. Also mark the bug as fixed if nothing else is pending after the merge. Thank you.
,
May 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/724ebeffb6c398a3029467ec2f1f99a8f5d0c893 commit 724ebeffb6c398a3029467ec2f1f99a8f5d0c893 Author: Erik Luo <luoe@chromium.org> Date: Wed May 09 22:24:54 2018 DevTools: properly call unserializableValue for LocalJSONObject 'Store as global variable' path for LocalJSONObject (e.g. JSONView) was not tested, and broke because: - LocalJSONObject did not override unserializableValue() - ToCallArgument returned instead of invoking unserializableValue() Bug: 840313 Change-Id: I19c7e5eda2d788fdbba397e00af2eecfab7b2888 Reviewed-on: https://chromium-review.googlesource.com/1048105 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#556625}(cherry picked from commit c304c47ca16e77c6a39bc428600d2cf8249f9f90) Reviewed-on: https://chromium-review.googlesource.com/1053247 Reviewed-by: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#539} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [add] https://crrev.com/724ebeffb6c398a3029467ec2f1f99a8f5d0c893/third_party/WebKit/LayoutTests/http/tests/devtools/unit/remote-object-from-local-expected.txt [add] https://crrev.com/724ebeffb6c398a3029467ec2f1f99a8f5d0c893/third_party/WebKit/LayoutTests/http/tests/devtools/unit/remote-object-from-local.js [modify] https://crrev.com/724ebeffb6c398a3029467ec2f1f99a8f5d0c893/third_party/blink/renderer/devtools/front_end/sdk/RemoteObject.js [modify] https://crrev.com/724ebeffb6c398a3029467ec2f1f99a8f5d0c893/third_party/blink/renderer/devtools/front_end/sdk/RuntimeModel.js
,
May 9 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by woxxom@gmail.com
, May 7 201893.5 KB
93.5 KB View Download
81.3 KB
81.3 KB View Download