New issue
Advanced search Search tips

Issue 840272 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 15
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Rename "pattern" to "scope" in ServiceWorker code

Project Member Reported by pwnall@chromium.org, May 7 2018

Issue description

Our ServiceWorker implementation uses "pattern" instead of "scope" in some places, due to  having co-evolved with the specification. In the context of ServiceWorker, We should rename "pattern" to "scope", wherever it is used in the context of service workers.

References:
https://chromium-review.googlesource.com/c/chromium/src/+/1043064#message-aba8136ffea1f638708dc85a18f9383352bf838a (review comment) and the comments below it

 
I'll probably tackle the big obvious directories soon. Leaving this available in case someone really wants to tackle it before I get to it.
Labels: Hotlist-GoodFirstBug
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2266251fc2d9614936946cefd9475d88f07f978a

commit 2266251fc2d9614936946cefd9475d88f07f978a
Author: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Date: Sat Oct 13 02:59:00 2018

Rename "pattern" to "scope" in ServiceWorker code

In the context of ServiceWorker, We should rename "pattern" to "scope",
wherever it is used in the context of service workers.

Bug:  840272 
Change-Id: I982c179077a2a690ecf06d1efe70bac46fc871ec
Reviewed-on: https://chromium-review.googlesource.com/c/1273197
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Cr-Commit-Position: refs/heads/master@{#599477}
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/chrome/browser/extensions/service_worker_apitest.cc
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/background_fetch/background_fetch_test_base.cc
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/background_sync/background_sync_manager.cc
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/background_sync/background_sync_manager_unittest.cc
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/background_sync/background_sync_service_impl_unittest.cc
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/cookie_store/cookie_store_manager.cc
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/devtools/protocol/service_worker_handler.cc
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/notifications/blink_notification_service_impl.cc
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/payments/payment_app_database.cc
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/payments/payment_app_installer.cc
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/payments/payment_manager_unittest.cc
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/push_messaging/push_messaging_manager.cc
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/service_worker/embedded_worker_instance_unittest.cc
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/service_worker/service_worker_browsertest.cc
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/service_worker/service_worker_context_core.cc
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/service_worker/service_worker_context_core.h
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/service_worker/service_worker_context_core_observer.h
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/service_worker/service_worker_context_unittest.cc
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/service_worker/service_worker_context_watcher.cc
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/service_worker/service_worker_context_watcher.h
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/service_worker/service_worker_context_watcher_unittest.cc
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/service_worker/service_worker_context_wrapper.cc
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/service_worker/service_worker_context_wrapper.h
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/service_worker/service_worker_controllee_request_handler.cc
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/service_worker/service_worker_info.cc
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/service_worker/service_worker_info.h
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/service_worker/service_worker_installed_scripts_sender_unittest.cc
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/service_worker/service_worker_internals_ui.cc
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/service_worker/service_worker_job_coordinator.cc
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/service_worker/service_worker_job_coordinator.h
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/service_worker/service_worker_job_unittest.cc
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/service_worker/service_worker_object_host_unittest.cc
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/service_worker/service_worker_process_manager.cc
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/service_worker/service_worker_process_manager.h
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/service_worker/service_worker_process_manager_unittest.cc
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/service_worker/service_worker_provider_host.h
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/service_worker/service_worker_provider_host_unittest.cc
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/service_worker/service_worker_register_job.cc
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/service_worker/service_worker_register_job.h
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/service_worker/service_worker_register_job_base.h
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/service_worker/service_worker_registration.cc
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/service_worker/service_worker_registration.h
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/service_worker/service_worker_registration_object_host.cc
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/service_worker/service_worker_registration_unittest.cc
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/service_worker/service_worker_storage.cc
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/service_worker/service_worker_storage.h
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/service_worker/service_worker_storage_unittest.cc
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/service_worker/service_worker_unregister_job.cc
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/service_worker/service_worker_unregister_job.h
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/service_worker/service_worker_version.h
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/browser/service_worker/service_worker_version_unittest.cc
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/public/browser/service_worker_context.h
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/public/test/fake_service_worker_context.cc
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/public/test/fake_service_worker_context.h
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/public/test/service_worker_test_helpers.cc
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/content/public/test/service_worker_test_helpers.h
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/extensions/browser/service_worker_task_queue.cc
[modify] https://crrev.com/2266251fc2d9614936946cefd9475d88f07f978a/extensions/browser/service_worker_task_queue.h

Labels: M-72
Owner: zhuoyu.q...@samsung.com
Status: Fixed (was: Available)
Thanks!

Sign in to add a comment