https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyowELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJtY2hyb21pdW0ubGludXgvQ2FzdCBBdWRpbyBMaW51eC8xMDM3My9iYXNlX3VuaXR0ZXN0cy9WR0Z6YTFOamFHVmtkV3hsY2tsdGNHeFVaWE4wTGtsa1pXNTBhV1pwWVdKc1pWTjBZV05yY3c9PQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM This CL should have been auto reverted, but was not. The root cause is due to the check for confidence in suspected build, but should actually be confidence in culprit.
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/a2d1cd21e612ccbbf1b8fc45b6e67afead585498 commit a2d1cd21e612ccbbf1b8fc45b6e67afead585498 Author: Jeffrey Li <lijeffrey@chromium.org> Date: Mon May 07 21:32:35 2018 [Findit] Flake Analyzer - Fix auto revert bailing out incorrectly Criteria for checking whether to auto revert checks for confidence in suspected build. This field is deprecated, and should instead be using confidence in culprit. Bug: 840248 Change-Id: I962aebdce611e7dab99fbafdeda6e188c330cf8f Reviewed-on: https://chromium-review.googlesource.com/1046379 Commit-Queue: Jeffrey Li <lijeffrey@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> [add] https://crrev.com/a2d1cd21e612ccbbf1b8fc45b6e67afead585498/appengine/findit/libs/test/floating_point_util_test.py [modify] https://crrev.com/a2d1cd21e612ccbbf1b8fc45b6e67afead585498/appengine/findit/services/flake_failure/culprit_util.py [add] https://crrev.com/a2d1cd21e612ccbbf1b8fc45b6e67afead585498/appengine/findit/libs/floating_point_util.py [modify] https://crrev.com/a2d1cd21e612ccbbf1b8fc45b6e67afead585498/appengine/findit/services/flake_failure/test/culprit_util_test.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/a2399683297c3c2207dd7fc43417192939a328cf commit a2399683297c3c2207dd7fc43417192939a328cf Author: Jeffrey Li <lijeffrey@chromium.org> Date: Mon May 07 22:15:56 2018 [Findit] Flake Analyzer - Use numpy.isclose when possible Bug: 840248 Change-Id: Ie68f2a6c760bfd5084ce1c80983b14d60915b378 Reviewed-on: https://chromium-review.googlesource.com/1048404 Reviewed-by: Roberto Carrillo <robertocn@chromium.org> Commit-Queue: Jeffrey Li <lijeffrey@chromium.org> [modify] https://crrev.com/a2399683297c3c2207dd7fc43417192939a328cf/appengine/findit/services/flake_failure/culprit_util.py [modify] https://crrev.com/a2399683297c3c2207dd7fc43417192939a328cf/appengine/findit/services/flake_failure/pass_rate_util.py [modify] https://crrev.com/a2399683297c3c2207dd7fc43417192939a328cf/appengine/findit/services/flake_failure/data_point_util.py [delete] https://crrev.com/523b14498c2a3ca4dfef744b3ea65f9e42b74ee2/appengine/findit/libs/floating_point_util.py [delete] https://crrev.com/523b14498c2a3ca4dfef744b3ea65f9e42b74ee2/appengine/findit/libs/test/floating_point_util_test.py [modify] https://crrev.com/a2399683297c3c2207dd7fc43417192939a328cf/appengine/findit/services/flake_failure/test/pass_rate_util_test.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/09c2ab86b6fd6c37a5c7bf47cfd218499d9d6fe2 commit 09c2ab86b6fd6c37a5c7bf47cfd218499d9d6fe2 Author: Jeffrey Li <lijeffrey@chromium.org> Date: Tue May 08 20:55:25 2018 Revert "[Findit] Flake Analyzer - Use numpy.isclose when possible" This reverts commit a2399683297c3c2207dd7fc43417192939a328cf. Reason for revert: isclose is not available in numpy 1.6.1, which is the only version available in GCE Original change's description: > [Findit] Flake Analyzer - Use numpy.isclose when possible > > Bug: 840248 > Change-Id: Ie68f2a6c760bfd5084ce1c80983b14d60915b378 > Reviewed-on: https://chromium-review.googlesource.com/1048404 > Reviewed-by: Roberto Carrillo <robertocn@chromium.org> > Commit-Queue: Jeffrey Li <lijeffrey@chromium.org> TBR=stgao@chromium.org,prasadv@chromium.org,robertocn@chromium.org,lijeffrey@chromium.org,chanli@chromium.org,liaoyuke@chromium.org Change-Id: I178155221b0c9ae5312b93c8877704b29c5df451 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 840248 Reviewed-on: https://chromium-review.googlesource.com/1050026 Reviewed-by: Jeffrey Li <lijeffrey@chromium.org> Commit-Queue: Jeffrey Li <lijeffrey@chromium.org> [modify] https://crrev.com/09c2ab86b6fd6c37a5c7bf47cfd218499d9d6fe2/appengine/findit/services/flake_failure/culprit_util.py [modify] https://crrev.com/09c2ab86b6fd6c37a5c7bf47cfd218499d9d6fe2/appengine/findit/services/flake_failure/pass_rate_util.py [modify] https://crrev.com/09c2ab86b6fd6c37a5c7bf47cfd218499d9d6fe2/appengine/findit/services/flake_failure/data_point_util.py [add] https://crrev.com/09c2ab86b6fd6c37a5c7bf47cfd218499d9d6fe2/appengine/findit/libs/floating_point_util.py [add] https://crrev.com/09c2ab86b6fd6c37a5c7bf47cfd218499d9d6fe2/appengine/findit/libs/test/floating_point_util_test.py [modify] https://crrev.com/09c2ab86b6fd6c37a5c7bf47cfd218499d9d6fe2/appengine/findit/services/flake_failure/test/pass_rate_util_test.py
Comment 1 by bugdroid1@chromium.org
, May 7 2018