New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 840246 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Aura's WindowPortLocal now incorrectly assumes external content is always embedded

Project Member Reported by cblume@chromium.org, May 7 2018

Issue description

When ParentWindowAllocator changed to default generate a valid LocalSurfaceId, it broke an implicit assumption that Aura's WindowPortLocal was relying on.

aura::WindowPortLocal used the default invalid LocalSurfaceId to know it had not generated a valid ID as the result of embedding external content.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c72833ee18071c957291a378c736835e849d25dd

commit c72833ee18071c957291a378c736835e849d25dd
Author: Chris Blume <cblume@chromium.org>
Date: Thu May 10 22:58:24 2018

Fix aura::WindowPortLocal assumption on embedding

When ParentWindowAllocator changed to default generate a valid
LocalSurfaceId, it broke an implicit assumption that Aura's
WindowPortLocal was relying on.

aura::WindowPortLocal used the default invalid LocalSurfaceId to know it
had not generated a valid ID as the result of embedding external
content.

This patch fixes that by keeping the LocalSurfaceId allocator in a
base::Optional and checking that to determine external content
embedding.

BUG= 840246 

Change-Id: Ie5475e239cc237caaf3a68b149f92812746a7129
Reviewed-on: https://chromium-review.googlesource.com/1046378
Commit-Queue: Chris Blume <cblume@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557717}
[modify] https://crrev.com/c72833ee18071c957291a378c736835e849d25dd/ui/aura/local/window_port_local.cc
[modify] https://crrev.com/c72833ee18071c957291a378c736835e849d25dd/ui/aura/local/window_port_local.h

Comment 2 by cblume@chromium.org, May 11 2018

Status: Fixed (was: Assigned)

Sign in to add a comment