Regression:Able to close 'Import bookmarks and settings' overlay without closing 'Close firefox' dialog box.
Reported by
vineetha...@etouch.net,
May 7 2018
|
|||||
Issue descriptionChrome Version: 68.0.3422.0 (Official Build) Revision 5d4f3d59358013f23ff33dcaa2f7881f5a591a09-refs/branch-heads/3422@{#1}(32/64 bit) OS: Mac(10.12.6,10.13.1), 10.13.4(Macbook Pro Touchbar), Windows(7,8,8.1,10) and Linux(14.04) OS Pre-condition: Mozilla Firefox should be launched. What steps will reproduce the problem? (1) Launch Chrome, navigate to chrome://settings/importData. (2) Select 'Mozilla Firefox' option from dropdown click on 'Import' button. (3) Observe that 'Close Firefox' dialog box is seen. (4) Now try closing 'Import bookmarks and settings' overlay and observe. Actual Result: Able to close 'Import bookmarks and settings' overlay even without closing 'Close firefox' dialog box. Expected Result: User should not be able to close 'Import bookmarks and settings' overlay , without closing 'Close firefox' dialog box. This is regression issue broken in ‘M-64’ and providing the bisect using per-revision bisect, Good build: 64.0.3260.0(Revision: 514067) Bad build: 64.0.3261.0(Revision: 514329) You are probably looking for a change made after 514116 (known good), but no later than 514117 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/04f1082efb63369e19ace6dde8b62c8702303b88..6b6e8fe1fcf17e0545c688d1bfda16d6f79fd97e Suspect:https://chromium.googlesource.com/chromium/src/+/6b6e8fe1fcf17e0545c688d1bfda16d6f79fd97e @tapted: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thank You!
,
May 8 2018
It looks like this dialog lost its modality. It was wired in r483837. If we want it to continue to be app-modal we need to keep using NSAlert. If we want it to be window-modal we can turn it into a sheet. We could probably also allow tab-switching and make it tab-modal. But there might be annoying cases like being able to pop the dialog multiple times, or on multiple windows, in either of these flows though.
,
May 9 2018
,
May 30 2018
Can we bisect on Linux or Windows? I confirmed this happen on Linux, but both r514117 and r483837 only affect Mac. (it's possible that this is not a regression on Windows/Linux) Also note that the close[x] on the 'Import bookmarks and settings' overlay has been removed, and the 'Cancel' button is disabled whilst this dialog is showing. I think that lowers the severity. However, a user can still close the _entire tab_ via the tabstrip, or close the browser window. I think that should either be prevented, or it should tear down the `Close Firefox` dialog. Moving to p2 since the [x] on the overlay is gone and this probably isn't a regression on Win/Linux.
,
May 30 2018
Update with respect to Comment #4: Confirmed that the above issue is not a regression on Windows/Linux OS. Also, rechecked the above issue on Windows and Linux for latest Canary #69.0.3445.0 and as rightly mentioned in Comment #4 , observed that, the issue is no longer reproducible on Windows and Linux since the close on the 'Import bookmarks and settings' overlay has been removed and also the 'Cancel' button is disabled.Even if the user closes the tab or the browser window then the 'Close Firefox' dialog also gets closed on Windows and Linux. Hence, the issue is currently seen only on Mac OS, since the dialog stays even after closing the tab or browser window until the user quits the chrome build whereas in good build (64.0.3260.0) we couldn't close/cancel the 'Import bookmarks and settings' overlay or close the tab/browser or Quit chrome without providing an input to the 'Close firefox' dialog.So, still suspecting r514117 for Mac OS. Thank you!
,
Nov 14
Update: Unable to reproduce the above issue on latest canary #72.0.3608.4 using Mac(10.13.1, 10.13.4,10.14.2), Windows(7,8,8.1,10) and Linux(14.04) OS. Please refer attached screen cast for same. Thank You |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by vineetha...@etouch.net
, May 7 2018