New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 840206 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Icon in RHS is incorrect for Team Drives

Project Member Reported by sashab@chromium.org, May 7 2018

Issue description

When the "Team Drives" grand root is selected on the LHS, the team drives appear as folders in the RHS. They should instead have the team drive icon to match how they appear when the "Team Drives" root is expanded in the LHS.
 
Status: Started (was: Assigned)
Summary: Icon in RHS is incorrect for Team Drives (was: Icon in RHS is incorrect for Team Drives grand root)
Project Member

Comment 2 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/276b8f623e9e31ddc315ffb1324aa93be328eeee

commit 276b8f623e9e31ddc315ffb1324aa93be328eeee
Author: Sasha Morrissey <sashab@chromium.org>
Date: Thu May 10 01:36:27 2018

Fix icons for Team Drive Roots to match Directory Tree in Files App

on the RHS are correct (folders should look like team drives).

Test: Select the Team Drives grand root on the LHS, check the icons
Bug:  840206 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2f48f9834f32c7a11f652ac01f377aacd5313413
Reviewed-on: https://chromium-review.googlesource.com/1046346
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557411}
[modify] https://crrev.com/276b8f623e9e31ddc315ffb1324aa93be328eeee/ui/file_manager/file_manager/foreground/css/file_types.css
[add] https://crrev.com/276b8f623e9e31ddc315ffb1324aa93be328eeee/ui/file_manager/file_manager/foreground/images/filetype/2x/filetype_team_drive.png
[add] https://crrev.com/276b8f623e9e31ddc315ffb1324aa93be328eeee/ui/file_manager/file_manager/foreground/images/filetype/2x/filetype_team_drive_active.png
[add] https://crrev.com/276b8f623e9e31ddc315ffb1324aa93be328eeee/ui/file_manager/file_manager/foreground/images/filetype/filetype_team_drive.png
[add] https://crrev.com/276b8f623e9e31ddc315ffb1324aa93be328eeee/ui/file_manager/file_manager/foreground/images/filetype/filetype_team_drive_active.png
[modify] https://crrev.com/276b8f623e9e31ddc315ffb1324aa93be328eeee/ui/file_manager/file_manager/foreground/js/ui/file_table.js
[modify] https://crrev.com/276b8f623e9e31ddc315ffb1324aa93be328eeee/ui/file_manager/file_manager/foreground/js/ui/file_table_list.js

Comment 3 by sashab@chromium.org, May 14 2018

Status: Fixed (was: Started)

Sign in to add a comment